Re: [ovs-dev] [PATCH 3/3] tests: Add tests for performance library module

2018-03-01 Thread Jakub Sitnicki
On Wed, 28 Feb 2018 13:36:34 -0800 Ben Pfaff wrote: > On Wed, Feb 28, 2018 at 03:17:15PM +0100, Jakub Sitnicki wrote: > > Check if performance module is calculating statistics as expected. > > > > Outputs that are currently not as expected have been annotated with FIXME. > > > >

Re: [ovs-dev] [PATCH v4 0/2] Add Performance Measurement Library

2018-03-01 Thread Jakub Sitnicki
On Wed, Feb 28, 2018 at 03:27 PM GMT, Mark Michelson wrote: > On 02/28/2018 08:17 AM, Jakub Sitnicki wrote: [...] >> On Tue, 20 Feb 2018 16:13:30 -0600 >> Mark Michelson wrote: [...] >> 5. The module calculates statistics over durations of time intervals. Is the >>

Re: [ovs-dev] [PATCH] Fix possible timing issues in OVN test cases

2018-03-01 Thread Numan Siddique
On Feb 28, 2018 9:11 PM, "Ben Pfaff" wrote: On Tue, Feb 27, 2018 at 08:17:35PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch fixes timing related failures in some test cases when run with > -j option. It adds --wait=hv when calling

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

2018-03-01 Thread Eelco Chaudron
On 28/02/18 15:23, Róbert Mulik wrote: -Original Message- From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Wednesday, February 21, 2018 1:29 PM To: Róbert Mulik ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v5] Configurable Link State Change

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

2018-03-01 Thread Daniel Alvarez Sanchez
Thanks for the patches Han! In the other patch of the series I left a script to help others review it. On Thu, Mar 1, 2018 at 4:37 AM, Han Zhou wrote: > This patch enables using port group names in ACL match conditions. > Users can create a port group in northbound DB

Re: [ovs-dev] [PATCH 2/2] ovn: Support address sets generated from port groups

2018-03-01 Thread Daniel Alvarez Sanchez
Hi Han, I've tested both patches today on a lab setup and from a performance perspective there's no big difference after merging my IDL patch with 800 ports. However, I must say that this it's greatly improving the reconnection times to OVSDB (now the dumps from ovsdb-server upon reconnection are

Re: [ovs-dev] [PATCH v2] datapath-windows: On Debug builds, dump NBL info based on OVS_DBG_DEFAULT macro

2018-03-01 Thread aserdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Wednesday, February 28, 2018 7:00 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows:

Re: [ovs-dev] [PATCH v3] ovn-controller: Support multiple gateway port on a distributed router

2018-03-01 Thread Numan Siddique
On Feb 28, 2018 6:12 PM, "Guru Shetty" wrote: This is a little more complicated for a quick review. I think it will need a round from me to understand the implications for gateway routers and one round from Numan (or someone from openstack) that use distributed gateway routers.

[ovs-dev] Hardware acceleration enablement in OVS-DPDK

2018-03-01 Thread Chandran, Sugesh
Hello All, I am setting up next call in this series to discuss further on approaches to enable full hardware acceleration in OVS-DPDK. Agenda for this meeting is to discuss further on two proposals (one from Intel and another from Napatech) for enabling full hardware acceleration in OVS-DPDK.

[ovs-dev] [PATCH 2/2] tests/ofproto-dpif: New test for action_set after traversing patch port

2018-03-01 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/ofproto-dpif.at | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 600afdda8528..73ad50b6f3d4 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: translate action_set in clone action

2018-03-01 Thread Eric Garver
A clone action saves the action_set prior to performing the clone, then restores it afterwards. However when xlating the actions it neglects to consider the action_set so any write_action() inside a clone() are ignored. Unfortunately patch ports are internally implemented via clone(). So a frame

Re: [ovs-dev] Hardware acceleration enablement in OVS-DPDK

2018-03-01 Thread Rashid Khan
Sorry folks for the spam I thought this was a different thread between Intel and RH. Sorry my bad. Please ignore me. On Thu, Mar 1, 2018 at 4:55 PM, Rashid Khan wrote: > Added Don, Kevin and Bill from RH side to this thread. > Sugesh, kindly please keep them in the loop. >

Re: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

2018-03-01 Thread aserdean
There is a small nit, win 10 targets contain regular ' ' instead of a '\t' in the Makefile. I will change it and apply on master. Thanks a lot for the patch. Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org

Re: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

2018-03-01 Thread Shashank Ram
Thanks Alin! From: aserd...@ovn.org Sent: Thursday, March 1, 2018 3:09:19 PM To: aserd...@ovn.org; Anand Kumar; Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile

Re: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

2018-03-01 Thread aserdean
Applied on master with the following incremental: 60c66 < + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win10$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) --- > +MSBuild.exe //nologo

Re: [ovs-dev] [PATCH v2] datapath-windows: On Debug builds, dump NBL info based on OVS_DBG_DEFAULT macro

2018-03-01 Thread aserdean
Thanks for the patch Anand. I applied it on master. Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Wednesday, February 28, 2018 7:00 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2]

Re: [ovs-dev] Hardware acceleration enablement in OVS-DPDK

2018-03-01 Thread Rashid Khan
Added Don, Kevin and Bill from RH side to this thread. Sugesh, kindly please keep them in the loop. Don is our Engineering partner manager (aka coordinator-in-chief) for Intel. Kevin is manager of EPM team And I have asked Bill T from my team to be the front person for this. Looking forward to

[ovs-dev] [PATCH 0/2] ofproto-dpif-xlate: translate action_set in clone action

2018-03-01 Thread Eric Garver
write_actions() defined inside of a clone() were being ignored. Notably this affected patch ports between bridges. More details in patch 1. travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 Note: Travis failures (1201 and 1227) seem unrelated to this series. They also pass on my local

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

2018-03-01 Thread Guru Shetty
On 28 February 2018 at 19:37, Han Zhou wrote: > This patch enables using port group names in ACL match conditions. > Users can create a port group in northbound DB Port_Group table, > and then use the name of the port group in ACL match conditions > for "inport" or "outport".

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

2018-03-01 Thread Han Zhou
On Thu, Mar 1, 2018 at 12:13 PM, Guru Shetty wrote: > > > > On 28 February 2018 at 19:37, Han Zhou wrote: >> >> This patch enables using port group names in ACL match conditions. >> Users can create a port group in northbound DB Port_Group table, >> and then use

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

2018-03-01 Thread Guru Shetty
On 1 March 2018 at 12:21, Han Zhou wrote: > > > On Thu, Mar 1, 2018 at 12:13 PM, Guru Shetty wrote: > > > > > > > > On 28 February 2018 at 19:37, Han Zhou wrote: > >> > >> This patch enables using port group names in ACL match conditions. >

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

2018-03-01 Thread Mark Michelson
Hi Han, Current criticisms notwithstanding, I decided to test your patch with a scenario that I thought it would help with. The base scenario is that I create an address set with 1000 addresses in it. I then create logical switch ports and create a new ACL for each port: ovn-nbctl acl-add

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

2018-03-01 Thread Han Zhou
On Thu, Mar 1, 2018 at 12:26 PM, Guru Shetty wrote: > > > > On 1 March 2018 at 12:21, Han Zhou wrote: >> >> >> >> On Thu, Mar 1, 2018 at 12:13 PM, Guru Shetty wrote: >> > >> > >> > >> > On 28 February 2018 at 19:37, Han Zhou

[ovs-dev] your photos

2018-03-01 Thread Jenson
We have got a team of professional to do image editing service and it will help you submitted your project timely. We have 30 image editors and on daily basis 2000 images can be processed, if you want to know more about us Please reply back. If you want to check our quality of work please send

Re: [ovs-dev] [PATCH v2] python: Fix decoding error when the received data is larger than 4096.

2018-03-01 Thread Ben Pfaff
Thanks! I'll review it. On Thu, Mar 01, 2018 at 02:31:37PM +0800, Guoshuai Li wrote: > > Thanks Ben, this is really a good interface, it makes the code change is > simple. > > A new patch: > https://mail.openvswitch.org/pipermail/ovs-dev/2018-March/344845.html > > >It looks like we should be