Re: [ovs-dev] Ubuntu supported IPSEC daemon?

2018-06-11 Thread James Page
Hi Ben (I'm struggling with sending from my @ubuntu.com address at the moment so this will probably bounce on the ML). On Fri, 8 Jun 2018 at 16:15 Ben Pfaff wrote: > Hi James. I have an intern for the summer, Qiuyu, who is working to add > IPSEC support to OVN, so that tunnels between

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-06-11 Thread Stokes, Ian
> I'm very sorry for double posting. > I believe this patch would represent a major feature in term of OVS's > usability. > Has anyone got any time for reviewing it? > I'm planning to look at it this week. Thanks Ian > Thanks, > Federico > > On 6 June 2018 at 17:37, Jan Scheurich wrote: > >

[ovs-dev] Does ovs support P4runtime API?

2018-06-11 Thread Vikas Kumar
Hello everyone, I am new to ovs and I have setup PISCES based setup for ovs using this github repository (https://github.com/P4-vSwitch). Does OVS support P4Runtime API to talk to controller apart from openflow? Thanks -- *Vikas Kumar | ** Hospitality & PR Coordinator*

[ovs-dev] eBPF and OVS

2018-06-11 Thread Stokes, Ian
Hi all, The recent DPDK 18.05 release provides BPF functionality for DPDK devices. The BPF Library provides the ability to load and execute Enhanced Berkeley Packet Filters (eBPF) within user-space DPDK applications. It also introduces a basic framework to load/unload BPF-based filters on Eth

[ovs-dev] [PATCH] tests: Fix test that tests if the system doesn't support IPv6

2018-06-11 Thread Timothy Redaelli
Currently if IPv6 is globally disabled (net.ipv6.conf.all.disable_ipv6=1) or if IPv6 is disabled on loopback interface (net.ipv6.conf.lo.disable_ipv6=1) the check doesn't work since no interface have ::1 and EADDRNOTAVAIL is returned. This causes a Python exception to be printed, like this:

[ovs-dev] Fwd: OVS extension - Please Give your views !

2018-06-11 Thread rakesh kumar
Hello Team Please give your thoughts for the below query.!! Regards Rakesh Kumar -- Forwarded message -- From: rakesh kumar Date: Fri, Jun 8, 2018 at 2:59 PM Subject: OVS extension - Please Give your views ! To: ovs-dev@openvswitch.org Hi Team, I would like to know whether ovs

Re: [ovs-dev] [PATCH] datapath-windows: Add support for handling DEI bit of VLAN header

2018-06-11 Thread Alin Serdean
> > On 16 May 2018, at 02:38, Anand Kumar > wrote: > > > > The Drop eligible indicator(DEI) is 1 bit wide and it is part of Tag > > control information (TCI) in VLAN header, which indicates that the > > frame can be dropped during congestion. > > > > Signed-off-by: Anand Kumar > > --- > >

[ovs-dev] OpenvSwitch and IPsec tunnels.

2018-06-11 Thread Alvaro Jimenez
Hi everyone, I'm trying to figure put how to deploy 3 IPsec tunnels between 2 OpenvSwitches. Each switch is in a different machine, both connected physically. I want to deploy 3 IPsec tunnels between both switches and be able to send traffic though all of them. Anayone knows how to do this? Im

[ovs-dev] [PATCH v8 00/13] Support multi-segment mbufs

2018-06-11 Thread Tiago Lam
Overview This patchset introduces support for multi-segment mbufs to OvS-DPDK. Multi-segment mbufs are typically used when the size of an mbuf is insufficient to contain the entirety of a packet's data. Instead, the data is split across numerous mbufs, each carrying a portion, or

[ovs-dev] [PATCH v8 01/13] netdev-dpdk: fix mbuf sizing

2018-06-11 Thread Tiago Lam
From: Mark Kavanagh There are numerous factors that must be considered when calculating the size of an mbuf: - the data portion of the mbuf must be sized in accordance With Rx buffer alignment (typically 1024B). So, for example, in order to successfully receive and capture a 1500B packet,

[ovs-dev] [PATCH v8 02/13] dp-packet: Init specific mbuf fields.

2018-06-11 Thread Tiago Lam
From: Mark Kavanagh dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's possible the the resultant mbuf portion of the dp_packet contains random data. For some mbuf fields, specifically those related to multi-segment mbufs and/or offload features, random values may cause

[ovs-dev] [PATCH v8 03/13] dp-packet: Fix allocated size on DPDK init.

2018-06-11 Thread Tiago Lam
When enabled with DPDK OvS deals with two types of packets, the ones coming from the mempool and the ones locally created by OvS - which are copied to mempool mbufs before output. In the latter, the space is allocated from the system, while in the former the mbufs are allocated from a mempool,

[ovs-dev] [PATCH v8 05/13] dp-packet: Fix data_len handling multi-seg mbufs.

2018-06-11 Thread Tiago Lam
When a dp_packet is from a DPDK source, and it contains multi-segment mbufs, the data_len is not equal to the packet size, pkt_len. Instead, the data_len of each mbuf in the chain should be considered while distributing the new (provided) size. To account for the above dp_packet_set_size() has

[ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-11 Thread Tiago Lam
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free operations by non-pmd threads on a given mempool. free_dpdk_buf() has been modified to make use of the introduced mutex. Signed-off-by: Tiago Lam --- lib/netdev-dpdk.c | 21 - 1 file

[ovs-dev] [PATCH v8 06/13] dp-packet: Handle multi-seg mbufs in helper funcs.

2018-06-11 Thread Tiago Lam
Most helper functions in dp-packet assume that the data held by a dp_packet is contiguous, and perform operations such as pointer arithmetic under that assumption. However, with the introduction of multi-segment mbufs, where data is non-contiguous, such assumptions are no longer possible. Some

[ovs-dev] [PATCH v8 07/13] dp-packet: Handle multi-seg mbufs in put*() funcs.

2018-06-11 Thread Tiago Lam
The dp_packet_put*() function - dp_packet_put_uninit(), dp_packet_put() and dp_packet_put_zeros() - are, in their current implementation, operating on the data buffer of a dp_packet as if it were contiguous, which in the case of multi-segment mbufs means they operate on the first mbuf in the

[ovs-dev] [PATCH v8 07/13] dp-packet: Handle multi-seg mbufs in put_uninit().

2018-06-11 Thread Tiago Lam
The dp_packet_put_uninit() function is, in its current implementation, operating on the data buffer of a dp_packet as if it were contiguous, which in the case of multi-segment mbufs means they operate on the first mbuf in the chain. However, when making use of multi-segment mbufs, it is the data

[ovs-dev] [PATCH v8 08/13] dp-packet: Handle multi-seg mubfs in shift() func.

2018-06-11 Thread Tiago Lam
In its current implementation dp_packet_shift() is also unaware of multi-seg mbufs (that holds data in memory non-contiguously) and assumes that data exists contiguously in memory, memmove'ing data to perform the shift. To add support for multi-seg mbuds a new set of functions was introduced,

[ovs-dev] [PATCH v8 09/13] dp-packet: Handle multi-seg mbufs in resize__().

2018-06-11 Thread Tiago Lam
When enabled with DPDK OvS relies on mbufs allocated by mempools to receive and output data on DPDK ports. Until now, each OvS dp_packet has had only one mbuf associated, which is allocated with the maximum possible size, taking the MTU into account. This approach, however, doesn't allow us to

[ovs-dev] [PATCH v8 10/13] dp-packet: copy data from multi-seg. DPDK mbuf

2018-06-11 Thread Tiago Lam
From: Michael Qiu When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Also, lots of DPDK mbuf's info is missed during a copy, like packet type, ol_flags, etc. That information is very important for DPDK to do

[ovs-dev] [PATCH v8 11/13] netdev-dpdk: copy large packet to multi-seg. mbufs

2018-06-11 Thread Tiago Lam
From: Mark Kavanagh Currently, packets are only copied to a single segment in the function dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames, particularly when multi-segment mbufs are involved. This patch calculates the number of segments needed by a packet and copies the

[ovs-dev] [PATCH v8 12/13] netdev-dpdk: support multi-segment jumbo frames

2018-06-11 Thread Tiago Lam
From: Mark Kavanagh Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each user-defined MTU, 'requested_mtu', a

Re: [ovs-dev] [PATCH v8 07/13] dp-packet: Handle multi-seg mbufs in put*() funcs.

2018-06-11 Thread Lam, Tiago
Please dismiss this one as it was sent by mistake. The other 07/13 patch ("dp-packet: Handle multi-seg mbufs in put_uninit().") is the correct one for the series. On 11/06/2018 17:21, Tiago Lam wrote: > The dp_packet_put*() function - dp_packet_put_uninit(), dp_packet_put() > and

Re: [ovs-dev] Does ovs support P4runtime API?

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 02:57:26PM +0530, Vikas Kumar wrote: > I am new to ovs and I have setup PISCES based setup for ovs using this > github repository (https://github.com/P4-vSwitch). Does OVS support > P4Runtime API to talk to controller apart from openflow? No.

Re: [ovs-dev] Ubuntu supported IPSEC daemon?

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 09:09:21AM +0100, James Page wrote: > Hi Ben > > (I'm struggling with sending from my @ubuntu.com address at the moment so > this will probably bounce on the ML). > > On Fri, 8 Jun 2018 at 16:15 Ben Pfaff wrote: > > > Hi James. I have an intern for the summer, Qiuyu,

[ovs-dev] [RFC PATCH v2 1/1] dpdk: Support both shared and per port mempools.

2018-06-11 Thread Ian Stokes
This commit re-introduces the concept of shared mempools as the default memory model for DPDK devices. Per port mempools are still available but must be enabled explicitly by a user. OVS previously used a shared mempool model for ports with the same MTU and socket configuration. This was replaced

Re: [ovs-dev] [PATCH 2/5] ovn-controller: Pass around pointers to individual tables.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 02:59:01PM -0700, Han Zhou wrote: > On Mon, Jun 11, 2018 at 2:01 PM, Ben Pfaff wrote: > > > > On Mon, Jun 11, 2018 at 11:23:58AM -0700, Han Zhou wrote: > > > On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote: > > > > > > > > We're working to make ovn-controller compute more

Re: [ovs-dev] [PATCH 1/2] ofp-bundle: Minor style fixes for header.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 03:14:09PM -0700, Justin Pettit wrote: > > > On May 17, 2018, at 8:22 AM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 11:19:08AM -0700, aginwala wrote: > Can you also apply > https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10cba1a9a3d99 > to branch-2.9 too. Sure, done. > Wanted to know if its not yet done on purpose to avoid implications if any > or you have any

Re: [ovs-dev] [patch v6 04/10] Userspace datapath: Add fragmentation handling.

2018-06-11 Thread Darrell Ball
Thanks for the detailed review Justin. I found a couple other issues, like ‘<=’ instead of ‘<’ for min frag If I missed responding to any of your comments, pls let me know. I’ll send out responses to the other patches; just in the middle of some other tasks at the moment. On 6/5/18, 11:38 PM,

[ovs-dev] [PATCH v2 2/5] chassis-index: Use OVSDB index mechanism.

2018-06-11 Thread Ben Pfaff
It seems like a good idea to use the built-in indexing instead of doing it by hand. Signed-off-by: Ben Pfaff --- ovn/controller/bfd.c| 23 +++--- ovn/controller/bfd.h| 6 ++-- ovn/controller/binding.c| 13 ovn/controller/binding.h| 3 +-

[ovs-dev] Fases, grados y tipos de acoso

2018-06-11 Thread Cómo Prevenir el Acoso Laboral
Introducción: Existen diferentes enfoques para identificar el acoso laboral, el cual no sólo es el que se presenta la esperable relación “Jefatura-subalterno”, sino que también puede ser a la inversa y entre pares. Antimobbing: Implicaciones Legales Mayo 27 - webinar Interactivo Temas a

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

2018-06-11 Thread Yi-Hung Wei
On Fri, May 18, 2018 at 1:41 AM, Lucas Alvares Gomes wrote: >> But as mentioned in ovs commit 6c0bf091 ("datapath: use core MTU range >> checking in core net infra"), it might be the case that my commit [0] >> does not set max_mtu correctly. How about the fix in the following? >> From what I

Re: [ovs-dev] [PATCH v2 2/5] chassis-index: Use OVSDB index mechanism.

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > It seems like a good idea to use the built-in indexing instead of doing it > by hand. > > Signed-off-by: Ben Pfaff > --- > ovn/controller/bfd.c| 23 +++--- > ovn/controller/bfd.h| 6 ++-- >

Re: [ovs-dev] [PATCH v2 5/5] ovn-controller: Drop controller_ctx structure entirely.

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > The remaining controller_ctx members were ovsdb_idl_txn pointers that could > be passed to functions directly, so this commit makes that change and > removes the structure. > > Signed-off-by: Ben Pfaff > --- > ovn/controller/bfd.h

[ovs-dev] [PATCH v2 0/5] Work toward better dependencies in ovn-controller.

2018-06-11 Thread Ben Pfaff
To make more efficient use of the CPU, ovn-controller needs to incrementally compute its output. To do that in a maintainable way, it needs internally to be able to pass around data piecemeal. This series is one step in that direction. v1->v2: - Applied and then dropped the first two patches.

[ovs-dev] [PATCH v2 4/5] ovn-controller: Drop ovs_idl, ovnsb_idl from controller_ctx.

2018-06-11 Thread Ben Pfaff
These were essentially unused except within ovn-controller.c itself. Signed-off-by: Ben Pfaff --- ovn/controller/ovn-controller.c | 68 +++-- ovn/controller/ovn-controller.h | 3 -- 2 files changed, 32 insertions(+), 39 deletions(-) diff --git

[ovs-dev] [PATCH v2 5/5] ovn-controller: Drop controller_ctx structure entirely.

2018-06-11 Thread Ben Pfaff
The remaining controller_ctx members were ovsdb_idl_txn pointers that could be passed to functions directly, so this commit makes that change and removes the structure. Signed-off-by: Ben Pfaff --- ovn/controller/bfd.h| 1 - ovn/controller/binding.c| 33

Re: [ovs-dev] [PATCH v2 4/5] ovn-controller: Drop ovs_idl, ovnsb_idl from controller_ctx.

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > These were essentially unused except within ovn-controller.c itself. > > Signed-off-by: Ben Pfaff > --- > ovn/controller/ovn-controller.c | 68 +++-- > ovn/controller/ovn-controller.h | 3 -- > 2 files

Re: [ovs-dev] [PATCH] vxlan: Fix for the packet loop issue in vxlan

2018-06-11 Thread Neelakantam Gaddam
Any update on this patch ? On Wed, 23 May 2018 at 10:46 AM, Neelakantam Gaddam wrote: > This patch fixes the kernel soft lockup issue with vxlan configuration > where the tunneled packet is sent on the same bridge where vxlan port is > attched to. It detects the loop in vxlan xmit functionb and

[ovs-dev] [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.

2018-06-11 Thread Ben Pfaff
The design of the compound index feature in the C OVSDB IDL was unusual. Indexes were generally referenced only by name rather than by pointer, and could be obtained only from the top-level ovsdb_idl object. To iterate or otherwise search an index required explicitly creating a special

Re: [ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread aginwala
Thanks. :) On Mon, Jun 11, 2018 at 3:40 PM, Ben Pfaff wrote: > On Mon, Jun 11, 2018 at 11:19:08AM -0700, aginwala wrote: > > Can you also apply > > https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10c > ba1a9a3d99 > > to branch-2.9 too. > > Sure, done. > > > Wanted to know

[ovs-dev] [PATCH v2 3/5] ovn-controller: Use chassis_lookup_by_name() instead of get_chassis().

2018-06-11 Thread Ben Pfaff
This was duplicate functionality. Signed-off-by: Ben Pfaff --- ovn/controller/chassis.c| 5 +++-- ovn/controller/chassis.h| 6 -- ovn/controller/ovn-controller.c | 24 ovn/controller/ovn-controller.h | 3 --- 4 files changed, 11 insertions(+), 27

[ovs-dev] Issue with OVS 2.9.0, DPDK 18.02 and vhost-user

2018-06-11 Thread Ravi Kerur
Hi, I have used first link to install, compile and run OVS 2.9.0 and DPDK 18.02, second link to configure vhost-client ports. However, facing several issues when configured as per the documentation. Inputs appreciated. http://docs.openvswitch.org/en/latest/intro/install/dpdk/

Re: [ovs-dev] [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > The design of the compound index feature in the C OVSDB IDL was unusual. > Indexes were generally referenced only by name rather than by pointer, and > could be obtained only from the top-level ovsdb_idl object. To iterate or > otherwise

Re: [ovs-dev] [PATCH v2 3/5] ovn-controller: Use chassis_lookup_by_name() instead of get_chassis().

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote: > > This was duplicate functionality. > > Signed-off-by: Ben Pfaff > --- > ovn/controller/chassis.c| 5 +++-- > ovn/controller/chassis.h| 6 -- > ovn/controller/ovn-controller.c | 24 >

Re: [ovs-dev] [PATCH 13/13] Makefile: Add build-time check for files with initial tabs.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 02:49:28PM -0700, Justin Pettit wrote: > > > On Jun 4, 2018, at 2:27 PM, Ben Pfaff wrote: > > > > This should make it harder to reintroduce inappropriate indentation. > > > > Signed-off-by: Ben Pfaff > > Nice addition. > > Acked-by: Justin Pettit Thanks, I applied

Re: [ovs-dev] [PATCH 12/13] treewide: Convert leading tabs to spaces.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 02:47:41PM -0700, Justin Pettit wrote: > > > > On Jun 4, 2018, at 2:27 PM, Ben Pfaff wrote: > > > > It's always been OVS coding style to use spaces rather than tabs for > > indentation, but some tabs have snuck in over time. This commit converts > > them to spaces. > >

[ovs-dev] [PATCH 2/3] datapath: Fix ip6_gre, ip6_tunnel, and ip_gre backport

2018-06-11 Thread Yi-Hung Wei
Recently added ERSAPN feature introduced changes in ip6_gre, ip6_tunnel, and ip_gre which will break build on RHEL 7.5 kernel because of ndo_change_mtu(). This patch fixes the issue in RHEL 7.5 kernel. Fixes: 8e53509c ("gre: introduce native tunnel support for ERSPAN") Fixes: c387d817 ("compat:

[ovs-dev] [PATCH 3/3] datapath: compat: Fix RHEL 7.5 build warning from ip_tunnel_get_stats64()

2018-06-11 Thread Yi-Hung Wei
This patch fixes warning as the following in RHEL 7.5 kernel. CC [M] /root/git/ovs/datapath/linux/geneve.o /root/git/ovs/datapath/linux/geneve.c:1273:2: warning: initialization from incompatible pointer type [enabled by default] .ndo_get_stats64 = ip_tunnel_get_stats64, ^

[ovs-dev] [PATCH 1/3] datapath: Fix max MTU size on RHEL 7.5 kernel

2018-06-11 Thread Yi-Hung Wei
Without the patch, in RHEL 7.5, the maximum configurable MTU of vport internal device is 1500, which shall be 65535. This patch fixes this issue. Fixes: 39ca338374ab ("datapath: compat: Fix build on RHEL 7.5") Reported-by: Lucas Alvares Gomes Signed-off-by: Yi-Hung Wei ---

[ovs-dev] [patch v1] tests: Enable Valgrind for userspace system tests.

2018-06-11 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/automake.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/automake.mk b/tests/automake.mk index c420b29..8224e5a 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -233,6 +233,13 @@ check-kernel-valgrind: all $(valgrind_wrappers)

Re: [ovs-dev] [RFC PATCH v3 1/8] netdev-dpdk: simplify mbuf sizing

2018-06-11 Thread santosh
On Wednesday 22 November 2017 06:54 PM, Kavanagh, Mark B wrote: > + Santosh > >> From: ovs-dev-boun...@openvswitch.org >> [mailto:ovs-dev-boun...@openvswitch.org] >> On Behalf Of Mark Kavanagh >> Sent: Tuesday, November 21, 2017 6:29 PM >> To: d...@openvswitch.org; qiud...@chinac.com >>

Re: [ovs-dev] [PATCH v1 1/2] Fix packet drops on LACP bond after link up

2018-06-11 Thread Nitin Katiyar
Hi, Changes look good to me. Regards, Nitin -Original Message- From: Manohar Krishnappa Chidambaraswamy Sent: Tuesday, June 05, 2018 4:07 PM To: d...@openvswitch.org Cc: Nitin Katiyar Subject: Re: [ovs-dev] [PATCH v1 1/2] Fix packet drops on LACP bond after link up Hi, Could someone

[ovs-dev] Important Notification

2018-06-11 Thread Information Update
Dear Recipent , This email address has won Three Million Pounds on the o2 mobile sweepstakes.Please Contact Payment Cordinator Mat on email : mrw...@o2loto.co.uk for explanation and payment processing . Yours Faithfully Debbie Spence Cordinator O2 Mobile Promotional Sweepstakes.

Re: [ovs-dev] [PATCH 1/5] ovn-controller: Style fixes.

2018-06-11 Thread Han Zhou
On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote: > diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c > index d09fd107298b..db96197828aa 100644 > --- a/ovn/controller/lflow.c > +++ b/ovn/controller/lflow.c > @@ -65,8 +65,6 @@ static void consider_logical_flow(struct controller_ctx *ctx,

Re: [ovs-dev] [PATCH 1/5] ovn-controller: Style fixes.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 10:48:24AM -0700, Han Zhou wrote: > On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote: > > diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c > > index d09fd107298b..db96197828aa 100644 > > --- a/ovn/controller/lflow.c > > +++ b/ovn/controller/lflow.c > > @@ -65,8

[ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread aginwala
Hi Ben: Can you also apply https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10cba1a9a3d99 to branch-2.9 too. Wanted to know if its not yet done on purpose to avoid implications if any or you have any other thing in mind. 樂 Regards, Aliasgar

Re: [ovs-dev] [PATCH 2/5] ovn-controller: Pass around pointers to individual tables.

2018-06-11 Thread Han Zhou
On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote: > > We're working to make ovn-controller compute more incrementally, to reduce > CPU usage. To make it easier to keep track of dependencies, it makes sense > to pass around pointers to fine-grained resources instead of an entire > database at a

Re: [ovs-dev] [PATCH 3/5] ovsdb-idl: Redesign use of indexes.

2018-06-11 Thread Mark Michelson
So far all I've reviewed is the documentation. See my comments below. On 06/08/2018 05:59 PM, Ben Pfaff wrote: The design of the compound index feature in the C OVSDB IDL was unusual. Indexes were generally referenced only by name rather than by pointer, and could be obtained only from the

Re: [ovs-dev] [PATCH 2/5] ovn-controller: Pass around pointers to individual tables.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 11:23:58AM -0700, Han Zhou wrote: > On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote: > > > > We're working to make ovn-controller compute more incrementally, to reduce > > CPU usage. To make it easier to keep track of dependencies, it makes > sense > > to pass around

Re: [ovs-dev] [PATCH 12/13] treewide: Convert leading tabs to spaces.

2018-06-11 Thread Justin Pettit
> On Jun 4, 2018, at 2:27 PM, Ben Pfaff wrote: > > It's always been OVS coding style to use spaces rather than tabs for > indentation, but some tabs have snuck in over time. This commit converts > them to spaces. > > Signed-off-by: Ben Pfaff > --- > ... > vswitchd/vswitch.xml

Re: [ovs-dev] [PATCH 13/13] Makefile: Add build-time check for files with initial tabs.

2018-06-11 Thread Justin Pettit
> On Jun 4, 2018, at 2:27 PM, Ben Pfaff wrote: > > This should make it harder to reintroduce inappropriate indentation. > > Signed-off-by: Ben Pfaff Nice addition. Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 2/5] ovn-controller: Pass around pointers to individual tables.

2018-06-11 Thread Han Zhou
On Mon, Jun 11, 2018 at 2:01 PM, Ben Pfaff wrote: > > On Mon, Jun 11, 2018 at 11:23:58AM -0700, Han Zhou wrote: > > On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote: > > > > > > We're working to make ovn-controller compute more incrementally, to reduce > > > CPU usage. To make it easier to keep

Re: [ovs-dev] [PATCH] ovn-sandbox: Fix link.

2018-06-11 Thread Justin Pettit
> On Jun 3, 2018, at 1:40 PM, Ben Pfaff wrote: > > I couldn't figure out a way to fix this without making it inline. Weird. > > Reported-by: Qiuyu Xiao > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list

Re: [ovs-dev] [PATCH 3/5] ovsdb-idl: Redesign use of indexes.

2018-06-11 Thread Ben Pfaff
On Mon, Jun 11, 2018 at 04:16:06PM -0400, Mark Michelson wrote: > So far all I've reviewed is the documentation. See my comments below. > > On 06/08/2018 05:59 PM, Ben Pfaff wrote: > >The design of the compound index feature in the C OVSDB IDL was unusual. > >Indexes were generally referenced

Re: [ovs-dev] [PATCH 1/2] ofp-bundle: Minor style fixes for header.

2018-06-11 Thread Justin Pettit
> On May 17, 2018, at 8:22 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev