I have a confidential deal for you, please contact me for more details via this
email immediately.
God Bless,
Ms.Yael Ronen
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Aaron/Ben/All,
Kindly review the patch and let me know your views.
On Thu, Jul 12, 2018 at 11:34 PM, Aravind Prasad S
wrote:
> Currently, rule_insert() API does not have return value. There are some
> possible
> scenarios where rule insertions can fail at run-time even though the static
>
On 7/13/2018 3:44 PM, Greg Rose wrote:
Add netstat when mentioning testing. Many check-kmod failures result
when it is not present.
Signed-off-by: Greg Rose
I fat fingered the title - should be "Documentation: Add netstat to testing
I can send V2 or it can be fixed on push, either way
Ben Pfaff writes:
> When I run this test with DPDK enabled, it fails because it ends up using
> a different recirculation ID when DPDK is not enabled. I guess that's a
> little weird but the recirculation IDs are not supposed to be significant,
> so this change makes the test ignore it.
>
>
On Thu, 12 Jul 2018 17:10:14 -0400
Mark Michelson wrote:
> This is tough. The problem with a test like this is that you can't
> really tell that the sync is working as intended. It's possible that the
> ovn-nbctl is not actually waiting, but by coincidence, the database has
> its values
On Thu, 12 Jul 2018 17:09:45 -0400
Mark Michelson wrote:
> On 07/12/2018 09:40 AM, Jakub Sitnicki wrote:
> > If IDL was created with monitoring and alerts turned on by default for
> > all columns, then there is no harm in allowing the API users to ask
> > again for monitoring and alerts to be
On Fri, Jul 13, 2018 at 5:04 AM Ben Pfaff wrote:
> This series still needs reviews.
>
> On Fri, Jun 15, 2018 at 03:11:09PM -0700, Ben Pfaff wrote:
> > When ovsdb-server closes a remote connection, it logs a message about it
> > that includes the reason. Until now this has included sessions that
On Thu, 12 Jul 2018 17:10:04 -0400
Mark Michelson wrote:
> On 07/12/2018 09:40 AM, Jakub Sitnicki wrote:
> > Make ovn-nbctl act as a unixctl server if we were asked to detach. This
> > turns ovn-nbctl into a long-lived process that acts a proxy for
> > interacting with NB DB. The main difference
On Sat, Jun 16, 2018 at 3:42 AM Ben Pfaff wrote:
> A user reported a failure of test 2364 "vlog - RFC5424 facility - Python2"
> with an exit code that says that the test-unixctl process died from an
> uncaught exception. Unfortunately the exception didn't show up in the log.
> This commit
On Thu, Jul 12, 2018 at 07:48:42PM +0100, Ian Stokes wrote:
> A common issue is users pairing the incorrect version of OVS to DPDK
> when working outside of the build tree.
>
> To avoid this this commit updates the OVS DPDK documentation to explicitly
> flag that users should consult the OVS to
On 7/11/2018 7:23 PM, Tiago Lam wrote:
Overview
This patchset introduces support for multi-segment mbufs to OvS-DPDK.
Multi-segment mbufs are typically used when the size of an mbuf is
insufficient to contain the entirety of a packet's data. Instead, the
data is split across numerous
Hi Ian, Ilya,
If there are no more comments, can I request to please include the fix
in this week's pull request?
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff writes:
> These don't trigger any new actual warnings in my own build.
>
> GCC 8.x adds other new warning options that are enabled by -Wall or
> -Wextra. This commit doesn't explicitly enable those because OVS already
> enables -Wall and -Wextra.
>
> Signed-off-by: Ben Pfaff
> ---
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff
Let the caller handle the errors instead of reporting it and
terminating. Prepare for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
Instead of terminating the process, return the error to the caller.
This will allow us to reuse the prerequisites runner in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git
Thanks for the patch.
A few queries inline.
On Wed, Jul 11, 2018 at 11:23 AM, Tiago Lam wrote:
> When enabled with DPDK OvS relies on mbufs allocated by mempools to
> receive and output data on DPDK ports. Until now, each OvS dp_packet has
> had only one mbuf associated, which is allocated
Provide a handler for options that change how the main loop behaves.
This will allow code reuse for option parsing in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 136 --
1 file changed, 84 insertions(+), 52 deletions(-)
This will allow us to direct oneline-formatted output to other sinks
than stdout if needed. Preparatory work for daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 53 ++-
1 file changed, 34 insertions(+), 19 deletions(-)
diff
Extend the main loop and the command runner so that the caller can
specify a timeout for poll_block(). This will allow us to break out of
the main loop when waiting on IDL, like in the blocked '--wait=sb/hv
sync' case.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 27
On 7/13/2018 2:54 PM, Vishal Deep Ajmera wrote:
Hi Ian, Ilya,
If there are no more comments, can I request to please include the fix
in this week's pull request?
Hi Vishal, I'll leave Ilya to respond to the changes he requested.
This weeks pull request includes the new feature 'SMC cache
Hi Ben,
The following changes since commit
89dd5819cf181a741271d297bc99fea4760f7ba5:
rhel: support kmod-openvswitch build against multiple kernels, rhel6
(2018-07-12 17:42:07 -0700)
are available in the git repository at:
https://github.com/istokes/ovs dpdk_merge
for you to fetch
Make ovn-nbctl act as a unixctl server if we were asked to detach. This
turns ovn-nbctl into a long-lived process that acts a proxy for
interacting with NB DB. The main difference to regular mode of ovn-nbctl
is that in the daemon mode, a local copy of database contents has to be
obtained only
Will be reused for parsing options in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index 72c78795c..bac1c001d 100644
---
Will be reused when parsing options in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index
OVN offers a method of IP address management that allows for an IPv4 subnet or
IPv6 prefix to be specified on a logical switch. Then by specifying a
switch port's address as "dynamic" or " dynamic", OVN will
automatically assign addresses to the switch port.
While this works great for initial
Destroy commands in the same routine where they were allocated.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Split out a routine for the main ovn-nbctl loop.
Preparatory work for introducing daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Introduce an output parameter for the flag that signals need to retry
running the command. This leaves the return value for error reporting.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 20 +---
1 file
Destroy IDL resources in the routine where we allocated them.
Preparatory work for reusing the main loop in daemon mode.
Signed-off-by: Jakub Sitnicki
---
ovn/utilities/ovn-nbctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ovn/utilities/ovn-nbctl.c
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#80 FILE:
On 7/10/2018 2:23 PM, Sugesh Chandran wrote:
Configuring flow control at ixgbe netdev-init is throwing error in port
start.
For eg: without this fix, user cannot configure flow control on ixgbe dpdk
port as below,
"
ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Co-authored-by/Signed-off-by corruption
WARNING: Line has trailing whitespace
#194 FILE:
This series extends ovn-nbctl tool with support for the daemon mode, where
ovn-nbctl acts a long-lived process that accepts commands over a UNIX socket.
The daemon can be started the same way as any other OVS/OVN server:
ovn-nbctl --detach --pidfile --log-file
While commands can be issued to
Having a constant in addition to the constant expression for the default
table style allows us to reset 'struct table_style' variables to default
style.
Signed-off-by: Jakub Sitnicki
---
lib/table.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/table.h b/lib/table.h
index
If IDL was created with monitoring and alerts turned on by default for
all columns, then there is no harm in allowing the API users to ask
again for monitoring and alerts to be enabled for any given column.
This allows us to run prerequisites handlers for db-ctl and ovn-nbctl
commands once the
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 73a61a4be..89daf631a 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1382,3 +1382,24 @@ inactivity_probe:
Signed-off-by: Jakub Sitnicki
---
tests/ovn-nbctl.at | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 89daf631a..60b4d0c9c 100644
--- a/tests/ovn-nbctl.at
+++ b/tests/ovn-nbctl.at
@@ -1403,3 +1403,24 @@ AT_CHECK([ovn-nbctl
Add netstat when mentioning testing. Many check-kmod failures result
when it is not present.
Signed-off-by: Greg Rose
---
Documentation/intro/install/general.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/intro/install/general.rst
39 matches
Mail list logo
