[ovs-dev] [PATCH v2 0/4] IPsec support for tunneling

2018-07-18 Thread Qiuyu Xiao
This patch series reintroduce IPsec support for OVS tunneling and enable OVN to use IPsec tunnels. GRE, VXLAN, GENEVE, and STT IPsec tunnels are supported. StrongSwan and LibreSwan IKE daemons are supported. Changes from v1 to v2: 1) Merged the ovs-monitor-ipsec code to a single patch. Added

Re: [ovs-dev] [ovs-dev, v2, 2 of 4] ipsec: reintroduce IPsec support for tunneling

2018-07-18 Thread 0-day Robot
Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? WARNING: Line is 80 characters

[ovs-dev] Gestión de la práctica educativa

2018-07-18 Thread Maestría en educación
--- Este correo electrónico ha sido comprobado en busca de virus por AVG. http://www.avg.com ___

Re: [ovs-dev] [ovs-dev, v2, 4 of 4] OVN: native support for tunnel encryption

2018-07-18 Thread 0-day Robot
Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #65 FILE: ovn/controller/encaps.c:100:

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-07-18 Thread Markos Chandras
Hello Aaron, On 18/07/18 16:24, Aaron Conole wrote: > > I think there's actually a race condition here. Most likely, > ovsdb-server doesn't need to be started before network.service. > > Looking at the bug, I think we can unroll some of the dependencies that > each unit file has and get a

Re: [ovs-dev] [PATCH] Documentation:

2018-07-18 Thread Aaron Conole
Gregory Rose writes: > On 7/18/2018 8:03 AM, Aaron Conole wrote: >> Hi Greg, >> >> Greg Rose writes: >> >>> Add netstat when mentioning testing. Many check-kmod failures result >>> when it is not present. >>> >>> Signed-off-by: Greg Rose >>> --- >> Just wanted to point out that the subject

[ovs-dev] Development environment

2018-07-18 Thread sdnlabs Janakaraj
Hello, Is anyone posting blog about openvswitch development environment ? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Documentation:

2018-07-18 Thread Aaron Conole
Hi Greg, Greg Rose writes: > Add netstat when mentioning testing. Many check-kmod failures result > when it is not present. > > Signed-off-by: Greg Rose > --- Just wanted to point out that the subject looks incomplete. Otherwise: Acked-by: Aaron Conole

Re: [ovs-dev] [PATCH V2] Documentation: Add netstat to testing instructions

2018-07-18 Thread Aaron Conole
Greg Rose writes: > Add netstat when mentioning testing. Many check-kmod failures result > when it is not present. > > Signed-off-by: Greg Rose > > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v5 0/3] Use VLANs for VLAN packets redirected to a gateway chassis

2018-07-18 Thread Anil Venkata
On Wed, Jul 18, 2018 at 6:52 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > > I have been testing the patches, and seeing them work as expected > (L3HA failovers, N/S, E/W, etc...), but I have found a couple of > issues, one of them, "2", I'm not sure it's an issue, but I will >

Re: [ovs-dev] [PATCH] Documentation:

2018-07-18 Thread Gregory Rose
On 7/18/2018 8:03 AM, Aaron Conole wrote: Hi Greg, Greg Rose writes: Add netstat when mentioning testing. Many check-kmod failures result when it is not present. Signed-off-by: Greg Rose --- Just wanted to point out that the subject looks incomplete. Otherwise: Acked-by: Aaron Conole

[ovs-dev] [PATCH] selinux: changes to support newer hugetlbfs restrictions

2018-07-18 Thread Aaron Conole
Newer selinux base policies now split out 'map' actions, as well as adding more explicit checks for hugetlbfs objects. Where previously these weren't required, recent changes have flagged the allocation of hugepages and subsequent clearing. This means that the hugepage storage information for

Re: [ovs-dev] build: Add gitattribute file to build-aux

2018-07-18 Thread Aaron Conole
Hi Alin, 0-day Robot writes: > Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > I suggest folding in something like the following

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-07-18 Thread Aaron Conole
Markos Chandras writes: > When ovsdb-server is starting, it performs some DB steps such as > creating and upgrading the OvS DB. When we are running as > 'non-root' user, the 'runuser' tool is used to manage the privileges. > However, when this happens during systemd boot, we observe the

Re: [ovs-dev] [ovs-discuss] ovsdb-server core dump and ovsdb corruption using raft cluster

2018-07-18 Thread Girish Moodalbail
Hello all, We are able to reproduce this issue on OVS 2.9.2 at will. The OVSDB NB server or OVSDB SB server dumps core while it is trying to compact the database. You can reproduce the issue by using: root@u1804-HVM-domU:/var/crash# ovs-appctl -t /var/run/openvswitch/ovnsb_db.ctl

Re: [ovs-dev] [PATCH] erspan: set bso bit based on mirrored packet's len

2018-07-18 Thread William Tu
On Wed, Jul 18, 2018 at 9:22 AM, Greg Rose wrote: > Upstream commit: > Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not > handled. BSO has 4 possible values: > 00 --> Good frame with no error, or unknown integrity > 11 --> Payload is a Bad Frame with CRC or

Re: [ovs-dev] [PATCH] erspan: set bso bit based on mirrored packet's len

2018-07-18 Thread Gregory Rose
On 7/18/2018 10:34 AM, William Tu wrote: On Wed, Jul 18, 2018 at 9:22 AM, Greg Rose wrote: Upstream commit: Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11

[ovs-dev] [branch-2.7 PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

2018-07-18 Thread Sugesh Chandran
This patch backports the commit from the latest OVS master to OVS-2.7. Configuring flow control at ixgbe netdev-init is throwing error in port start. For eg: without this fix, user cannot configure flow control on ixgbe dpdk port as below, " ovs-vsctl add-port br0 dpdk0 -- set Interface

Re: [ovs-dev] [PATCH v2] ofp-actions: Split ofpacts_check__() into many functions.

2018-07-18 Thread Yifeng Sun
Sorry I made a mistake in the previous review. Operator '||' has higher precedence than operator '?:'. So the patch is correct. Thanks, Yifeng On Tue, Jul 17, 2018 at 1:57 PM, Yifeng Sun wrote: > Hi Ben, > > I found a small issue: > > +{ > +uint32_t mid = a->meter_id; > +return mid ==

[ovs-dev] [PATCH net 2/2] openvswitch: check for null return for nla_nest_start in datapath

2018-07-18 Thread Stephen Hemminger
The call to nla_nest_start when forming packet messages can lead to a NULL return so it's possible for attr to become NULL and we can potentially get a NULL pointer dereference on attr. Fix this by checking for a NULL return. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200537 Fixes:

[ovs-dev] [PATCH net 1/2] openvswitch: check for null return for nla_nest_start

2018-07-18 Thread Stephen Hemminger
The call to nla_nest_start in conntrack can lead to a NULL return so it's possible for attr to become NULL and we can potentially get a NULL pointer dereference on attr. Fix this by checking for a NULL return. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200533 Fixes: 11efd5cb04a1

[ovs-dev] [PATCH net 0/2] openvswitch tests for nla_nest_start

2018-07-18 Thread Stephen Hemminger
Coverity is looking for bugs here, and a couple of new bugzilla reports showed up where nla_nest_start return is not checked for NULL. Stephen Hemminger (2): openvswitch: check for null return for nla_nest_start openvswitch: check for null return for nla_nest_start in datapath

[ovs-dev] [PATCH] erspan: set bso bit based on mirrored packet's len

2018-07-18 Thread Greg Rose
Upstream commit: Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10

[ovs-dev] [PATCH v2 2/4] ipsec: reintroduce IPsec support for tunneling

2018-07-18 Thread Qiuyu Xiao
This patch reintroduces ovs-monitor-ipsec daemon that was previously removed by commit 2b02d770 ("openvswitch: Allow external IPsec tunnel management.") After this patch, there are no IPsec flavored tunnels anymore. IPsec is enabled by setting up the right values in: 1. OVSDB:Interface:options

[ovs-dev] [PATCH v2 4/4] OVN: native support for tunnel encryption

2018-07-18 Thread Qiuyu Xiao
This patch adds IPsec support for OVN tunnel. Basically, OVN offers a binary option to its user for encryption configuration. If the IPsec option is turned on, all tunnels will be encrypted. Otherwise, no tunnel will be encrypted. The changes are summarized as below: 1) Added a ipsec column on

[ovs-dev] [PATCH v2 1/4] datapath: add transport ports in route lookup to enable IPsec policy match.

2018-07-18 Thread Qiuyu Xiao
This patch adds transport ports information for route lookup so that IPsec can select tunnel traffic (geneve, stt, vxlan) to do encryption. The patch was tested for geneve, stt, and vxlan tunnel and the results show that IPsec policy can be set to only match the corresponding tunnel traffic.

[ovs-dev] [PATCH v2 3/4] ovs-pki: generate x.509 v3 certificate

2018-07-18 Thread Qiuyu Xiao
This patch modifies ovs-pki to generate x.509 version 3 certificate. Compared with the x.509 v1 certificate generated by ovs-pki, version 3 certificate adds subjectAltName field and sets its value the same as common name (CN). The main reason for this change is to enable strongSwan IKE daemon to

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-07-18 Thread Flavio Leitner
On Wed, Jul 18, 2018 at 11:24:43AM -0400, Aaron Conole wrote: > Markos Chandras writes: > > > When ovsdb-server is starting, it performs some DB steps such as > > creating and upgrading the OvS DB. When we are running as > > 'non-root' user, the 'runuser' tool is used to manage the privileges. >

Re: [ovs-dev] [PATCH v5 0/3] Use VLANs for VLAN packets redirected to a gateway chassis

2018-07-18 Thread Miguel Angel Ajo Pelayo
I have been testing the patches, and seeing them work as expected (L3HA failovers, N/S, E/W, etc...), but I have found a couple of issues, one of them, "2", I'm not sure it's an issue, but I will describe it too, in case it's not a real issue we can move it to disc...@openvswitch.org then. 1)