Re: [ovs-dev] [patch v2 2/5] conntrack: Add rcu support.

2018-11-28 Thread Darrell Ball
Thanks for looking Aaron Darrell On Wed, Nov 28, 2018 at 1:34 PM Aaron Conole wrote: > Hi Darrell, > > Finally a moment to look at things, yay! Quick inline comments. > > Darrell Ball writes: > > > For performance and code simplification reasons, add rcu support for > > conntrack. The array

[ovs-dev] [PATCH] tests: keep some datapath parsing tests from hanging

2018-11-28 Thread Scott Cheloha
The arguments to sed(1) need to be on the same line in the shell script or it will just sit there awaiting input. Signed-off-by: Scott Cheloha --- This is my first submission so I'm not sure if I'm doing this correctly. tests/odp.at | 12 1 file changed, 4 insertions(+), 8

[ovs-dev] [patch v2 1/5] conntrack: Stop exporting internal datastructures.

2018-11-28 Thread Darrell Ball
Remove the exporting of the main internal conntrack datastructure. These are made static. Also stop passing around a pointer parameter to all the internal datastructures; only one or two is used for a given code path and these can be referenced directly and passed specifically where appropriate.

Re: [ovs-dev] Possible OVN enhancement: implementing OpenShift's "unidling" behavior

2018-11-28 Thread Lorenzo Bianconi
> > > Hi Mark, thanks for writing up the interesting topic. I agree with Guru > > > that holding packets and waiting for control plane change to get ready > > > doesn't seem to work/scale. > > > I am curious about the problem and I want to make sure I understand it > > > correctly. It sounds like

Re: [ovs-dev] conntrack: Stop exporting internal datastructures.

2018-11-28 Thread 0-day Robot
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: depbase=`echo lib/conntrack-tcp.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/sh ./libtool

[ovs-dev] [patch v2 3/5] conntrack: Make 'conn' lock protocol specific.

2018-11-28 Thread Darrell Ball
For performance reasons, make 'conn' lock protocol specific. Signed-off-by: Darrell Ball --- lib/conntrack-private.h | 8 +++ lib/conntrack-tcp.c | 43 + lib/conntrack.c | 56 - 3 files changed,

[ovs-dev] [patch v2 0/5] conntrack: Optimize and refactor.

2018-11-28 Thread Darrell Ball
Patch 1 is not an optimization per se, but aimed at eliminating the exporting of internal conntrack infra. Patch 2 Add RCU support. This is mainly done for performance reasons, but also simplifies the code. Patch 3 Moves the conntrack entry locking to the L4 protocol specific layers. This is

[ovs-dev] [patch v2 2/5] conntrack: Add rcu support.

2018-11-28 Thread Darrell Ball
For performance and code simplification reasons, add rcu support for conntrack. The array of hmaps is replaced by a cmap as part of this conversion. Using a single map also simplifies the handling of NAT and allows the removal of the nat_conn map and friends. Per connection entry locks are

[ovs-dev] [patch v2 4/5] conntrack: Memory savings.

2018-11-28 Thread Darrell Ball
Allocate memory for nat and algs as needed. Signed-off-by: Darrell Ball --- lib/conntrack-private.h | 29 +--- lib/conntrack.c | 189 2 files changed, 127 insertions(+), 91 deletions(-) diff --git a/lib/conntrack-private.h

[ovs-dev] [patch v2 5/5] conntrack: Optimize recirculations.

2018-11-28 Thread Darrell Ball
In most cases, recirculations through conntrack can be much less costly. Signed-off-by: Darrell Ball --- lib/conntrack.c | 50 +++--- lib/packets.h | 4 2 files changed, 51 insertions(+), 3 deletions(-) diff --git a/lib/conntrack.c

[ovs-dev] Hi.

2018-11-28 Thread yfx64746
Can you please contact me to discuss an offer? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] Documentation: Fixing some minor spelling mistakes and consistent usage of certain keywords.

2018-11-28 Thread Ashish Varma
Signed-off-by: Ashish Varma --- v1-v2 Reverted the sentence "Each of these flags are" back to "Each of these flags is". --- Documentation/tutorials/ovs-conntrack.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Documentation/tutorials/ovs-conntrack.rst

Re: [ovs-dev] [patch v2 4/5] conntrack: Memory savings.

2018-11-28 Thread Aaron Conole
Darrell Ball writes: > Allocate memory for nat and algs as needed. > > Signed-off-by: Darrell Ball > --- > lib/conntrack-private.h | 29 +--- > lib/conntrack.c | 189 > > 2 files changed, 127 insertions(+), 91 deletions(-) > > diff

[ovs-dev] [PATCHv3 RFC 1/3] netdev-afxdp: add new netdev type for AF_XDP

2018-11-28 Thread William Tu
The patch creates a new netdev type called "afxdp" and re-uses some of the AF_XDP API implementation from xdpsock_user.c at linux sample code. By default, it binds a device's queue 0 and uses the generic XDP support to send and receive packets. Signed-off-by: William Tu --- acinclude.m4

[ovs-dev] [PATCHv3 RFC 0/3] AF_XDP netdev support for OVS

2018-11-28 Thread William Tu
The patch series introduces AF_XDP support for OVS netdev. AF_XDP is a new address family working together with eBPF. In short, a socket with AF_XDP family can receive and send packets from an eBPF/XDP program attached to the netdev. For more details about AF_XDP, please see linux kernel's

[ovs-dev] [PATCHv3 RFC 3/3] FIXME: work around the failed cases.

2018-11-28 Thread William Tu
There are still two issues causing some test cases failed. This patch provides an work-around. Signed-off-by: William Tu --- lib/dpif-netdev.c| 2 +- tests/system-afxdp-macros.at | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c

[ovs-dev] [PATCH v1] ofp-monitor: Added support for OpenFlow 1.4+ Flow Monitor

2018-11-28 Thread Ashish Varma
OVS supports Nicira version of Flow Monitor feature which allows an OpenFlow controller to keep track of any changes in the flow table. (The changes can done by the controller itself or by any other controller connected to OVS.) This patch adds support for the OpenFlow 1.4+ OFPMP_FLOW_MONITOR

Re: [ovs-dev] [dpdk-stable] [PATCH 17.11] mem: fix memory initialization time

2018-11-28 Thread Yongseok Koh
> On Nov 12, 2018, at 3:18 AM, Alejandro Lucero > wrote: > > When using large amount of hugepage based memory, doing all the > hugepages mapping can take quite significant time. > > The problem is hugepages being initially mmaped to virtual addresses > which will be tried later for the final