On 2/26/2019 9:53 AM, Jiri Pirko wrote:
> Mon, Feb 25, 2019 at 11:00:36PM CET, el...@mellanox.com wrote:
>> The csum calculation is different for IPv4/6. For VLAN packets,
>> tc_skb_protocol returns the VLAN protocol rather than the packet's one
>> (e.g. IPv4/6), so csum is not calculated.
Mon, Feb 25, 2019 at 11:00:36PM CET, el...@mellanox.com wrote:
>The csum calculation is different for IPv4/6. For VLAN packets,
>tc_skb_protocol returns the VLAN protocol rather than the packet's one
>(e.g. IPv4/6), so csum is not calculated. Furthermore, VLAN may not be
>stripped so csum is not
Change-Id: I59603383804b57d80334abaea0a25dd9755d47dc
Signed-off-by: Moshe Levi
---
ovn/utilities/ovn-ctl |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
index f1297a2..9e49d1d 100755
--- a/ovn/utilities/ovn-ctl
+++
Few more fixes + dummy implementation to enable unit testing
of this feature.
Version 7:
* Minor rebase of patch #7 due to new argument 'errorp' in
eth_from_flow() in lib/netdev-dummy.c.
* Added Ack from Flavio to the last patch.
Version 6:
* More specific log
It's a normal case for 'find' function, especially because this
happens for every first packet of flow that was not offloaded yet.
Should not warn about this. Dropped to DBG to avoid log trashing in
case of big number of new flows.
CC: Yuanhan Liu
Fixes: 241bad15d99a ("dpif-netdev: associate
Basic partial HWOL API for dummy interfaces.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
lib/netdev-dummy.c | 106 +++--
1 file changed, 103 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index
Add debug logging for partial HWOL for dummy interfaces for
the future using in tests.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
lib/netdev-dummy.c | 66 +++---
1 file changed, 63 insertions(+), 3 deletions(-)
diff --git
Match packets received on dummy interfaces with offloaded flows and
set up corresponding marks in dp-packet.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
lib/netdev-dummy.c | 41 +
1 file changed, 29 insertions(+), 12 deletions(-)
diff
Dummy interfaces clones dp-packet while 'receive' appctl processing.
In general, we should do this anyway to avoid any possible issues in
the future with real interfaces.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
lib/dp-packet.c | 4
1 file changed, 4 insertions(+)
diff
Hi Ben, Anju.
This patch breaks tunnel_push_pop unit tests on branch-2.9:
tunnel_push_pop
791: tunnel_push_pop - actionFAILED
(tunnel-push-pop.at:115)
792: tunnel_push_pop - packet_outok
793: tunnel_push_pop - underlay bridge match FAILED
Python scripts appeared only since OVS 2.9.
This fixes unit test 'monitor-cond-change with many sessions pending'.
Issue appered while backporting the following patch:
e0f42d4a6548 ("monitor: Fix crash when monitor condition adds new columns.")
Signed-off-by: Ilya Maximets
---
Patch should go
Thanks for getting back to me, I'll look into getting it into the
upstream kernel.
Nathanael
On 22/02/2019 23:50, Ben Pfaff wrote:
On Wed, Dec 12, 2018 at 03:06:43PM +, Nathanael Davison wrote:
Linux kernel commit 6e237d099fac introduced warnings when validating the
length of some types.
Getters should have const arguments.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
lib/dp-packet.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 5b13329da..c6672f6be 100644
--- a/lib/dp-packet.h
+++
1. No reason to have mbuf related APIs in a generic code.
2. Not only RSS/checksums should be invalidated in case of tunnel
decapsulation or sending to 'ring' ports.
In order to fix two above issues, new function
'dp_packet_reset_offload' introduced. In order to clean up/unify
the code and
Additionally, new API call 'dp_packet_set_flow_mark' is needed
for packet clone. Mostly for dummy HWOL implementation.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
lib/dp-packet.h | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git
Bleep bloop. Greetings Moshe Levi, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Remove Gerrit Change-Id's before submitting upstream.
5: Change-Id:
Fix merge conflict introduced when backporting the original commit
253e4dc0683b ("conntrack: fix tcp seq adjustments when mangling
commands.")
Fixes: addbb52274ae ("conntrack: fix tcp seq adjustments when mangling
commands.")
Signed-off-by: David Marchand
---
Vagrantfile | 12
1
Simple test for basic partial HWOL functionality.
Acked-by: Flavio Leitner
Signed-off-by: Ilya Maximets
---
tests/dpif-netdev.at | 74
1 file changed, 74 insertions(+)
diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at
index
Thanks for the report.
For now, I reverted this from branch-2.9. I'd be pleased to have a
fixed patch for branch-2.9, though.
On Tue, Feb 26, 2019 at 03:22:08PM +0300, Ilya Maximets wrote:
> Hi Ben, Anju.
>
> This patch breaks tunnel_push_pop unit tests on branch-2.9:
>
> tunnel_push_pop
>
>
Good day,
Sorry for bardging into your privacy.
I have a business proposal to discuss with you for our mutual benefit.
Do get back to me as soon as you receive this email for more details.
Regards
Seifeldin Abdelkareem
___
dev mailing list
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 ovn-nbctl: Don't parse table-formatting
On Tue, Feb 26, 2019 at 8:06 PM Mark Michelson wrote:
> Table formatting has a local static integer that is intended to insert
> line breaks between tables. This works exactly as intended, as long as
> each call to table_format() is done as a single unit within the run of a
> process.
>
> When
On Tue, Feb 26, 2019 at 8:07 PM Mark Michelson wrote:
> When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
> table formatting options. The problem is that this then removes the table
> formatting options from the array of options passed to the server loop. The
> server loop
Darrell Ball writes:
> This warning could be considered a bit confusing bcoz this patch does not
> modify the file being reported.
Agreed. I need to fix up the auto-detection. It looks like the series
had already been applied. The robot no longer warns when the patch has
already been
Cursos Esenciales- Webinar Interactivo – Jueves 07 de Marzo
Formación de Capacitadores Internos
Es vital para la organización recibir capacitación de entidades externas pero
también contar con capacitadores
internos que cuenten con los conocimientos básicos para fomentar el aprendizaje
del
On 25.02.2019 22:02, Ben Pfaff wrote:
> On Mon, Feb 25, 2019 at 08:43:36PM +0300, Ilya Maximets wrote:
>> 'set_levels_from_string' doesn't check for exceptions that could
>> happen while opening syslog files or connecting to syslog sockets.
>
> Thanks, applied to master.
Thanks.
>
> This could
On Tue, Feb 26, 2019 at 09:13:16AM +0200, Moshe Levi wrote:
> Change-Id: I59603383804b57d80334abaea0a25dd9755d47dc
> Signed-off-by: Moshe Levi
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
Table formatting has a local static integer that is intended to insert
line breaks between tables. This works exactly as intended, as long as
each call to table_format() is done as a single unit within the run of a
process.
When ovn-nbctl is run in daemon mode, it is a long-running process that
When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
table formatting options. The problem is that this then removes the table
formatting options from the array of options passed to the server loop. The
server loop resets the table formatting options to the defaults and then
On 21.02.2019 19:31, Roni Bar Yanai wrote:
>
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Thursday, February 21, 2019 6:20 PM
>> To: Ophir Munk ; ovs-dev@openvswitch.org
>> Cc: Ian Stokes ; Olga Shern ;
>> Kevin Traynor ; Asaf Penso ;
>> Roni Bar Yanai ; Flavio Leitner
>>
This is a backport to 2.10 of a feature already in 2.11. This is
necessary for ovn-kubernetes to function properly when using 2.10. The
original commit message is below.
When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
table formatting options. The problem is that this
Please ignore this patch. There is a problem with it and I'll be sending
a v2 of it.
On 2/26/19 8:51 AM, Mark Michelson wrote:
This is a backport to 2.10 of a feature already in 2.11. This is
necessary for ovn-kubernetes to function properly when using 2.10. The
original commit message is
This is a backport for a fix present in 2.11. ovn-kubernetes encounters
issues with the daemon mode of ovn-nbctl with 2.10.
ovn-nbctl when run in daemon mode has two issues:
1) An extra newline is prepended to table output
2) Table formatting issues are ignored.
This patch series fixes both
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, February 26, 2019 4:38 PM
> To: Roni Bar Yanai ; Ophir Munk
> ; ovs-dev@openvswitch.org
> Cc: Ian Stokes ; Olga Shern ;
> Kevin Traynor ; Asaf Penso ;
> Flavio Leitner
> Subject: Re: [PATCH v2 2/3] netdev-dpdk: Move
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 table: Create method for resetting table
Problem:
During port DOWN->UP of link (slave) in a LACP bond, after receiving the
LACPDU with SYNC set for both actor and partner, the bond-slave remains
"disabled" until OVS main thread runs LACP state machine and eventually
"enables" the bond-slave. With this, we have observed delays in
Problem:
On certain Fortville NICs it has been observed that PHY UP detection can
get delayed (sometimes up to 4-5 secs). When the driver fails to fetch
PHY status as UP even though its actually UP, LACP packets can get
exchanged and LACP slave brought UP. In such a case, the remote end
On Tue, Feb 26, 2019 at 1:13 PM Mark Michelson wrote:
>
> On 2/22/19 4:45 PM, Ben Pfaff wrote:
> > On Fri, Feb 22, 2019 at 04:15:27PM -0500, Mark Michelson wrote:
> >> On 2/22/19 4:01 PM, Ben Pfaff wrote:
> >>> On Mon, Feb 18, 2019 at 09:50:56AM -0500, Mark Michelson wrote:
> Hi everyone,
>
On Tue, Feb 26, 2019 at 11:41 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Select a random IPAM mac_prefix if it has not been provided by the user.
> With this patch the admin can avoid to configure mac_prefix in order to
> avoid L2 address collisions if multiple OVN deployments
On Mon, Feb 18, 2019 at 11:26 AM wrote:
>
> From: Numan Siddique
>
> This patch series adds a generic HA chassis group support in OVN
> deprecating the existing Gateway chassis support. The final patch
> of the series adds the 'external' port support in OVN.
> The 'external' port patch addresses
Bleep bloop. Greetings Nitin Katiyar, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
from ./ofproto/fail-open.h:22,
from ./ofproto/ofproto-dpif.h:50,
On Mon, Feb 18, 2019 at 11:27 AM wrote:
>
> From: Numan Siddique
>
> We can reuse the datapaths and ports built during ovnnb_db_run()
> in ovnsb_db_run(). This way we avoid creating the logical ports hash nodes
> during the ovnsb_db_run().
>
> An upcoming patch will make further use of these
Hi Ben,
Sorry for the format issue. I will resubmit it by "git send-email".
Best Regards,
Wei Yanqin
-Original Message-
From: Ben Pfaff
Sent: Saturday, February 23, 2019 5:03 AM
To: Yanqin Wei (Arm Technology China)
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v1 1/1] hash:
First patch is a bugfix backport. Second one fixes the testsuite
jobs on TravisCI failure due to 50 minutes timeout.
Both patches needs to be applied to branch-2.10 and backported as far
as possible. I tested them on branches from 2.10 down to 2.6.
The second patch disables rsyslog daemon on
'set_levels_from_string' doesn't check for exceptions that could
happen while opening syslog files or connecting to syslog sockets.
For example, if rsyslog stopped on a system:
$ test-unixctl.py -vFACILITY:daemon --detach
Traceback (most recent call last):
File
For some reason logging to syslog on TravisCI become very slow.
For exmaple, following appctl call took around 3 seconds:
14:52:27.095Z|00637| received: OFPST_TABLE request (xid=0x2):
14:52:29.884Z|00638| sent (Success): OFPST_TABLE reply (xid=0x2)
In this situation testsuite spends all the
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 OVN: add the possibility to configure a
On 2/26/19, 4:39 AM, "Ilya Maximets" wrote:
Python scripts appeared only since OVS 2.9.
This fixes unit test 'monitor-cond-change with many sessions pending'.
Issue appered while backporting the following patch:
e0f42d4a6548 ("monitor: Fix crash when monitor condition adds new
oops
thanks David
On Tue, Feb 26, 2019 at 2:13 AM David Marchand
wrote:
> Fix merge conflict introduced when backporting the original commit
> 253e4dc0683b ("conntrack: fix tcp seq adjustments when mangling
> commands.")
>
> Fixes: addbb52274ae ("conntrack: fix tcp seq adjustments when
Select a random IPAM mac_prefix if it has not been provided by the user.
With this patch the admin can avoid to configure mac_prefix in order to
avoid L2 address collisions if multiple OVN deployments share the same
broadcast domain.
Remove MAC_ADDR_PREFIX definitions/occurrences since now
Add the possibility to configure a static IPv4 address and IPv6 prefix
and get MAC address dynamically allocated. This can be done using the
following commands:
$ovn-nbctl ls-add sw0
$ovn-nbctl set Logical-Switch sw0 other_config:subnet=192.168.0.0/24
$ovn-nbctl set Logical-switch sw0
Cursos esenciales - Webinar Interactivo – Martes 12 de Marzo
Finanzas para no Financieros.
El participante podrá interpretar la información financiera de la empresa y
realizar análisis que le permitan una
mejor toma de decisiones.
Objetivos Específicos:
• El participante conocerá los
On 2/26/19, 9:11 AM, "Zhou, Han" wrote:
On 2/26/19, 4:39 AM, "Ilya Maximets" wrote:
Python scripts appeared only since OVS 2.9.
This fixes unit test 'monitor-cond-change with many sessions pending'.
Issue appered while backporting the following
Bleep bloop. Greetings Sairam Venugopal via dev, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author should not be mailing list.
Lines checked: 36, Warnings: 0, Errors:
Bleep bloop. Greetings Sairam Venugopal via dev, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author should not be mailing list.
Lines checked: 43, Warnings: 0, Errors:
Move the EventQueue lock acquisition after the dispatchLock to prevent a
potential deadlock in port creation pipeline. There could be a case where
a port event could try to take up the Dispatch Lock before the Event Queue
lock and the subscription queue event could take up the event queue lock
Bleep bloop. Greetings Sairam Venugopal via dev, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author should not be mailing list.
Lines checked: 37, Warnings: 0, Errors:
Hello all,
I have been trying build OVS using `make check` but I have been getting
errors on a couple of branches.
All of the mentioned branches were built with this script.
./boot.sh
./configure --enable-Werror
make check
On each I got these results:
branch-2.6 Build hung forever. I
On 2/22/19 4:45 PM, Ben Pfaff wrote:
On Fri, Feb 22, 2019 at 04:15:27PM -0500, Mark Michelson wrote:
On 2/22/19 4:01 PM, Ben Pfaff wrote:
On Mon, Feb 18, 2019 at 09:50:56AM -0500, Mark Michelson wrote:
Hi everyone,
I have completed a *rough* POC of an OVN/OVS code split. You can find it at
Move the EventQueue lock acquisition after the dispatchLock to prevent a
potential deadlock in port creation pipeline. There could be a case where
a port event could try to take up the Dispatch Lock before the Event Queue
lock and the subscription queue event could take up the event queue lock
Hold the dispatch lock until port-add operations are completed.
Found by inspection.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Vport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index
61 matches
Mail list logo
