From: Han Zhou
When using unixctl command inject-packet, it always respond with
failure "server not ready", although the command was actually executed
successfully.
Fixes: 0bd4d85c36ef ("ovn-controller: Initial use of incremental engine - quiet
mode.")
Signed-off-by: Han Zhou
---
Hi, all
I was told meter only can be specified once, but actually there is such case
existing, i.e. multiple flows share a total bandwidth, but every flow also
has its own bandwidth limit, by two meters, we can not only get every flow
stats but also get total stats, I think this is very
On Mon, Aug 5, 2019 at 8:52 AM Numan Siddique wrote:
>
>
>
> On Mon, Aug 5, 2019 at 2:11 AM Han Zhou wrote:
>>
>> On Fri, Aug 2, 2019 at 2:23 AM Dumitru Ceara wrote:
>> >
>> > When trying to incrementally process changes even if there are in-flight
>> > messages we were incorrectly setting the
On Mon, Aug 5, 2019 at 2:11 AM Han Zhou wrote:
> On Fri, Aug 2, 2019 at 2:23 AM Dumitru Ceara wrote:
> >
> > When trying to incrementally process changes even if there are in-flight
> > messages we were incorrectly setting the engine_aborted variable to the
> > value returned by engine_run.
On Mon, Aug 5, 2019 at 9:29 AM Han Zhou wrote:
>
> From: Han Zhou
>
> When using unixctl command inject-packet, it always respond with
> failure "server not ready", although the command was actually executed
> successfully.
>
> Fixes: 0bd4d85c36ef ("ovn-controller: Initial use of incremental
On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote:
>
>
>
> On Mon, Jul 29, 2019 at 2:30 AM Dumitru Ceara wrote:
> >
> > Add a restriction on the target protocol addresses to match the
> > configured subnets. All other ARP/ND packets are invalid in this
> > context.
> >
> > One exception is for ARP
From: Numan Siddique
With this patch we have to configure OVN to refer to external OVS source/build
directory instead of the ovs subtree.
The new configuration options added are:
* --with-ovs-source=/path/to/ovs/source/dir
* --with-ovs-build=/path/to/ovs/build/dir
Before configuring OVN,
On Mon, Aug 5, 2019 at 1:06 AM Dumitru Ceara wrote:
>
> On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote:
> >
> >
> >
> > On Mon, Jul 29, 2019 at 2:30 AM Dumitru Ceara wrote:
> > >
> > > Add a restriction on the target protocol addresses to match the
> > > configured subnets. All other ARP/ND
I resent it for backporting to 2.12 as a series followed by a fix from
Dumitru, which has been merged in OVN repo, too.
https://patchwork.ozlabs.org/project/openvswitch/list/?series=123382
Thanks Dumitru again for the fix.
On Tue, Jul 30, 2019 at 12:16 AM Han Zhou wrote:
> Thanks Mark and
On Mon, Aug 5, 2019 at 3:55 PM Lorenzo Bianconi
wrote:
> If no protcol is specified defining a load balancing rule TCP is
> selected as defualt but ovn-nbctl lb-list reports 'tcp/udp' in this
> case. Fix it reporting tcp in this case
>
> Fixes: e2bfcad6cbb0 ("ovn-nbctl: Add LB commands")
>
Prior to this patch, only db change aware connections were dropped
on a read/write status change. However, current schema in OVN does
not allow clients to monitor whether a particular DB changes this
status. In order to accomplish this, we'd need to change the schema
and adapting ovsdb-server and
From: Han Zhou
From: Han Zhou
When using unixctl command inject-packet, it always respond with
failure "server not ready", although the command was actually executed
successfully.
Fixes: 0bd4d85c36ef ("ovn-controller: Initial use of incremental engine - quiet
mode.")
Signed-off-by: Han Zhou
Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd
will crash (SIGSEV) because the current code injects a flow to
emit the ICMP need-to-frag from its IPv4 address which does not
exist.
This patch is adding a check to skip the flow installation in case
the port does not have any
The patch LGTM. Few comments inline.
Please see below
Thanks
Numan
On Fri, Aug 2, 2019 at 5:23 AM Ankur Sharma
wrote:
> With 795d7f24ce0e2ed5454e193a059451d237289542 we have added
> support for E-W routing on vlan backed networks by replacing
> router port macs with chassis macs.
>
> This
Bleep bloop. Greetings Daniel Alvarez, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
On Fri, Aug 2, 2019 at 5:51 PM Justin Pettit wrote:
>
>
> > On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote:
> >
> > This function will be useful for following patchs.
>
> s/patchs/patches/
>
> Acked-by: Justin Pettit
>
> --Justin
Thanks, will fix the typo in v3.
-Yi-Hung
On Fri, Aug 2, 2019 at 5:24 AM Ankur Sharma
wrote:
> Background:
> With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added
> support for E-W workflow for vlan backed DVRs.
>
> This series enables N-S workflow for vlan backed DVRs.
>
> Key difference between E-W and N-S traffic flow is that
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
On Mon, Aug 5, 2019 at 3:50 PM wrote:
>
> From: Numan Siddique
>
> The commit [1] encoded the vport key using uint32_t and the test case
> "action parsing" is failing for s380 arch.
>
> This patch fixes this issue by encoding the vport key in the network byte
> order.
>
> [1] - 054f4c85c413("Add
On Mon, Aug 5, 2019 at 6:53 AM Numan Siddique wrote:
>
>
>
> On Mon, Aug 5, 2019 at 1:43 PM Dumitru Ceara wrote:
>>
>> On Mon, Aug 5, 2019 at 9:29 AM Han Zhou wrote:
>> >
>> > From: Han Zhou
>> >
>> > When using unixctl command inject-packet, it always respond with
>> > failure "server not
On Mon, Aug 5, 2019 at 5:25 PM Han Zhou wrote:
>
>
>
> On Mon, Aug 5, 2019 at 6:53 AM Numan Siddique wrote:
> >
> >
> >
> > On Mon, Aug 5, 2019 at 1:43 PM Dumitru Ceara wrote:
> >>
> >> On Mon, Aug 5, 2019 at 9:29 AM Han Zhou wrote:
> >> >
> >> > From: Han Zhou
> >> >
> >> > When using
On Fri, Aug 2, 2019 at 11:15 AM Justin Pettit wrote:
>
>
> > On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote:
> >
> > From: Justin Pettit
> >
> > From: Justin Pettit
>
> Can you drop one of these "From:" statements? Otherwise it appears in the
> commit message.
>
> As we discussed off-line,
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
From: Dumitru Ceara
When trying to incrementally process changes even if there are in-flight
messages we were incorrectly setting the engine_aborted variable to the
value returned by engine_run. However, engine_run returns true if the
run was completed.
This was causing discrepancies between
From: Han Zhou
When there are in-flight flow-installations pending to ovs-vswitchd,
current incremental processing logic prioritizes new change handling.
However, in scenarios where frequent recomputes are triggered, the
later recompute would block the flow-installation for previously
computed
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
Fix conntrack checks in the following tests in tests/system-ovn.at:
- ovn -- DNAT and SNAT on distributed router - N/S
- ovn -- DNAT and SNAT on distributed router - E/W
Fixes: a6ee09882283 ("OVN: run local logical flows first in S_ROUTER_OUT_SNAT
table")
Signed-off-by: Lorenzo Bianconi
---
On Mon, Aug 5, 2019 at 1:43 PM Dumitru Ceara wrote:
> On Mon, Aug 5, 2019 at 9:29 AM Han Zhou wrote:
> >
> > From: Han Zhou
> >
> > When using unixctl command inject-packet, it always respond with
> > failure "server not ready", although the command was actually executed
> > successfully.
> >
If no protcol is specified defining a load balancing rule TCP is
selected as defualt but ovn-nbctl lb-list reports 'tcp/udp' in this
case. Fix it reporting tcp in this case
Fixes: e2bfcad6cbb0 ("ovn-nbctl: Add LB commands")
Acked-by: Dumitru Ceara
Signed-off-by: Lorenzo Bianconi
---
Changes
From: Numan Siddique
The commit [1] encoded the vport key using uint32_t and the test case
"action parsing" is failing for s380 arch.
This patch fixes this issue by encoding the vport key in the network byte
order.
[1] - 054f4c85c413("Add a new logical switch port type - 'virtual'")
Fixes:
From: Numan Siddique
The commit [1] encoded the vport key using uint32_t and the test case
"action parsing" is failing for s380 arch.
This patch fixes this issue by encoding the vport key in the network byte
order.
[1] - 054f4c85c413("Add a new logical switch port type - 'virtual'")
Fixes:
On Thu, Aug 1, 2019 at 5:09 PM Dumitru Ceara wrote:
> There's no need to use HMAP_FOR_EACH_SAFE when we add the logical flows
> that correspond to IGMP groups as we don't modify the hashmap in the
> loop.
>
> Also, we should reinitialize match and actions only if the flow will be
> added.
>
>
From: Numan Siddique
The commit [1] encoded the vport key using uint32_t and the test case
"action parsing" is failing for s380 arch.
This patch fixes this issue by encoding the vport key in the network byte
order.
[1] - 054f4c85c413("Add a new logical switch port type - 'virtual'")
Fixes:
> From: Numan Siddique
>
> With this patch we have to configure OVN to refer to external OVS source/build
> directory instead of the ovs subtree.
>
> The new configuration options added are:
> * --with-ovs-source=/path/to/ovs/source/dir
> * --with-ovs-build=/path/to/ovs/build/dir
>
> Before
On Mon, Aug 5, 2019 at 11:45 PM Mark Michelson wrote:
> When running the pre-installation hook, the spec file attempts to
> determine if the old openvswitch-provided OVN services are running. If
> this is a fresh installation, then there never was an
> openvswitch-provided service installed on
When running the pre-installation hook, the spec file attempts to
determine if the old openvswitch-provided OVN services are running. If
this is a fresh installation, then there never was an
openvswitch-provided service installed on the machine. Therefore,
systemd will emit a warning saying the
I applied the change to master.
On 8/5/19 9:08 AM, Numan Siddique wrote:
On Thu, Aug 1, 2019 at 5:09 PM Dumitru Ceara wrote:
There's no need to use HMAP_FOR_EACH_SAFE when we add the logical flows
that correspond to IGMP groups as we don't modify the hashmap in the
loop.
Also, we should
On Mon, Aug 5, 2019 at 11:20 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> > From: Numan Siddique
> >
> > With this patch we have to configure OVN to refer to external OVS
> source/build
> > directory instead of the ovs subtree.
> >
> > The new configuration options added are:
> >
I applied the change to master.
On 8/5/19 10:49 AM, Dumitru Ceara wrote:
On Mon, Aug 5, 2019 at 3:50 PM wrote:
From: Numan Siddique
The commit [1] encoded the vport key using uint32_t and the test case
"action parsing" is failing for s380 arch.
This patch fixes this issue by encoding the
One comment fix:
s/ "min": 0, "max": "65535"}},/ "min": 0, "max": "65536"}},/
On Mon, Aug 5, 2019 at 4:09 PM Darrell Ball wrote:
> Thanks for the patch
>
> I avoided duplicate comments from what Justin suggested
>
> comments inline
>
> On Thu, Aug 1, 2019 at 3:08 PM Yi-Hung Wei wrote:
>
>>
Thanks for the patch
comments inline
On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote:
> This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
> the zone-based timeout policy in the vswitchd. Whenever there is a
> database change, vswitchd will read the datapath, CT_Zone, and
Thanks for the patch
I noticed '--may-exist' and '--if-exists' are supported now for
add--zone-tp/del-zone-tp - thanks
The check for duplicate timeout policies now correctly checks all key and
values - thanks
Some more comments inline
I am trying to avoid duplicate comment from Justin, so I just
Hi Numan,
Sure, i will address the comments in V4.
Regards,
Ankur
From: Numan Siddique
Sent: Monday, August 5, 2019 9:03 AM
To: Ankur Sharma
Cc: ovs-dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3 1/4 ovn] OVN: Do not replace router port mac
on gateway
Hi Numan,
Thanks a lot for the feedback.
I was considering ovn-nbctl as a tool for playing with the feature and CMS
should not be relying on it.
However, it is better not to override rest of the options. I will address this
in V4.
I will wait for your comments on other patches in the series,
ВЕЛИКИЕ РОССИЙСКИЕ ИСПОЛНИТЕЛИ 20 ВЕКА
Старинные Русские и Цыганские Романсы. Арии из опер и оперетт. Лирические песни.
Неаполитанские песни. Народные, деревенские, городские - песни и баллады. Песни
военных лет.
Предлагаем Вашему вниманию, пожалуй, самую большую и уникальную коллекцию:
Thanks for the patch
I avoided duplicate comments from what Justin suggested
comments inline
On Thu, Aug 1, 2019 at 3:08 PM Yi-Hung Wei wrote:
> From: Justin Pettit
>
> From: Justin Pettit
>
> Signed-off-by: Justin Pettit
> ---
> vswitchd/vswitch.ovsschema | 43 +++-
>
Thanks for the patch
I am going to avoid commenting on style or code conciseness in the
interests of time
On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote:
> This patch first defines the dpif interface for a datapath to support
> adding, deleting, getting and dumping conntrack timeout policy.
Thanks for the patch
I see the test is much improved now from V1 and passes - thanks
Ideally, tests should be associated with some code for context
It could be folded into patch 8
On Thu, Aug 1, 2019 at 3:12 PM Yi-Hung Wei wrote:
> This patch adds a system traffic test to verify the
> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote:
>
> This patch also adds missing symbols in the windows datapath so
> that the build on windows can pass.
Alin, can you do a quick sanity-check on the Windows part? Thanks.
Yi-Hung, it looks good to me. Just mostly some minor stuff below.
>
Thanks for the patch
The main comment I had from the V1 patch was adding the check
+if (ofc->flags & NX_CT_F_COMMIT) {
in compose_conntrack_action()
I see that was done.
After a quick scan, I had one minor comment inline.
On Thu, Aug 1, 2019 at 3:12 PM Yi-Hung Wei wrote:
> This patch
On 2019-07-22 8:10 PM, Ben Pfaff wrote:
> On Sun, Jul 21, 2019 at 11:34:20AM +0300, Roi Dayan wrote:
>> The following series expose configuration options to
>> be able to tune revalidator timing to different setups
>> at runtime instead of using hard coded values.
>
> These seem fine.
>
> I'd
51 matches
Mail list logo
