[ovs-dev] does OVS support for sch_taptio scheduling algorithm?

2019-08-19 Thread Vikas Kumar
Hi Team, could anyone please suggest me how to make my sch_taprio scheduling algorithm work with OVS switch? any changes in code is required or any specific configuration? Thanks vikash ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH v3 ovn 2/3] OVN: add meter support to trigger_event action

2019-08-19 Thread Lorenzo Bianconi
Introduce meter support to trigger_event action in order to not overload pinctrl thread under heavy load Signed-off-by: Lorenzo Bianconi --- include/ovn/actions.h | 1 + lib/actions.c | 43 +-- 2 files changed, 38 insertions(+), 6 deletions(-)

[ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.

2019-08-19 Thread Lorenzo Bianconi
From: Mark Michelson From: Mark Michelson Controller event action is leaking its genopts. This corrects the error. Signed-off-by: Mark Michelson Signed-off-by: Lorenzo Bianconi --- lib/actions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/actions.c

Re: [ovs-dev] [PATCH ovn v4] ovn-northd: Add IGMP Relay support

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 ovn-northd: Add IGMP Relay support The copy

[ovs-dev] [PATCH v3 5/5] ovsdb raft: Support leader election time change online.

2019-08-19 Thread Han Zhou
From: Han Zhou A new unixctl command cluster/change-election-timer is implemented to change leader election timeout base value according to the scale needs. The change takes effect upon consensus of the cluster, implemented through the append-request RPC. A new field "election-timer" is added

[ovs-dev] [PATCH v2 ovn 1/5] Build OVN using external OVS directory

2019-08-19 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-19 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds the support to compile OVN from external OVS sources. The following configuration options are added when configuring OVN * --with-ovs-source (mandatory) * --with-ovs-build

Re: [ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-19 Thread Numan Siddique
On Fri, Aug 16, 2019 at 10:45 PM Mark Michelson wrote: > On 8/13/19 12:27 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > > The commit [1] changed the package name from openvswitch to ovn, but > > it didn't

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-19 Thread Darrell Ball
On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei wrote: > On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: > > > > Thanks for the patch > > > > Pls let me know if this incremental works for you. > > Main change is logging fix for timeout policy deletion. > > > > Darrell > > > > diff --git

Re: [ovs-dev] [PATCH v2 ovn 1/5] Build OVN using external OVS directory

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #141 FILE:

Re: [ovs-dev] [PATCH v2 ovn 3/5] Fix "make rpm-fedora"

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 108 characters long (recommended limit is 79) #284 FILE:

Re: [ovs-dev] [PATCH v2 ovn 2/5] Add support for using OVN specific rundirs

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #2123 FILE:

Re: [ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH v2 ovn 4/5] rhel: Run ovn services with the 'openvswitch' user

2019-08-19 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

Re: [ovs-dev] [PATCH branch-2.12] pinctrl: Fix DNS packet parsing

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH v3 4/5] raft.c: Set candidate_retrying if no leader elected since last election.

2019-08-19 Thread Han Zhou
From: Han Zhou candiate_retrying is used to determine if the current node is disconnected from the cluster when the node is in candiate role. However, a node can flap between candidate and follower role before a leader is elected when majority of the cluster is down, so is_connected() will flap,

[ovs-dev] [PATCH v3 3/5] raft.c: Stale leader should disconnect from cluster.

2019-08-19 Thread Han Zhou
From: Han Zhou As mentioned in RAFT paper, section 6.2: Leaders: A server might be in the leader state, but if it isn’t the current leader, it could be needlessly delaying client requests. For example, suppose a leader is partitioned from the rest of the cluster, but it can still communicate

[ovs-dev] [PATCH v2 ovn 2/5] Add support for using OVN specific rundirs

2019-08-19 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH v2 ovn 3/5] Fix "make rpm-fedora"

2019-08-19 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH v3 ovn 3/3] OVN: northd: add rate limiting support for SB controller events

2019-08-19 Thread Lorenzo Bianconi
Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. Each event type relies on a meter with a defined name: - empty_lb_backends: event-elb Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi ---

Re: [ovs-dev] [PATCH v2 1/4] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-19 Thread Han Zhou
I just sent V3 of the series which mainly adds the 5th patch to the series for changing election timer online. In addition, there are just minor fixes in test cases. https://patchwork.ozlabs.org/project/openvswitch/list/?series=126000 I hope at least 1/5 - 4/5 can get in branch 2.12. 5/5 is

Re: [ovs-dev] [PATCH ovn 3/4] Fix "make rpm-fedora"

2019-08-19 Thread Numan Siddique
On Fri, Aug 16, 2019 at 10:46 PM Mark Michelson wrote: > On 8/13/19 12:28 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > "make rpm-fedora" is broken and this patch fixes it. Previous patch > > in this series supported building OVN from external OVS sources. > > > > Before

Re: [ovs-dev] [PATCH v4 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-19 Thread Yi-Hung Wei
On Fri, Aug 16, 2019 at 5:10 PM Darrell Ball wrote: > > Thanks for the patch > > Pls let me know if the following incremental works for you. > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 244155a..cb8b51e 100644 > --- a/ofproto/ofproto-dpif.c > +++

[ovs-dev] [PATCH v3 ovn 0/3] add rate limiting support for controller_events

2019-08-19 Thread Lorenzo Bianconi
Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. For each event type we need to define a naming convention for the related meter: - empty_lb_backends: event-elb Changes since v2: - fold patch 'Repair memory

Re: [ovs-dev] [PATCH] conntrack: check the result of extract_l3_ipv4/6

2019-08-19 Thread Darrell Ball
Thanks for the patch On Sun, Aug 18, 2019 at 11:01 PM Li RongQing wrote: > the result of extract_l3_ipv4/6 should be checked in reverse_nat_packet > when it is false, meaning this packet is wrong, should not do handle it > continually > > Signed-off-by: Li RongQing > --- > lib/conntrack.c |

Re: [ovs-dev] [PATCH v6 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #249 FILE: utilities/ovn-nbctl.c:670:

Re: [ovs-dev] [PATCH v2 ovn] Containerize components

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Aliasgar Ginwala needs to sign off. WARNING: Unexpected sign-offs from

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-19 Thread Yi-Hung Wei
On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: > > Thanks for the patch > > Pls let me know if this incremental works for you. > Main change is logging fix for timeout policy deletion. > > Darrell > > diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c > index 1d4ee60..00d957b 100644 > ---

Re: [ovs-dev] [PATCH v2] OVS: Containerize components

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Aliasgar Ginwala needs to sign off. WARNING: Unexpected sign-offs from

[ovs-dev] [PATCH v3 2/5] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-19 Thread Han Zhou
From: Han Zhou When clustered mode is used, the client needs to retry connecting to new servers when certain failures happen. Today it is allowed to retry new connection only if multiple remotes are used, which prevents using LB VIP with clustered nodes. This patch makes sure the retry logic

[ovs-dev] [PATCH v3 1/5] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-19 Thread Han Zhou
From: Han Zhou Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution when leader failover.") Signed-off-by: Han Zhou --- ovsdb/raft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index c60ef41..1c38b3b 100644 ---

[ovs-dev] [PATCH] ovsdb monitor: Fix crash when using non-zero last-id with standalone DB.

2019-08-19 Thread Han Zhou
From: Han Zhou When a client uses monitor-cond-since with a non-zero last-id but the server is not in cluster mode for the DB being monitored, it leads to segmentation fault because the txn_history list is not initialized in this case. Program terminated with signal SIGSEGV, Segmentation fault.

Re: [ovs-dev] [PATCH v4 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-19 Thread Darrell Ball
On Mon, Aug 19, 2019 at 11:12 AM Yi-Hung Wei wrote: > On Fri, Aug 16, 2019 at 5:10 PM Darrell Ball wrote: > > > > Thanks for the patch > > > > Pls let me know if the following incremental works for you. > > > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > > index

[ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-19 Thread Aliasgar Ginwala
Current code of create-cluster from standalone db takes backup of existing standalone db and then generates a new clustered dbs from backup dbs. Hence, during migration if nb and sb dbs are still present, create-cluster will fail saying file exists and will not really convert dbs to clustered

Re: [ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Aliasgar Ginwala needs to sign off. WARNING: Unexpected sign-offs from

[ovs-dev] Estrategias para la fidelización de su personal

2019-08-19 Thread Importante
Es, para mí, un placer poder invitarte a nuestro Curso en Línea "¿Cómo realizar una DNC efectiva?", que se estará llevando a cabo el día Jueves 05 de Septiembre con un horario de 10:00 a 14:00 hrs. (hora del centro de México) El Diagnóstico de las Necesidades de Capacitación (DNC) es un

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-19 Thread Darrell Ball
On Mon, Aug 19, 2019 at 12:42 PM Darrell Ball wrote: > > > On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei wrote: > >> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: >> > >> > Thanks for the patch >> > >> > Pls let me know if this incremental works for you. >> > Main change is logging fix

[ovs-dev] [PATCH] conntrack: check the result of extract_l3_ipv4/6

2019-08-19 Thread Li RongQing
the result of extract_l3_ipv4/6 should be checked in reverse_nat_packet when it is false, meaning this packet is wrong, should not do handle it continually Signed-off-by: Li RongQing --- lib/conntrack.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

2019-08-19 Thread Ilya Maximets
On 19.08.2019 12:39, Sriram Vatala wrote: > > -Original Message- > From: Ilya Maximets > Sent: 09 August 2019 17:44 > To: ovs-dev@openvswitch.org > Cc: Ian Stokes ; Kevin Traynor ; > David Marchand ; Sriram Vatala > ; Ilya Maximets > Subject: [PATCH 2/2] netdev-dpdk: Refactor vhost

Re: [ovs-dev] [PATCH v2.12] OVN: Repair memory leak for OVN controller events.

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mark Michelson needs to sign off. Lines checked: 29, Warnings: 0, Errors: 1

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH v2 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

2019-08-19 Thread Ilya Maximets
vHost interfaces currently has only one custom statistic, but there might be others in the near future. This refactoring makes the code work in the same way as it done for dpdk and afxdp stats to keep the common style over the different code places and makes it easily extensible for the new stats

[ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

2019-08-19 Thread Ilya Maximets
There is a big code duplication issue with DPDK xstats that led to missed "rx_oversize_errors" statistics. It's defined but not used. Fix that by actually using this stat along with code refactoring that will allow us to not make same mistakes in the future. Macro definitions are perfectly

[ovs-dev] [PATCH v2 0/2] netdev-dpdk: Stats fix and refactoring.

2019-08-19 Thread Ilya Maximets
Version 2: * Fixed incorrect handling of vhost stats if there are more than one of them. Ilya Maximets (2): netdev-dpdk: Fix not reporting rx_oversize_errors in stats. netdev-dpdk: Refactor vhost custom stats for extensibility. lib/netdev-dpdk.c | 130

Re: [ovs-dev] [PATCH v5 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #249 FILE: utilities/ovn-nbctl.c:670:

Re: [ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-19 Thread Dumitru Ceara
On Tue, Aug 13, 2019 at 6:28 PM wrote: > > From: Numan Siddique > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > The commit [1] changed the package name from openvswitch to ovn, but > it didn't take into the account the effects of it. When "make install" > is run

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

2019-08-19 Thread Sriram Vatala via dev
-Original Message- From: Ilya Maximets Sent: 09 August 2019 17:44 To: ovs-dev@openvswitch.org Cc: Ian Stokes ; Kevin Traynor ; David Marchand ; Sriram Vatala ; Ilya Maximets Subject: [PATCH 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility. vHost interfaces currently