Re: [ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-06 Thread Numan Siddique
Hi Ankur, Couple of comments, otherwise LGTM. Thanks Numan On Wed, Sep 4, 2019 at 12:45 AM Ankur Sharma wrote: > During E-W routing for vlan backed networks, we replace router port > mac with chassis mac, when packet leaves the source hypervisor. > > As a result, the destination VM (on

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-06 Thread Eelco Chaudron
On 5 Sep 2019, at 18:21, William Tu wrote: Did some more testing and with PVP I see a performance decrease, with physical to physical I see an increase. Tests are performed with a port redirect open flow rule on an ixgbe (Xeon E5-2690 v4 2.60GHz):

Re: [ovs-dev] [PATCH v2 0/3] Fix TSC frequency if DPDK is not available.

2019-09-06 Thread Ilya Maximets
On 02.09.2019 14:27, Ilya Maximets wrote: > > Version 2: > * Removed redundant OVS_UNUSED. > * 'ovs_numa_thread_setaffinity_core' reimplemented via > 'ovs_numa_thread_setaffinity_dump' to reduce code duplication. > * Added Ack from William to patches #2 and #3 as they wasn't changed. >

Re: [ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.

2019-09-06 Thread Ilya Maximets
On 13.08.2019 19:37, Ilya Maximets wrote: > This is highly useful to see on which core PMD is running by > only looking at the thread name. Thread Id still allows to > distinguish different threads running on the same core over the time: > >|dpif_netdev(pmd-c10/id:53)|DBG|Creating 2. subtable

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for the RTE_ETH_EVENT_INTR_RESET event

2019-09-06 Thread Ilya Maximets
On 05.09.2019 17:44, Eelco Chaudron wrote: > See inlines below, and will sent a v2 early next week. > > On 5 Sep 2019, at 14:40, Ilya Maximets wrote: > >> Hi Eelco, >> Thanks for the patch! Looks reasonable. >> >> One comment is that it's better to explicitly initialize the >> flag in

Re: [ovs-dev] [PATCH] dpdk: Remove unneeded log message copy.

2019-09-06 Thread David Marchand
On Fri, Sep 6, 2019 at 3:24 PM Ilya Maximets wrote: > > On 06.09.2019 14:26, David Marchand wrote: > > No need to duplicate and null-terminate the passed buffer. > > We can directly give it to the vlog subsystem using a dynamic precision > > in the format string. > > > > Signed-off-by: David

Re: [ovs-dev] [branch-2.12 PATCH] netdev-dpdk: Fix padding info comment.

2019-09-06 Thread Ilya Maximets
On 05.09.2019 16:21, Kevin Traynor wrote: > The comment was incorrectly updated. Fix it to the > correct value of 32 pad bytes. > > /* --- cacheline 5 boundary (320 bytes) --- */ > union { > struct { > struct netdev_stats stats; /* 320 336 */ > /*

Re: [ovs-dev] [PATCH] dpdk: Remove unneeded log message copy.

2019-09-06 Thread Ilya Maximets
On 06.09.2019 14:26, David Marchand wrote: > No need to duplicate and null-terminate the passed buffer. > We can directly give it to the vlog subsystem using a dynamic precision > in the format string. > > Signed-off-by: David Marchand > --- Thanks for a patch. Looks good at a first glance.

Re: [ovs-dev] [PATCH v5 ovn 0/3] Add rate limiting support for controller_events

2019-09-06 Thread Mark Michelson
I pushed this series to master. On 9/3/19 10:22 AM, Lorenzo Bianconi wrote: Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. For each event type we need to define a naming convention for the related meter:

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-06 Thread Ilya Maximets
On 05.09.2019 9:58, Sriram Vatala wrote: > Hi Ilya, > Thanks a lot for the explanation. As per your suggestion, I will move all the > counters (including 'tx_retries')to some structure and place a pointer to it > in netdev_dpdk structure so that the padding size will not vary with the >

Re: [ovs-dev] [PATCH] dpdk: Remove unneeded log message copy.

2019-09-06 Thread Eelco Chaudron
On 6 Sep 2019, at 13:26, David Marchand wrote: > No need to duplicate and null-terminate the passed buffer. > We can directly give it to the vlog subsystem using a dynamic precision > in the format string. > > Signed-off-by: David Marchand Change looks good to me! Acked-by: Eelco Chaudron

[ovs-dev] [branch-11 2/2] Prepare for 2.11.4.

2019-09-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f177d7efc181..7c45f561cb0d 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.11.4 - xx xxx

[ovs-dev] [branch-11 1/2] Set release date for 2.11.3.

2019-09-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 8f84f68a4dfe..f177d7efc181 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.11.3 - xx xxx +v2.11.3 - 06 Sep 2019

Re: [ovs-dev] [branch-11 1/2] Set release date for 2.11.3.

2019-09-06 Thread 0-day Robot
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Set release date for 2.11.3. The copy of the

[ovs-dev] Grüße an dich, Schatz.

2019-09-06 Thread Salem Al Mohannadi
Katar Petroleum Doha, Katar Grüße an dich, Schatz. Haben Sie die vorherige Mail erhalten, die ich Ihnen gesendet habe? Ich warte auf Ihre Antwort so schnell wie möglich. Freundliche Grüße, Eng. Salem Mohd H.A. Al-Mohannadi Manager Finanzen und Konto, Aus Katar Petroleum.

[ovs-dev] [branch-10 1/2] Set release date for 2.10.4.

2019-09-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 46c751571482..8015901d63d9 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.10.4 - xx xxx +v2.10.4 - 06 Sep 2019

[ovs-dev] [branch-10 2/2] Prepare for 2.10.5.

2019-09-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8015901d63d9..1756f605a657 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.10.5 - xx xxx

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-09-06 Thread aginwala
Hi: Adding correct ovs-discuss ML. I did get a chance to take a look on it a bit. I think this is the bug in 4.4.0-104-generic kernel on ubuntu 16.04 as its being discussed on ubuntu forum https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1711407 where it can be hit all of a sudden as per the

[ovs-dev] Supply Chain Management

2019-09-06 Thread Laura Mendez
Hi, Would you be interested in an email lead list of Supply Chain Executives? We can help you reach out to. Title includes: ? VP of Supply Chain ? Director of Supply Chain ? Supply Chain Manager ? Purchasing Manager ? Purchasing Director ? Procurement Manager ? Procurement

Re: [ovs-dev] [PATCH v2 ovn] northd: add empty_lb controller_event for logical router

2019-09-06 Thread Mark Michelson
Hi Lorenzo, I only have one finding down below On 9/6/19 11:00 AM, Lorenzo Bianconi wrote: Add empty load balancer controller_event support to logical router pipeline. Update northd documentation even for logical switch pipeline Signed-off-by: Lorenzo Bianconi --- Changes since v1: - rebase

Re: [ovs-dev] [branch-10 1/2] Set release date for 2.10.4.

2019-09-06 Thread 0-day Robot
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Set release date for 2.10.4. The copy of the

Re: [ovs-dev] [branch-11 1/2] Set release date for 2.11.3.

2019-09-06 Thread Ben Pfaff
On Fri, Sep 06, 2019 at 10:16:24AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Seems fine. For both patches: Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.5 1/2] Set release date for 2.5.9.

2019-09-06 Thread Justin Pettit
> On Sep 5, 2019, at 12:38 PM, Ben Pfaff wrote: > > All of these 2.5 to 2.8 release series look good to me. > > Acked-by: Ben Pfaff Thanks. I pushed these to all the appropriate branches. --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [branch-10 1/2] Set release date for 2.10.4.

2019-09-06 Thread Ben Pfaff
On Fri, Sep 06, 2019 at 10:16:59AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Seems fine. For both patches: Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

2019-09-06 Thread Mark Michelson
This document serves to provide an explanation for how OVN will remain compatible with OVS. It provides instructions for OVN contributors for how to maintain compatibility even across older versions of OVS when possible. Note that the document currently makes reference to some non-existent items.

[ovs-dev] Global Market infiltration

2019-09-06 Thread Alma Newton
Hi there, Hope you're doing great. Would you like to target accounts of below technologies in order to boost your sales and marketing goals in this quarter? We can help you provide the data intelligence of: *Microsoft Azure Users *AWS Users *

Re: [ovs-dev] [PATCH v3] Remove OVN.

2019-09-06 Thread Ben Pfaff
On Fri, Sep 06, 2019 at 10:33:03AM -0400, Mark Michelson wrote: > OVN is separated into its own repo. This commit removes the OVN source, > OVN tests, and OVN documentation. It also removes mentions of OVN from > most documentation. The only place where OVN has been left is in > changelogs/NEWS,

Re: [ovs-dev] [PATCH] faq: Update list of kernels supported by 2.12.

2019-09-06 Thread Justin Pettit
> On Sep 6, 2019, at 4:52 PM, Yifeng Sun wrote: > > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun Thanks for the quick review. I pushed this to master and branch-2.12. --Justin ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] faq: Update list of kernels supported by 2.12.

2019-09-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 8daa23bb2d0c..8c29e32efa71 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@

Re: [ovs-dev] [PATCH] faq: Update list of kernels supported by 2.12.

2019-09-06 Thread Yifeng Sun
Looks good to me, thanks. Reviewed-by: Yifeng Sun On Fri, Sep 6, 2019 at 4:33 PM Justin Pettit wrote: > > Signed-off-by: Justin Pettit > --- > Documentation/faq/releases.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/faq/releases.rst

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-09-06 Thread Han Zhou
Good finding. So it is a known kernel bug and it won't get fixed in that kernel version. :( >From OVS point of view, the problem is, if such bug exists in kernel, it prevents ovs-vswitchd to be killed (even by SIGKILL) because the process is in system call which got blocked because of the kernel

Re: [ovs-dev] [PATCH] tests: Add track-origins flag to valgrind.

2019-09-06 Thread Ilya Maximets
On 05.09.2019 18:18, Ben Pfaff wrote: > On Tue, Sep 03, 2019 at 06:07:26PM +0300, Ilya Maximets wrote: >> Useful for tracking where the uninitialized memory came from. >> Report example: >> >> Thread 13 revalidator11: >> Conditional jump or move depends on uninitialised value(s) >> at

[ovs-dev] [PATCH] dpdk: Remove unneeded log message copy.

2019-09-06 Thread David Marchand
No need to duplicate and null-terminate the passed buffer. We can directly give it to the vlog subsystem using a dynamic precision in the format string. Signed-off-by: David Marchand --- lib/dpdk.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/dpdk.c

Re: [ovs-dev] [PATCH v5 ovn 0/3] Add rate limiting support for controller_events

2019-09-06 Thread Mark Michelson
Looks good, Lorenzo. Acked-by: Mark Michelson On 9/3/19 10:22 AM, Lorenzo Bianconi wrote: Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. For each event type we need to define a naming convention for the

Re: [ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

2019-09-06 Thread Justin Pettit
> On Sep 5, 2019, at 4:40 PM, aginwala wrote: > > Hi Justin: > > Please back-port the above patches to branch-2.10 too as it fails there too. Done. Thanks. --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-06 Thread William Tu
On Fri, Sep 6, 2019 at 1:14 AM Eelco Chaudron wrote: > > > > On 5 Sep 2019, at 18:21, William Tu wrote: > > >> Did some more testing and with PVP I see a performance decrease, with > >> physical to physical I see an increase. > >> Tests are performed with a port redirect open flow rule on an

[ovs-dev] [PATCH v2 ovn] northd: add empty_lb controller_event for logical router

2019-09-06 Thread Lorenzo Bianconi
Add empty load balancer controller_event support to logical router pipeline. Update northd documentation even for logical switch pipeline Signed-off-by: Lorenzo Bianconi --- Changes since v1: - rebase on-top of current ovn master branch --- northd/ovn-northd.8.xml | 10