[ovs-dev] [PATCH v1 ovn] ovs container build.sh requires python3

2019-10-11 Thread amginwal
From: Aliasgar Ginwala building ovn/ovs container breaks while configure: checking for Python 3 (version 3.4 or later)... no configure: error: Python 3.4 or later is required but not found in /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, please install it or set to point to it

Re: [ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-11 Thread Han Zhou
On Fri, Oct 11, 2019 at 2:07 PM wrote: > > From: Aliasgar Ginwala > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later is required but not found in >

[ovs-dev] NetSuite Potential Businees Leads

2019-10-11 Thread Pauline Taylor
Hi, Hope you are doing great! I'm curious to know if you'd be interested in procuring NetSuite Users List for your sales and marketing initiatives. We also have related technology users like: Sage 100cloud, Salesforce, Sap, Quickbooks, Dynamics 365, Oracle and many more...

Re: [ovs-dev] [PATCH v2] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-11 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (controller/pinctrl.c). Repository lacks necessary

[ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-11 Thread amginwal
From: Aliasgar Ginwala building ovn/ovs container breaks while configure: checking for Python 3 (version 3.4 or later)... no configure: error: Python 3.4 or later is required but not found in /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, please install it or set to point to it

[ovs-dev] [PATCH v2] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-11 Thread Ankur Sharma
ISSUE: For a VIF port (on a bridged logical switch), OVN sends out GARPs, advertising port's mac and IP. However, if a VIF port (on a bridged logical switch) has not been assigned an IP, then OVN does not advertise anything. As a result, for such VIF ports basic operations like VM migration will

[ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-11 Thread Yifeng Sun
This patch provides essential fixes for OVS to support RHEL7.7's new kernel. make rpm-fedora-kmod \ RPMBUILD_OPT='-D "kversion 3.10.0-1062.1.2.el7.x86_64"' Signed-off-by: Yifeng Sun --- rhel/openvswitch-kmod-fedora.spec.in | 9 +

Re: [ovs-dev] [PATCH] netdev-afxdp: Update memory locking limits unconditionally.

2019-10-11 Thread William Tu
On Fri, Oct 11, 2019 at 01:17:59PM +0200, Ilya Maximets wrote: > On 10.10.2019 20:29, William Tu wrote: > >On Wed, Oct 09, 2019 at 04:23:31PM +0200, Ilya Maximets wrote: > >>Any type of AF_XDP socket in all modes implies creation of BPF map of > >>type BPF_MAP_TYPE_XSKMAP. This leads to

Re: [ovs-dev] [PATCH] netdev-afxdp: Fix umem creation failure due to uninitialized config.

2019-10-11 Thread William Tu
On Fri, Oct 11, 2019 at 01:16:55PM +0200, Ilya Maximets wrote: > On 10.10.2019 20:21, William Tu wrote: > >On Wed, Oct 09, 2019 at 04:17:58PM +0200, Ilya Maximets wrote: > >>Later version of 'struct xsk_umem_config' contains additional field > >>'flags'. OVS doesn't use that field passing

[ovs-dev] [PATCH] dpif-netlink: Free leaked nl_sock

2019-10-11 Thread Yifeng Sun
Valgrind reports: 20 bytes in 1 blocks are definitely lost in loss record 94 of 353 by 0x532594: xmalloc (util.c:138) by 0x553EAD: nl_sock_create (netlink-socket.c:146) by 0x54331D: create_nl_sock (dpif-netlink.c:255) by 0x54331D: dpif_netlink_port_add__ (dpif-netlink.c:756) by

Re: [ovs-dev] [PATCH v3] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-11 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (controller/pinctrl.c). Repository lacks necessary

[ovs-dev] [PATCH v3] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-11 Thread Ankur Sharma
ISSUE: For a VIF port (on a bridged logical switch), OVN sends out GARPs, advertising port's mac and IP. However, if a VIF port (on a bridged logical switch) has not been assigned an IP, then OVN does not advertise anything. As a result, for such VIF ports basic operations like VM migration will

[ovs-dev] [PATCH net-next v3 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang When we destroy the flow tables which may contain the flow_mask, so release the flow mask struct. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/flow_table.c

[ovs-dev] [PATCH net-next v3 07/10] net: openvswitch: add likely in flow_lookup

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang The most case *index < ma->count, and flow-mask is not NULL. We add un/likely for performance. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/openvswitch/flow_table.c

Re: [ovs-dev] [PATCH] tests: Allow valgrind check for afxdp testsuite.

2019-10-11 Thread Ilya Maximets
On 10.10.2019 22:51, William Tu wrote: On Wed, Oct 09, 2019 at 04:18:38PM -0700, William Tu wrote: On Wed, Oct 09, 2019 at 11:20:00AM -0700, Ben Pfaff wrote: On Wed, Oct 09, 2019 at 04:36:49PM +0200, Ilya Maximets wrote: New 'make' target 'check-afxdp-valgrind'. Signed-off-by: Ilya Maximets

[ovs-dev] [PATCH net-next v3 01/10] net: openvswitch: add flow-mask cache for performance

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang The idea of this optimization comes from a patch which is committed in 2014, openvswitch community. The author is Pravin B Shelar. In order to get high performance, I implement it again. Later patches will use it. Pravin B Shelar, says: | On every packet OVS needs to lookup

[ovs-dev] [PATCH net-next v3 10/10] net: openvswitch: simplify the ovs_dp_cmd_new

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang use the specified functions to init resource. Signed-off-by: Tonghao Zhang --- net/openvswitch/datapath.c | 60 +- 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/net/openvswitch/datapath.c

Re: [ovs-dev] [PATCH] netdev-afxdp: Fix umem creation failure due to uninitialized config.

2019-10-11 Thread Ilya Maximets
On 10.10.2019 20:21, William Tu wrote: On Wed, Oct 09, 2019 at 04:17:58PM +0200, Ilya Maximets wrote: Later version of 'struct xsk_umem_config' contains additional field 'flags'. OVS doesn't use that field passing uninitialized stack memory to the 'xsk_umem__create()' call that could fail with

Re: [ovs-dev] [PATCH] netdev-afxdp: Update memory locking limits unconditionally.

2019-10-11 Thread Ilya Maximets
On 10.10.2019 20:29, William Tu wrote: On Wed, Oct 09, 2019 at 04:23:31PM +0200, Ilya Maximets wrote: Any type of AF_XDP socket in all modes implies creation of BPF map of type BPF_MAP_TYPE_XSKMAP. This leads to BPF_MAP_CREATE syscall and subsequently 'xsk_map_alloc()' function that will

[ovs-dev] [PATCH net-next v3 02/10] net: openvswitch: convert mask list in mask array

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang Port the codes to linux upstream and with little changes. Pravin B Shelar, says: | mask caches index of mask in mask_list. On packet recv OVS | need to traverse mask-list to get cached mask. Therefore array | is better for retrieving cached mask. This also allows better |

[ovs-dev] [PATCH net-next v3 09/10] net: openvswitch: don't unlock mutex when changing the user_features fails

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang Unlocking of a not locked mutex is not allowed. Other kernel thread may be in critical section while we unlock it because of setting user_feature fail. Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index") Cc: Paul Blakey Signed-off-by: Tonghao Zhang

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-11 Thread Sriram Vatala via dev
Hi, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 09 October 2019 11:53 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' ; 'i.maxim...@ovn.org' Subject: RE: [PATCH v9 2/2]

[ovs-dev] [PATCH net-next v3 00/10] optimize openvswitch flow looking up

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang This series patch optimize openvswitch for performance or simplify codes. Patch 1, 2, 4: Port Pravin B Shelar patches to linux upstream with little changes. Patch 5, 6, 7: Optimize the flow looking up and simplify the flow hash. Patch 8, 9: are bugfix. The performance

[ovs-dev] [PATCH net-next v3 05/10] net: openvswitch: optimize flow-mask looking up

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang The full looking up on flow table traverses all mask array. If mask-array is too large, the number of invalid flow-mask increase, performance will be drop. This patch optimizes mask-array operation: * Inserting, insert it [ma->count- 1] directly. * Removing, only change

[ovs-dev] [PATCH net-next v3 03/10] net: openvswitch: shrink the mask array if necessary

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang When creating and inserting flow-mask, if there is no available flow-mask, we realloc the mask array. When removing flow-mask, if necessary, we shrink mask array. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 33 +++-- 1 file

[ovs-dev] [PATCH net-next v3 04/10] net: openvswitch: optimize flow mask cache hash collision

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang Port the codes to linux upstream and with little changes. Pravin B Shelar, says: | In case hash collision on mask cache, OVS does extra flow | lookup. Following patch avoid it. Link: https://github.com/openvswitch/ovs/commit/0e6efbe2712da03522532dc5e84806a96f6a0dd1

[ovs-dev] [PATCH net-next v3 06/10] net: openvswitch: simplify the flow_hash

2019-10-11 Thread xiangxia . m . yue
From: Tonghao Zhang Simplify the code and remove the unnecessary BUILD_BUG_ON. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c index

[ovs-dev] [PATCH] lib: packets: export compose_ipv6 routine to OVN

2019-10-11 Thread Lorenzo Bianconi
Remove static qualifier from compose_ipv6 definition and export it to OVN. compose_ipv6 will be used in order to add IPv6 prefix delegation support to OVN Signed-off-by: Lorenzo Bianconi --- lib/packets.c | 2 +- lib/packets.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git