Bleep bloop. Greetings , I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless (tests/automake.mk).
Repository lacks necessary blobs to fall
From: Bhargava Shastry
It appears that ossfuzz specific test harnesses and configuration files
were carried over to the ovn repo from the ovs repo without
justification. This patch removes them until there is a need to
continuously fuzz ovn code as the ovs code is currently fuzzed.
On Fri, Oct 18, 2019 at 3:53 AM Han Zhou wrote:
>
>
>
> On Thu, Oct 10, 2019 at 1:20 AM Dumitru Ceara wrote:
> >
> > Add new 'Copp' (Control plane protection) table to OVN Northbound DB:
> > - this stores mappings between control plane protocol names and meters
> > that should be used to rate
On 16.10.2019 19:48, Kevin Traynor wrote:
On 16/10/2019 13:16, Ilya Maximets wrote:
Hi Kevin,
Thanks for review. Some comments inline.
On 16.10.2019 12:15, Kevin Traynor wrote:
Hi Sriram,
Thanks for working on making more fine grained stats for debugging. As
mentioned yesterday, this patch
On Thu, Oct 17, 2019 at 01:32:27PM -0700, Gregory Rose wrote:
> On 10/9/2019 2:22 PM, Greg Rose wrote:
> > Pull in upstream kernel patches not related to conntrack and
> > add compatibility layer code where needed.
> >
> > The upstream conntrack related patches will come later from Yi-Hung.
> >
On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote:
>
>
> On 2019-10-16 2:40 PM, Simon Horman wrote:
> > On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote:
> >> From: Chris Mi
> >>
> >> Currently, ovs supports to offload max TCA_ACT_MAX_PRIO(32) actions.
> >> But net sched api
Are you planning on sending a v14?
Cheers,
Eelco
On 16 Sep 2019, at 16:12, Eelco Chaudron wrote:
Hi Anju,
For some reason, this version does not show up in patchwork! I have
two small comments below but other than that it looks fine to me.
If those two will be the only changes in your
From: Bhargava Shastry
Google's oss-fuzz builder bots were complaining that miniflow_target is
too slow to fuzz in that some tests take longer than a second to
complete. This patch fixes this by replacing the random flow generation
within the harness to a more simpler scenario.
Signed-off-by:
On 10/18/2019 7:23 AM, Simon Horman wrote:
On Thu, Oct 17, 2019 at 01:32:27PM -0700, Gregory Rose wrote:
Hello maintainers,
Yi-Hung has added his acks. Please consider applying these patches.
Thanks,
- Greg
Thanks Greg,
applied to master.
Thanks Simon!
On Thu, Oct 17, 2019 at 03:51:42PM +0200, Dumitru Ceara wrote:
> With the removal of the OVS subtree the vtep autotest stopped working
> because the vtep.ovsschema couldn't be found anymore. The failure was
> however hidden by the "|| return 1" when failing to create the vtep DB.
>
> Fix the path
On Fri, Oct 18, 2019 at 11:13:08AM +0200, bsh...@gmail.com wrote:
> From: Bhargava Shastry
>
> It appears that ossfuzz specific test harnesses and configuration files
> were carried over to the ovn repo from the ovs repo without
> justification. This patch removes them until there is a need to
>
This more-or-less gets pinctrl back to how it was prior to being made
multithreaded for OVS 2.11. Since pinctrl is in its own process, there's
no immediate need to have multiple threads.
Signed-off-by: Mark Michelson
---
controller/pinctrl.c | 736
Signed-off-by: Mark Michelson
---
pinctrl/ovn-pinctrl.8.xml | 77 ++-
1 file changed, 76 insertions(+), 1 deletion(-)
diff --git a/pinctrl/ovn-pinctrl.8.xml b/pinctrl/ovn-pinctrl.8.xml
index c0322cd4b..df8e717ca 100644
--- a/pinctrl/ovn-pinctrl.8.xml
Signed-off-by: Mark Michelson
---
Makefile.am | 1 +
controller/automake.mk| 34 --
pinctrl/automake.mk | 25 +
pinctrl/ovn-pinctrl.8.xml | 35
On Tue, Oct 15, 2019 at 10:27:41AM -0700, Yi-Hung Wei wrote:
> This series backports conntrack related patches from upstream kernel.
> It has been tested on
> * Ubuntu 14.04, 16.04, and 18.04.
> * RHEL 7.4-7.6.
> * 5.0 kernel.
>
> Travis test:
On Fri, Oct 18, 2019 at 10:57 PM Ben Pfaff wrote:
> On Thu, Oct 17, 2019 at 03:51:42PM +0200, Dumitru Ceara wrote:
> > With the removal of the OVS subtree the vtep autotest stopped working
> > because the vtep.ovsschema couldn't be found anymore. The failure was
> > however hidden by the "||
On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang wrote:
>
> On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote:
> >
> > On Wed, Oct 16, 2019 at 5:50 AM wrote:
> > >
> > > From: Tonghao Zhang
> > >
> > > When we destroy the flow tables which may contain the flow_mask,
> > > so release the flow
This is the right mailing list for now. The convention is to write
[PATCH ovn] in subject headings (but I figured it out ;-)
On Fri, Oct 18, 2019 at 04:48:40PM +0200, Bhargava Shastry wrote:
> Just want to add that the patch is to be applied to ovn source code, I
> couldn't find the ovn mailing
Acked-by: Mark Michelson
On 10/18/19 7:09 AM, Lorenzo Bianconi wrote:
Introduce the possibility to specify a RDNSS option to Router
Advertisement packets. DNS IPv6 address can be specified using
'rdnss' tag in the ipv6_ra_configs column of logical router
port table
Signed-off-by: Lorenzo
On Tue, Oct 15, 2019 at 10:41:23AM -0700, Yi-Hung Wei wrote:
> On Tue, Oct 15, 2019 at 10:18 AM Ben Pfaff wrote:
> >
> > On Mon, Oct 14, 2019 at 10:37:40AM -0700, Yi-Hung Wei wrote:
> > > This series backports conntrack related patches from upstream kernel.
> > > It has been tested on
> > > *
On Fri, Oct 18, 2019 at 05:17:34PM +0200, bsh...@gmail.com wrote:
> From: Bhargava Shastry
>
> Google's oss-fuzz builder bots were complaining that miniflow_target is
> too slow to fuzz in that some tests take longer than a second to
> complete. This patch fixes this by replacing the random flow
This is a minimum effort separation. The pinctrl.c file has not been
altered. A new ovn-pinctrl.c file starts an application that makes calls
to pinctrl as necessary.
To facilitate this change, a couple of extra modifications were made.
* binding_run() now has a do_bind boolean parameter. With
Most duplicate functions have been extracted to controller-utils.c.
Signed-off-by: Mark Michelson
---
controller/controller-utils.c | 166 ++
controller/ovn-controller.c | 171 +--
controller/ovn-controller.h | 20 +
This proposes a set of patches to move pinctrl operations out of the
ovn-controller process and into its own.
The main reasons for doing this are the following:
1) Separating pinctrl makes it so that receiving a packet-in can't wake
up ovn-controller.
2) Separating pinctrl allows for manipulating
On Wed, Oct 16, 2019 at 5:56 AM wrote:
>
> From: Tonghao Zhang
>
> Unlocking of a not locked mutex is not allowed.
> Other kernel thread may be in critical section while
> we unlock it because of setting user_feature fail.
>
> Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain
On Wed, Oct 16, 2019 at 5:51 AM wrote:
>
> From: Tonghao Zhang
>
> The idea of this optimization comes from a patch which
> is committed in 2014, openvswitch community. The author
> is Pravin B Shelar. In order to get high performance, I
> implement it again. Later patches will use it.
>
>
On Wed, Oct 16, 2019 at 5:55 AM wrote:
>
> From: Tonghao Zhang
>
> The most case *index < ma->max, and flow-mask is not NULL.
> We add un/likely for performance.
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> ---
LGTM
Acked-by: William Tu
> net/openvswitch/flow_table.c | 4 ++--
On Wed, Oct 16, 2019 at 5:56 AM wrote:
>
> From: Tonghao Zhang
>
> use the specified functions to init resource.
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> ---
Looks like this is simply moving code around.
I don't have any opinion.
> net/openvswitch/datapath.c | 60
>
On Fri, Oct 18, 2019 at 05:14:46PM +0200, Ilya Maximets wrote:
> On 26.09.2019 21:29, William Tu wrote:
> >The patch adds support for using need_wakeup flag in AF_XDP rings.
> >A new option, use_need_wakeup, is added. When this option is used,
> >it means that OVS has to explicitly wake up the
On Wed, Oct 16, 2019 at 5:52 AM wrote:
>
> From: Tonghao Zhang
>
> Port the codes to linux upstream and with little changes.
>
> Pravin B Shelar, says:
> | mask caches index of mask in mask_list. On packet recv OVS
> | need to traverse mask-list to get cached mask. Therefore array
> | is better
On Wed, Oct 16, 2019 at 5:54 AM wrote:
>
> From: Tonghao Zhang
>
> The full looking up on flow table traverses all mask array.
> If mask-array is too large, the number of invalid flow-mask
> increase, performance will be drop.
>
> One bad case, for example: M means flow-mask is valid and NULL
>
On Wed, Oct 16, 2019 at 5:54 AM wrote:
>
> From: Tonghao Zhang
>
> Simplify the code and remove the unnecessary BUILD_BUG_ON.
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> ---
LGTM
Acked-by: William Tu
> net/openvswitch/flow_table.c | 8 ++--
> 1 file changed, 2
On Wed, Oct 16, 2019 at 5:53 AM wrote:
>
> From: Tonghao Zhang
>
> When creating and inserting flow-mask, if there is no available
> flow-mask, we realloc the mask array. When removing flow-mask,
> if necessary, we shrink mask array.
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
>
On Thu, Oct 17, 2019 at 01:38:08PM -0700, Yi-Hung Wei wrote:
> On Thu, Oct 17, 2019 at 12:56 PM William Tu wrote:
> >
> > The patch add libunwind dev package to debian and rhel.
> >
> > Signed-off-by: William Tu
> > ---
>
> Looks good to me.
>
> Acked-by: Yi-Hung Wei
Applied to master,
34 matches
Mail list logo
