[ovs-dev] [PATCH ovn] pinctrl: Support DHCPRELEASE and DHCPINFORM in native OVN dhcp responder.

2020-06-01 Thread numans
From: Numan Siddique Right now we ignore these dhcp packets. This patch adds the support as per RFC 2131. Signed-off-by: Numan Siddique --- NEWS | 2 + controller/pinctrl.c | 125 ++- lib/ovn-l7.h | 12 + tests/ovn.at

Re: [ovs-dev] [PATCH V2 04/12] netdev-offload-dpdk: Support partial TCP/UDP port matching

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > The cited commit failed partial matching of TCP/UDP port matching, > preventing such offload of supporting HWs. Remove this failure. > > Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") > Signed-off-by: Eli

Re: [ovs-dev] [PATCH V2 03/12] netdev-offload-dpdk: Support offload of set IPv6 actions

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > Signed-off-by: Eli Britstein > Reviewed-by: Roni Bar Yanai > --- > Documentation/howto/dpdk.rst | 1 + > NEWS | 2 ++ > lib/netdev-offload-dpdk.c| 35 +++ > 3 files changed,

Re: [ovs-dev] [PATCH V2 09/12] dpif-netdev: Don't use zero flow mark

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > Zero flow mark is used to indicate the HW to remove the mark. A packet > marked with zero mark is received in SW without a mark at all, so it > cannot be used as a valid mark. Change the pool range to fix it. > > Fixes: 241bad15d99a

Re: [ovs-dev] Mobile Application to Manage your Sales Team

2020-06-01 Thread Aishwarya via dev
Hello, I am waiting for your reply to know if you had a time to go through my previous email, Once look in to our product. Let's schedule a 10 minutes call so that I can explain how we're working and tell you more details of Travelize features. Let me know your thoughts.

Re: [ovs-dev] [PATCH ovn] Remove python six library

2020-06-01 Thread Numan Siddique
On Mon, Jun 1, 2020 at 3:37 AM aginwala wrote: > Thanks for the improvement. > > Acked-by: Aliasgar Ginwala > Thanks Brian and Aliasgar (for the review). I applied this patch to master. Numan > > On Fri, May 29, 2020 at 2:13 PM Brian Haley wrote: > > > Since OVN is python3-only, there is

Re: [ovs-dev] [PATCH V2 01/12] netdev-offload-dpdk: Remove pre-validate of patterns function

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > The function of adding patterns by requested matches checks that it > consumed all the required matches, and err if not. This nullify the > purpose of the validation function. Future supported matches will only > change the pattern parsing

Re: [ovs-dev] [PATCH V2 02/12] netdev-offload-dpdk: Add IPv6 pattern matching

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > Add support for IPv6 pattern matching for offloading flows. > > Signed-off-by: Eli Britstein > Reviewed-by: Roni Bar Yanai > --- > Documentation/howto/dpdk.rst | 2 +- > NEWS | 1 + > lib/netdev-offload-dpdk.c

Re: [ovs-dev] [PATCH V2 07/12] netdev-offload-dpdk: Support offload of clone tnl_push/output actions

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > Signed-off-by: Eli Britstein > Reviewed-by: Oz Shlomo > --- Please add a brief description to the commit message. Thanks, -Harsha > Documentation/howto/dpdk.rst | 1 + > NEWS | 2 +- > lib/netdev-offload-dpdk.c

Re: [ovs-dev] [PATCH V2 08/12] netdev-offload-dpdk: Support tnl/push using vxlan encap attribute

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > For DPDK, there is the RAW_ENCAP attribute which gets raw buffer of the > encapsulation header. For specific protocol, such as vxlan, there is a > more specific attribute, VXLAN_ENCAP, which gets the parsed fields of > the outer header. In

Re: [ovs-dev] [PATCH V2 12/12] netdev-offload-dpdk: Fix Ethernet matching for type only

2020-06-01 Thread Sriharsha Basavapatna via dev
On Wed, May 27, 2020 at 9:31 PM Eli Britstein wrote: > > For OVS rule of the form "eth type is 0x1234 / end", rule is offloaded > in the form of "eth / end", which is incorrect. Fix it. > > Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") > Signed-off-by: Eli Britstein >

Re: [ovs-dev] [PATCH ovn] test: add more tests to IP-buffering unit-test

2020-06-01 Thread Ankur Sharma
Hi Lorenzo, Thanks a lot for the patch. I will get back on this by EOD PST tomorrow. Regards, Ankur From: Lorenzo Bianconi Sent: Friday, May 29, 2020 7:01 AM To: ovs-dev@openvswitch.org Cc: Ankur Sharma ; num...@ovn.org ; dce...@redhat.com Subject: [PATCH

Re: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

2020-06-01 Thread Yanqin Wei
Hi Haifeng, It looks indeed a risk for using ovs-rcu. A few comments inline. Best Regards, Wei Yanqin > -Original Message- > From: dev On Behalf Of Linhaifeng > Sent: Monday, June 1, 2020 11:13 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] ovs rcu: update rcu pointer first

[ovs-dev] [PATCH v4 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Currently, DHCP option is of type ipv4. But, according to RFC 2132, option 66 can be a hostname i.e, we should also accept string type. In order to be backward compatible, a new type called "host_id" is introduced, which accepts both ipv4 address and string. Type for DHCP

[ovs-dev] [PATCH v4 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith Signed-off-by: Ankur Sharma --- lib/actions.c | 100 +++- lib/ovn-l7.h| 3 ++

Re: [ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread svc . mail . git
Hi Numan, Thanks for reply. Sure, added Signed-off-by tag. Regards, Ankur From: Numan Siddique Sent: Monday, June 1, 2020 10:10 AM To: svc.mail.git Cc: ovs-dev ; Dhathri Purohith Subject: Re: [ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option

[ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Currently, DHCP option is of type ipv4. But, according to RFC 2132, option 66 can be a hostname i.e, we should also accept string type. In order to be backward compatible, a new type called "host_id" is introduced, which accepts both ipv4 address and string. Type for DHCP

[ovs-dev] [PATCH v3 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-01 Thread Ankur Sharma
From: Dhathri Purohith Domain search list is encoded according to the specifications in RFC 1035, section 4.1.4. Signed-off-by: Dhathri Purohith --- lib/actions.c | 100 +++- lib/ovn-l7.h| 3 ++ northd/ovn-northd.c | 1 +

Re: [ovs-dev] [PATCH ovs] doc: Fix a typo in ovs-actions man page.

2020-06-01 Thread William Tu
On Fri, May 29, 2020 at 2:39 AM wrote: > > From: Numan Siddique > > Signed-off-by: Numan Siddique > --- Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC v3 PATCH 3/5] dpif-netdev: Skip encap action during datapath execution

2020-06-01 Thread Eli Britstein
On 5/28/2020 11:19 AM, Sriharsha Basavapatna wrote: In this patch we check if action processing (apart from OUTPUT action), should be skipped for a given dp_netdev_flow. Specifically, we check if the action is TNL_PUSH and if it has been offloaded to HW, then we do not push the tunnel header

Re: [ovs-dev] [RFC v3 PATCH 3/5] dpif-netdev: Skip encap action during datapath execution

2020-06-01 Thread Sriharsha Basavapatna via dev
On Mon, Jun 1, 2020 at 9:18 PM Eli Britstein wrote: > > > On 6/1/2020 6:15 PM, Sriharsha Basavapatna wrote: > > On Mon, Jun 1, 2020 at 7:58 PM Eli Britstein wrote: > >> > >> On 5/28/2020 11:19 AM, Sriharsha Basavapatna wrote: > >>> In this patch we check if action processing (apart from OUTPUT

Re: [ovs-dev] [PATCH V2 00/12] netdev datapath offload: Support IPv6 and VXLAN encap

2020-06-01 Thread Sriharsha Basavapatna via dev
Hi Eli, I've reviewed and responded with 'acked-by' for patches #1 - #4, #8, #9, #12. I have a minor comment on patch #7, otherwise it looks good to me. For patches #5, #6, #10, #11, though I'm ok with the changes, I'd prefer to have someone more familiar with those areas review the patches and

Re: [ovs-dev] [RFC v3 PATCH 3/5] dpif-netdev: Skip encap action during datapath execution

2020-06-01 Thread Eli Britstein
On 6/1/2020 6:15 PM, Sriharsha Basavapatna wrote: On Mon, Jun 1, 2020 at 7:58 PM Eli Britstein wrote: On 5/28/2020 11:19 AM, Sriharsha Basavapatna wrote: In this patch we check if action processing (apart from OUTPUT action), should be skipped for a given dp_netdev_flow. Specifically, we

Re: [ovs-dev] [RFC v3 PATCH 5/5] dpif-netdev: Support partial-action-offload of VXLAN encap flow

2020-06-01 Thread Eli Britstein
On 5/28/2020 11:19 AM, Sriharsha Basavapatna wrote: In this patch, we support offloading of VXLAN_ENCAP action for a vhost-user port (aka "partial-action-offload"). At the time of offloading the flow, we determine if the flow can be offloaded to an egress device, if the input port is not

Re: [ovs-dev] [PATCH v2] netdev-offload-dpdk: Support offload of VLAN PUSH/POP actions

2020-06-01 Thread Eli Britstein
Acked-by: Eli Britstein On 5/29/2020 9:33 AM, Sriharsha Basavapatna wrote: Parse VLAN PUSH/POP OVS datapath actions and add respective RTE actions. Signed-off-by: Sriharsha Basavapatna --- v1->v2: * Updated dump_flow_action() to print VLAN Push/Pop actions * Updated NEWS,

Re: [ovs-dev] [RFC v3 PATCH 3/5] dpif-netdev: Skip encap action during datapath execution

2020-06-01 Thread Sriharsha Basavapatna via dev
On Mon, Jun 1, 2020 at 7:58 PM Eli Britstein wrote: > > > On 5/28/2020 11:19 AM, Sriharsha Basavapatna wrote: > > In this patch we check if action processing (apart from OUTPUT action), > > should be skipped for a given dp_netdev_flow. Specifically, we check if > > the action is TNL_PUSH and if

Re: [ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread Numan Siddique
On Mon, Jun 1, 2020 at 10:38 PM Ankur Sharma wrote: > From: Dhathri Purohith > > Currently, DHCP option is of type ipv4. But, according to RFC 2132, > option 66 can be a hostname i.e, we should also accept string type. > In order to be backward compatible, a new type called "host_id" is >

Re: [ovs-dev] Business Update/ Alexander Milner.

2020-06-01 Thread Mr Alexander milner
-- -- Hello Sir, I am aware that this letter has come to you as a surprise as we have not met before or handled any business deal in the past.Nevertheless,I have contacted you with genuine intentions and I hope I can trust you with this Inheritance opportunity which I explain below.My name is

[ovs-dev] [PATCH 1/2] netdev-offload: Implement terse dump support

2020-06-01 Thread Roi Dayan
From: Vlad Buslov In order to improve revalidator performance by minimizing unnecessary copying of data, extend netdev-offloads to support terse dump mode. Extend netdev_flow_api->flow_dump_create() with 'terse' bool argument. Implement support for terse dump in functions that convert netlink to

[ovs-dev] [PATCH 2/2] tc: Support new terse dump kernel API

2020-06-01 Thread Roi Dayan
From: Vlad Buslov When dumping flows in terse mode set TCA_DUMP_FLAGS attribute to TCA_DUMP_FLAGS_TERSE flag to prevent unnecessary copying of data between kernel and user spaces. Only expect kernel to provide cookie, stats and flags when dumping filters in terse mode. Signed-off-by: Vlad

[ovs-dev] [PATCH 0/2] Implement terse dump for netdev-offload

2020-06-01 Thread Roi Dayan
In order to improve revalidator performance, extend netdev-offload with terse dump support. In terse dump mode modify code that parses netlink to flower and flower to match to only provide the essential data for conversion instead of parsing all filter and actions data. Implement support for new

Re: [ovs-dev] [PATCH 2/2] tc: Support new terse dump kernel API

2020-06-01 Thread Roi Dayan
On 2020-06-01 3:54 PM, Roi Dayan wrote: > From: Vlad Buslov > > When dumping flows in terse mode set TCA_DUMP_FLAGS attribute to > TCA_DUMP_FLAGS_TERSE flag to prevent unnecessary copying of data between > kernel and user spaces. Only expect kernel to provide cookie, stats and > flags when

Re: [ovs-dev] [PATCH 1/2] netdev-offload: Implement terse dump support

2020-06-01 Thread Roi Dayan
On 2020-06-01 3:54 PM, Roi Dayan wrote: > From: Vlad Buslov > > In order to improve revalidator performance by minimizing unnecessary > copying of data, extend netdev-offloads to support terse dump mode. Extend > netdev_flow_api->flow_dump_create() with 'terse' bool argument. Implement >

Re: [ovs-dev] [PATCH] ovsdb: Fix timeout type for wait operation.

2020-06-01 Thread Ilya Maximets
On 5/29/20 8:27 AM, Numan Siddique wrote: > > > On Thu, May 28, 2020 at 11:37 PM Han Zhou > wrote: > > On Mon, May 25, 2020 at 10:07 AM Ilya Maximets > wrote: > > > > According to RFC 7047, 'timeout' is an integer field: > > >

[ovs-dev] [PATCH v1] Enable VXLAN TSO for DPDK datapath

2020-06-01 Thread yang_y_yi
From: Yi Yang Many NICs can support VXLAN TSO which can help improve across-compute-node VM-to-VM performance in case that MTU is set to 1500. This patch allows dpdkvhostuserclient interface and veth/tap interface to leverage NICs' offload capability to maximize across-compute-node TCP

Re: [ovs-dev] [PATCH 1/2] netdev-offload: Implement terse dump support

2020-06-01 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #252 FILE:

Re: [ovs-dev] [PATCH v4 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread 0-day Robot
Bleep bloop. Greetings svc.mail.git, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH 2/2] tc: Support new terse dump kernel API

2020-06-01 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 86 characters long (recommended limit is 79) #146 FILE: lib/tc.c:1728:

[ovs-dev] 10-25 packet drops every few (10-50) seconds TCP (iperf3)

2020-06-01 Thread Shahaji Bhosle via dev
Hi Ben/Ilya, Hope you guys are doing well and staying safe. I have been chasing a weird problem with small drops and I think that is causing lots of TCP retransmission. Setup details iPerf3(1k-5K Servers)<--DPDK2:OvS+DPDK(VxLAN:BOND)[DPDK0+DPDK1)<2x25G<

Re: [ovs-dev] [PATCH v1] Enable VXLAN TSO for DPDK datapath

2020-06-01 Thread 0-day Robot
Bleep bloop. Greetings yang_y_yi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement ERROR: C99 style comment #215 FILE:

Re: [ovs-dev] [PATCH v4 2/2 ovn] Add support for DHCP domain search option (119)

2020-06-01 Thread 0-day Robot
Bleep bloop. Greetings svc.mail.git, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] Automatizar y optimizar el trabajo en Excel

2020-06-01 Thread Excel: Fórmulas y funciones.
Buenos día Quise aprovechar la oportunidad de hacerte una invitación para tomar nuestro curso de 9 horas en 3 sesiones de 3 Horas : Nombre: Excel: Fórmulas y funciones. Fechas y horas: Sábado 20 de junio - Sábado 27 de junio y Sábado 4 de julio Formato: En línea con interacción en vivo.

Re: [ovs-dev] Android Application to Manage your Employees

2020-06-01 Thread Richard
Hello, I am waiting for your reply to know if you had a time to go through my previous email, Once look in to our product. Let's schedule a 10 minutes call so that I can explain how we're working and tell you more details of Travelize features. Let me know your thoughts.