Re: [ovs-dev] [PATCH v4] conntrack: document all-zero IP SNAT behavior and add a test case

On 3 Jun 2021, at 15:27, Ilya Maximets wrote: > On 6/3/21 2:38 PM, Aaron Conole wrote: >> Eelco Chaudron writes: >> >>> On 2 Jun 2021, at 18:21, Aaron Conole wrote: >>> Eelco Chaudron writes: > Currently, conntrack in the kernel has an undocumented feature referred > to as al

[ovs-dev] [PATCH v5] conntrack: document all-zero IP SNAT behavior and add a test case

Currently, conntrack in the kernel has an undocumented feature referred to as all-zero IP address SNAT. Basically, when a source port collision is detected during the commit, the source port will be translated to an ephemeral port. If there is no collision, no SNAT is performed. This patchset docu

Re: [ovs-dev] [PATCH v5] conntrack: document all-zero IP SNAT behavior and add a test case

Acked-by: Alin-Gabriel Serdean On Thu, 2021-06-10 at 11:24 +0200, Eelco Chaudron wrote: > Currently, conntrack in the kernel has an undocumented feature > referred > to as all-zero IP address SNAT. Basically, when a source port > collision is detected during the commit, the source port will be >

[ovs-dev] [PATCH v5] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3 side. For L2 side, there is only fdb show command. This patch gives an option to add/del an fdb entry via ovs-appctl. CLI command looks like: To add: ovs-appctl fdb/add ovs-appctl fdb/add br0 p1 0 50:54:00

Re: [ovs-dev] [PATCH v4] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Hi Eelco, I addressed your comments and also added a counter to track number of static entries in the switch. Here is the new Patch v5 . Please take a look. Thanks -Vasu *Vasu Dasari* On Wed, May 26, 2021 at 4:52 AM Eelco C

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix the database update signaling if it has never been connected.

On 6/8/21 3:17 PM, Ilya Maximets wrote: > The symptom of this issue is that OVS bridge looses its IP address on > restart. > > Simple reproducer: > 0. start ovsdb-server and ovs-vswitchd > 1. ovs-vsctl add-br br0 > 2. ifconfig br0 10.0.0.1 up > 3. ovs-appctl -t ovs-vswitchd exit > 4. start ov

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

On 6/10/21 8:36 AM, Han Zhou wrote: > > > On Thu, May 13, 2021 at 9:25 AM Frode Nordahl > wrote: >> >> On Thu, May 13, 2021 at 5:12 PM Ilya Maximets > > wrote: >> > >> > On 5/9/21 4:03 PM, Frode Nordahl wrote: >> > > Introduce pluggi

[ovs-dev] [PATCH v2 ovn 0/3] Optimize load balancer IP config parsing.

This is a new version of the single-patch v1 previously posted at: http://patchwork.ozlabs.org/project/ovn/patch/20210601170320.30490-1-dce...@redhat.com/ V2: - Turned this into a series. - Added patch 1/3 that removes some unused fields in ovn-northd load balancer structures, saving a tiny amou

[ovs-dev] [PATCH ovn v2 1/3] lb: Remove hairpin_snat_ips from northd load balancers.

The parsed values are not used anywhere so we might as well avoid parsing them. Fixes: cc4d5520064f ("Support configuring Load Balancer hairpin source IP.") Signed-off-by: Dumitru Ceara --- lib/lb.c |4 lib/lb.h |5 - 2 files changed, 9 deletions(-) diff --git a/lib/lb.c b/lib/

[ovs-dev] [PATCH ovn v2 2/3] northd: Consolidate load balancer healthcheck/svc code.

Part of the load balancer healthcheck/svc configuration parsing was done in ovn-northd.c and part in lib/lb.c. Consolidate this in ovn-northd.c. As a side effect this will remove dependency on the 'ports' hmap in lib/lb.c. This enables future commits to optimize load balancer configuration parsi

[ovs-dev] [PATCH ovn v2 3/3] northd: Precompute load balancer IP sets.

There's no need to parse the IP sets every time we iterate through them. It's enough to parse them once for every main loop iteration. Reported-at: https://bugzilla.redhat.com/1962338 Signed-off-by: Dumitru Ceara --- lib/lb.c|9 +++ lib/lb.h|4 + northd/ovn-northd

Re: [ovs-dev] [PATCH ovn] northd: Precompute load balancer IP sets.

On 6/1/21 7:03 PM, Dumitru Ceara wrote: > There's no need to parse the IP sets every time we iterate through them. > It's enough to parse them once for every main loop iteration. > > Reported-at: https://bugzilla.redhat.com/1962338 > Signed-off-by: Dumitru Ceara > --- Please ignore this version;

Re: [ovs-dev] [PATCH] dpif-netdev: Report overhead busy cycles per pmd.

Hi David, David Marchand writes: > When setting PMD auto load balance parameters and observing the > feature (and the per rxq statistics) in action, you can easily get > rebalances while the sum of per rxq pmd usage is below the pmd load > threshold you had set. > > This is because the dpif-netd

Re: [ovs-dev] [PATCH] dpif-netdev: Report overhead busy cycles per pmd.

On Thu, Jun 10, 2021 at 3:37 PM Aaron Conole wrote: > > Hi David, > > David Marchand writes: > > > When setting PMD auto load balance parameters and observing the > > feature (and the per rxq statistics) in action, you can easily get > > rebalances while the sum of per rxq pmd usage is below the

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

On Thu, Jun 10, 2021 at 1:46 PM Ilya Maximets wrote: > > On 6/10/21 8:36 AM, Han Zhou wrote: > > > > > > On Thu, May 13, 2021 at 9:25 AM Frode Nordahl > > wrote: > >> > >> On Thu, May 13, 2021 at 5:12 PM Ilya Maximets >> > wrote: > >

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 19 May 2021 16:54 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header > fil

Re: [ovs-dev] [v12 02/16] dpif-netdev: Split HWOL out to own header file.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:58 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org; Gaetan Rivet ; el...@nvidia.com > Subject: RE: [ovs-dev] [v12

Re: [ovs-dev] [v12 03/16] dpif-netdev: Add function pointer for netdev input.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:58 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 03/16] dpif-netdev: Add function

Re: [ovs-dev] [v12 04/16] dpif-avx512: Add ISA implementation of dpif.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:59 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 04/16] dpif-avx512: Add ISA impl

Re: [ovs-dev] [v12 05/16] dpif-avx512: Add HWOL support to avx512 dpif.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:59 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Finn, > Emma ; Van Haaren, Harry > > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 05/16] dpif-avx51

Re: [ovs-dev] [v12 06/16] dpif-netdev: Add command to switch dpif implementation.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 18:16 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 06/16] dpif-netdev: Add comman

Re: [ovs-dev] [v12 09/16] docs/dpdk/bridge: Add dpif performance section.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 19:41 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 09/16] docs/dpdk/bridge: Add d

Re: [ovs-dev] [v12 08/16] dpif-netdev: Add a partial HWOL PMD statistic.

Hi Ian, Thanks for the review. My responses are inline. Also, one thing I spotted while looking at your later reviews was that we should update the "lib/dpif-netdev-unixctl.man" file since it prints an example of the PMD statistics. I'll fix that in the next version. > -Original Message---

Re: [ovs-dev] [v12 10/16] dpif-netdev/dpcls: Refactor function names to dpcls.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 19:56 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 10/16] dpif-netdev/dpcls: Refa

Re: [ovs-dev] [v12 12/16] dpif-netdev/dpcls: Specialize more subtable signatures.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 20:08 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 12/16] dpif-netdev/dpcls: Spec

Re: [ovs-dev] [v12 13/16] dpdk: Cache result of CPU ISA checks.

Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 9 June 2021 16:23 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 13/16] dpdk: Cache result of C

[ovs-dev] [PATCH ovn v2 0/2] ovn-trace: correctly handle ct_dnat(IP) action

Mark Gray (2): ovn-trace.at: Move ovn-trace tests to new ovn-trace.at file ovn-trace: correctly handle ct_dnat(IP) action tests/automake.mk | 3 +- tests/ovn-trace.at| 350 ++ tests/testsuite.at| 1 + utilities/ovn-trace.c | 10 ++ 4

[ovs-dev] [PATCH ovn v2 1/2] ovn-trace.at: Move ovn-trace tests to new ovn-trace.at file

Signed-off-by: Mark Gray --- v2: Move ovn-trace tests to dedicated file tests/automake.mk | 3 +- tests/ovn-trace.at | 272 + tests/testsuite.at | 1 + 3 files changed, 275 insertions(+), 1 deletion(-) create mode 100644 tests/ovn-trace.at diff

[ovs-dev] [PATCH ovn v2 2/2] ovn-trace: correctly handle ct_dnat(IP) action

ovn-trace does not set translated ip address for ct_dnat() actions when tracing. This causes the trace to end prematurely. This can be tested with the following or an equivalent for IPv6: ovn-nbctl ls-add sw0 ovn-nbctl lsp-add sw0 sw0-port1 ovn-nbctl lsp-set-addresses sw0-port1 "50:54:00:00:00:01

Re: [ovs-dev] [PATCH ovn] ovn-trace: correctly handle ct_dnat(IP) action

On 07/06/2021 10:58, Dumitru Ceara wrote: > On 6/4/21 7:06 PM, Mark Gray wrote: >> ovn-trace does not set translated ip address for ct_dnat() >> actions when tracing. This causes the trace to end prematurely. > > Hi Mark, > > Thanks for the patch! Thanks for the review. New series is at https://

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

On 5/28/21 10:21 AM, Vladislav Odintsov wrote: > Before this patch ovn-controller-vtep created Mcast_Macs_Remote > record for each Port Binding in the ovn Logical Switch, to which > vtep Logical Switch was attached. > With this patch there is only one Mcast_Macs_Remote record per datapath. > Physic

Re: [ovs-dev] [PATCH ovn v2 5/5] ovn-controller: Handle DNAT/no-NAT conntrack tuple collisions.

On 09/06/2021 13:12, Dumitru Ceara wrote: > Assuming a load balancer, LB1, with: > - VIP: 42.42.42.42:4242 > - backend: 42.42.42.1:2121 > > A client might connect to the backend either directly or through the > VIP. If the first connection is via the VIP and the second connection > is direct but

Re: [ovs-dev] [PATCH ovn v2 2/5] system-ovn.at: Use ADD_BR macro instead of bare ovs-vsctl.

On 09/06/2021 13:11, Dumitru Ceara wrote: > br-int and br-ex are patched together by ovn-controller. They must have > the same datapath type. I.e., it won't work if br-int uses the netdev > (userspace) datapath and br-ext uses the system (kernel) datapath; > system is the default. This ensures t

Re: [ovs-dev] [PATCH ovn v2 3/5] github: Use nmap-ncat instead of netcat-openbsd.

On 09/06/2021 13:12, Dumitru Ceara wrote: > There are some bugs in the netcat-openbsd version shipped with Ubuntu > 20.04. Switch to nmap-ncat to avoid system tests that will be added > by upcoming commits fail in CI. > > One example: > > 1. Start a TCP connection from IP1:port-x to IP2:port-y.

Re: [ovs-dev] [PATCH ovn v2 4/5] ovn-controller: Detect OVS datapath capabilities.

On 09/06/2021 13:12, Dumitru Ceara wrote: > Automatically create an OVS Datapath record if none exists for the > current br-int datapath type. > > Add a 'features' module to track which OVS features are available in > the datapath currently being used. For now, only ct_zero_snat is > tracked, all

Re: [ovs-dev] [PATCH] ofproto/trace: Support for DP-HASH recirculation

On Thu, Jul 23, 2020 at 03:15:26PM +0530, Surya Rudra via dev wrote: > Issue: > Current OVS implementation, recirculation information > is not displayed in ofproto trace command if it happens > for dp-hash calculation. > > Fix: > Updated ofproto/trace implementation to support dp-hash > recirculat

Re: [ovs-dev] [PATCH v2 1/2] Remove Python 2 leftovers.

On Wed, 9 Jun 2021 17:25:45 -0400 Rosemarie O'Riorden wrote: > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") > Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 > Signed-off-by: Rosemarie O'Riorden > --- > Fix import errors in v1. > Remove lines that i

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

Hi Dumitru, First of all, thanks for the review. My comments are inline. Regards, Vladislav Odintsov > On 10 Jun 2021, at 18:50, Dumitru Ceara wrote: > > On 5/28/21 10:21 AM, Vladislav Odintsov wrote: >> Before this patch ovn-controller-vtep created Mcast_Macs_Remote >> record for each Port Bi

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

On 6/10/21 7:57 PM, Vladislav Odintsov wrote: [...] >>> >>> @@ -231,13 +239,19 @@ vtep_lswitch_run(struct shash *vtep_pbs, struct sset >>> *vtep_pswitches, >>> VLOG_DBG("set vtep logical switch (%s) tunnel key from " >>> "(%"PRId64") to (%"PRId64")", vtep

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port-group incremental processing.

Looks good to me, thanks Han! Acked-by: Mark Michelson On 6/2/21 3:07 AM, Han Zhou wrote: When SB port-group (per DP) is deleted and added back and the notification to ovn-controller include both operations in a reversed order, the current change handler in ovn-controller would end up deleting

Re: [ovs-dev] [PATCH ovn v2 5/5] ovn-controller: Handle DNAT/no-NAT conntrack tuple collisions.

On 6/10/21 6:26 PM, Mark Gray wrote: > On 09/06/2021 13:12, Dumitru Ceara wrote: >> Assuming a load balancer, LB1, with: >> - VIP: 42.42.42.42:4242 >> - backend: 42.42.42.1:2121 >> >> A client might connect to the backend either directly or through the >> VIP. If the first connection is via the VI

Re: [ovs-dev] [v12 11/16] dpif-netdev/dpcls-avx512: Enable 16 block processing.

> -Original Message- > From: Stokes, Ian > Sent: Wednesday, June 9, 2021 1:03 PM > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 11/16] dpif-netdev/dpcls-avx512: Enable 16 block > processing. > > The code has been

Re: [ovs-dev] [v12 14/16] dpcls-avx512: Enable avx512 vector popcount instruction.

> -Original Message- > From: Stokes, Ian > Sent: Wednesday, June 9, 2021 4:56 PM > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 14/16] dpcls-avx512: Enable avx512 vector popcount > instruction. > > > This commit

Re: [ovs-dev] [PATCH ovn v9 0/5] ovn-controller: Split logical flow and physical flow processing

Hi Numan, For patches 2-5, Acked-by: Mark Michelson For patch 1, it all looks understandable to me, but I will defer to Han for an authoritative ACK. I'll still give my provisional: Acked-by: Mark Michelson On 6/3/21 8:27 AM, num...@ovn.org wrote: From: Numan Siddique This series splits

[ovs-dev] [PATCH] Add missing argument in function call.

This syntax error caused the script to crash. With the use of the correct argument in the function call, it runs and prints what is expected. Signed-off-by: Rosemarie O'Riorden --- ofproto/ipfix-gen-entities | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ipfix-gen-en

Re: [ovs-dev] [PATCH] Add missing argument in function call.

On Thu, Jun 10, 2021 at 05:12:41PM -0400, Rosemarie O'Riorden wrote: > This syntax error caused the script to crash. With the use of the > correct argument in the function call, it runs and prints what is > expected. > > Signed-off-by: Rosemarie O'Riorden Thanks, applied to master. _

Re: [ovs-dev] [PATCH ovn v2 1/2] ovn-trace.at: Move ovn-trace tests to new ovn-trace.at file

On Thu, Jun 10, 2021 at 11:32:00AM -0400, Mark Gray wrote: > Signed-off-by: Mark Gray > --- > v2: Move ovn-trace tests to dedicated file There are lots of tests that use ovn-trace. They use it to test OVN, primarily, not to test ovn-trace, although the latter is a nice side effect. I don't thin

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

Oh, I didn’t think about this case. I’ll address this too. A small question. After patch would be accepted I’d like to send backport bugfix patch down to supported branches. Is it better to use old-style AT_CHECK in tests to cleanly apply this patch to branches without `check` support? Or in maste

Re: [ovs-dev] [PATCH] ofp-monitor: Extend Flow Monitoring support for OF 1.0+ with Nicira Extensions

You can apply a patch like this to get it to log hex: diff --git a/lib/vconn.c b/lib/vconn.c index 7415e6291f6f..c626c35f9792 100644 --- a/lib/vconn.c +++ b/lib/vconn.c @@ -685,7 +685,7 @@ do_send(struct vconn *vconn, struct ofpbuf *msg) COVERAGE_INC(vconn_sent); retval = (vconn-

Re: [ovs-dev] [PATCH v2 2/2] AUTHORS: Add Rosemarie O'Riorden.

On Wed, Jun 09, 2021 at 05:25:46PM -0400, Rosemarie O'Riorden wrote: > Signed-off-by: Rosemarie O'Riorden I just applied a similar patch after applying your fix for ipfix-gen-entities, so this one shouldn't be needed. ___ dev mailing list d...@openvswit

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

On Fri, Jun 11, 2021 at 12:28:47AM +0300, Vladislav Odintsov wrote: > After patch would be accepted I’d like to send backport bugfix patch down to > supported branches. Is it better to use old-style AT_CHECK in tests to cleanly > apply this patch to branches without `check` support? Or in master br

Re: [ovs-dev] [PATCH] ovsdb: provide raft and command interfaces with priority

On Tue, Jun 08, 2021 at 10:27:08AM +0100, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > Set a soft time limit of "raft election timer"/2 on ovsdb > processing. > > This improves behaviour in large heavily loaded clusters. > While it cannot fully eliminate spurious raft election

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

On 6/10/21 11:47 PM, Ben Pfaff wrote: > On Fri, Jun 11, 2021 at 12:28:47AM +0300, Vladislav Odintsov wrote: >> After patch would be accepted I’d like to send backport bugfix patch down to >> supported branches. Is it better to use old-style AT_CHECK in tests to >> cleanly >> apply this patch to br

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

On Fri, Jun 11, 2021 at 12:13:46AM +0200, Dumitru Ceara wrote: > On 6/10/21 11:47 PM, Ben Pfaff wrote: > > On Fri, Jun 11, 2021 at 12:28:47AM +0300, Vladislav Odintsov wrote: > >> After patch would be accepted I’d like to send backport bugfix patch down > >> to > >> supported branches. Is it bette

Re: [ovs-dev] [PATCH ovn 1/2] tests: Add debugging 4 HV, 3LS, 2 LR test.

On Mon, Jun 07, 2021 at 08:49:58AM -0400, Mark Michelson wrote: > Add some checking to "4 HV, 3 LS, 2 LR, packet test with HA distributed > router gateway port". > > Signed-off-by: Mark Michelson Assuming the test passes: Acked-by: Ben Pfaff ___ dev

[ovs-dev] [PATCH 1/2] fail-open: Only fail open if we've been disconnected for at least 1 s.

The 'last_disconn_secs' member determines whether we're currently in fail-open mode (see fail_open_is_active()), but before this commit, fail_open_run() could decide to enter fail-open mode even if that would set 'last_disconn_secs' to 0 (and thus not really enter it). This could lead to an endless

[ovs-dev] [PATCH 2/2] bridge: Only an inactivity_probe of 0 should turn off inactivity probes.

The documentation for inactivity_probe says this: inactivity_probe: optional integer Maximum number of milliseconds of idle time on connec‐ tion to controller before sending an inactivity probe message. If Open vSwitch does not communicate wi

Re: [ovs-dev] [PATCH] ofp-monitor: Extend Flow Monitoring support for OF 1.0+ with Nicira Extensions

Thanks Ben. Will try this out. -Vasu *Vasu Dasari* On Thu, Jun 10, 2021 at 5:32 PM Ben Pfaff wrote: > You can apply a patch like this to get it to log hex: > > diff --git a/lib/vconn.c b/lib/vconn.c > index 7415e6291f6f..c626c35f9792 100644 > --- a/lib/vconn.c > +++ b/lib/vconn.c > @@ -685,7

Re: [ovs-dev] [PATCH ovn 2/2] tests: Fix consistency of 4 HV, 3LS, 2 LR test runs.

On Mon, Jun 07, 2021 at 08:49:59AM -0400, Mark Michelson wrote: > Much like the 4 HV, 1 LS, 1 LR test, this one was also having issues > where the pcap file would not be reset before attempting to capture > packets. Therefore, the pcap file would be reset after having captured > packets we were exp

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Improve concurrency by adjust flow-limit

On Wed, May 26, 2021 at 10:44:16AM +0800, Tao YunXiang wrote: > +/* Use duration as a reference, adjust the value of flow_limit, > + * when the duration is short, increase the flow_limit, and vice > + * versa. The purpose of using multiple conversions between int

Re: [ovs-dev] [PATCH] system-traffic.at:add missing comma

On Wed, May 26, 2021 at 10:53:45AM +0800, Tao YunXiang wrote: > Add missing comma. > > Signed-off-by: Tao YunXiang > Cc: Joe Stringer Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ov

Re: [ovs-dev] [PATCH 1/2] bond: Fix broken rebalancing after link state changes.

On Mon, Jun 07, 2021 at 01:01:33PM +0200, Ilya Maximets wrote: > On 8/2/17 11:09 PM, Andy Zhou wrote: > > On Thu, Jul 20, 2017 at 10:21 AM, Ilya Maximets > > wrote: > >> There are 3 constraints for moving hashes from one slave to another: > >> > >> 1. The load difference is larger than ~3

Re: [ovs-dev] [PATCH ovn] ovn-northd-ddlog: Fix memleak when destroying context.

On Fri, Jun 04, 2021 at 06:48:13PM +0200, Dumitru Ceara wrote: > This is benign but AddressSanitizer was complaining about it: > > Direct leak of 40 byte(s) in 1 object(s) allocated from: > #0 0x7fa93cd6d667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667) > #1 0x1be8d3e in xmalloc__

Re: [ovs-dev] Integrating p4rt-ovs to ovs-afxdp

On Mon, May 31, 2021 at 10:37:09AM +0200, Mah-Rukh Fida wrote: > Hi, > > I am a postdoctoral fellow at Simula, Oslo. For one of my project I have to > run a p4 program on openvswitch, I am using ovs-afxdp and p4rt-ovs > following the links below > > https://github.com/Orange-OpenSource/p4rt-ovs >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port-group incremental processing.

On Thu, Jun 10, 2021 at 12:12 PM Mark Michelson wrote: > > Looks good to me, thanks Han! > > Acked-by: Mark Michelson > Thanks Mark! I applied it to master, branch-21.06 and 21.03. > On 6/2/21 3:07 AM, Han Zhou wrote: > > When SB port-group (per DP) is deleted and added back and the > > notific

Re: [ovs-dev] [PATCH v2] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.3 with Nicira Extensions

On Fri, May 14, 2021 at 04:15:25PM -0400, Vasu Dasari wrote: > Currently OVS supports flow-monitoring for OpenFlow 1.0 and Nicira > Extenstions. > Any other OpenFlow versioned messages are not accepted. This checkin will > allow > OpenFlow1.0-1.3 Flow Monitoring wth Nicira extensions be accepted.

Re: [ovs-dev] [PATCH 7/7] python: idl: Allow retry even when using a single remote.

On 5/10/21 2:34 PM, Dumitru Ceara wrote: > On 5/1/21 2:55 AM, Ilya Maximets wrote: >> As described in commit [1], it's possible that remote IP is backed by >> a load-balancer and re-connection to this same IP will lead to >> connection to a different server. This case is supported for C version >>

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix the database update signaling if it has never been connected.

On 6/10/21 1:21 PM, Dumitru Ceara wrote: > On 6/8/21 3:17 PM, Ilya Maximets wrote: >> The symptom of this issue is that OVS bridge looses its IP address on >> restart. >> >> Simple reproducer: >> 0. start ovsdb-server and ovs-vswitchd >> 1. ovs-vsctl add-br br0 >> 2. ifconfig br0 10.0.0.1 up >>

Re: [ovs-dev] [PATCH] ovsdb: provide raft and command interfaces with priority

On 10/06/2021 23:01, Ben Pfaff wrote: On Tue, Jun 08, 2021 at 10:27:08AM +0100, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Set a soft time limit of "raft election timer"/2 on ovsdb processing. This improves behaviour in large heavily loaded clusters. While it cannot fully elimi

[ovs-dev] [PATCH ovn 2/4] ovn.at: Fix test "nb_cfg timestamp -- ovn-northd-ddlog".

The test case fails quite often because of timing. When nb_cfg_timestamp is updated in SB DB it may not be updated immediately in NB's hv_cfg_timestamp. This patch use "wait_column" to wait. Signed-off-by: Han Zhou --- tests/ovn.at | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

[ovs-dev] [PATCH ovn 3/4] ovn.at: Fix test "No ovn-controller assert when generating conjunction flows -- ovn-northd-ddlog".

The test fails quite often for ddlog because of tunnel keys mismatch when checking OpenFlow dumps. It is possible to allocate different keys in different runs because multiple NB changes can be handled by northd in a single iteration - it fails more often in ddlog probably because there is some mor

[ovs-dev] [PATCH ovn 1/4] ovn-northd.at: Fix test "northd ssl file change -- ovn-northd-ddlog".

This test fails for ovn-northd-ddlog because of the RBAC role when using the SSL connection. RBAC is not the purpose of the test case, so this patch fixes it without enabling RBAC. Signed-off-by: Han Zhou --- tests/ovn-northd.at | 19 +-- 1 file changed, 17 insertions(+), 2 delet

[ovs-dev] [PATCH ovn 4/4] ovn.at: Fix test "virtual ports -- ovn-northd-ddlog".

The test case fails quite often for northd-ddlog because of the tunnel keys mismatch when comparing OpenFlow rules. Keys can change in different runs. This patch fixes it by extracting the expected keys from SB DB before comparison instead of hardcoding. Signed-off-by: Han Zhou --- tests/ovn.at

[ovs-dev] [PATCH] system-dpdk: negotiation tests for TSO for OVS and TestPMD

Negotiation Tests for TSO This patch adds negotiation tests for checking whether TSO is enabled or not in OVS and in TestPMD for 4 diferent scenarios. Signed-off-by: Meher Chinwala --- tests/system-dpdk-macros.at | 43 ++ tests/system-dpdk.at| 71 +