Re: [ovs-dev] [PATCH v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()

2023-02-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 10 Feb 2023 10:05:51 +0800 you wrote: > old_meter needs to be free after it is detached regardless of whether > the new meter is successfully attached. > > Fixes: c7c4c44c9a95 ("net: openvswitch: expand the

Re: [ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-13 Thread Eelco Chaudron
On 10 Feb 2023, at 17:02, Vladislav Odintsov wrote: > This patch adds new ovs-ctl options to pass umask configuration to allow > OVS daemons set requested socket permissions on group. Previous > behaviour (if using with systemd service unit) created sockets with 0750 > permissions mask (group

[ovs-dev] [PATCH ovn] system-test: Use OVS_WAIT_UNTIL for tcpdump start instead fo sleep

2023-02-13 Thread Ales Musil
By using the line buffered option (-l) we should be able to check for "listening" in the tcpdump stderr which is most of the time faster than just sleeping for some time (usually 1s). Signed-off-by: Ales Musil --- tests/system-ovn.at | 26 +- 1 file changed, 13

Re: [ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-13 Thread 0-day Robot
Bleep bloop. Greetings Adrián Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #271 FILE: ofproto/ofproto-dpif-ipfix.c:2925: /*

Re: [ovs-dev] [PATCH ovn v2] utilities: Add simple container automation

2023-02-13 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89 characters long (recommended limit is 79) #55 FILE:

Re: [ovs-dev] [PATCH ovn] controller: Prevent race in packet buffering

2023-02-13 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. Lines checked: 1119, Warnings: 0, Errors: 1

[ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-02-13 Thread Abhiram Sangana
This patch adds support to commit connections dropped/rejected by ACLs to the connection tracking table. Dropped connections are committed to conntrack only if NB_Global options:ct_commit_acl_drop is set to true (false by default) and ACL dropping/rejecting the connection has label configured. The

Re: [ovs-dev] [PATCH ovn v3 0/8] northd: Hash locks and lflow creation with dp groups.

2023-02-13 Thread Mark Michelson
I merged this series to main. Thanks Ilya! On 2/9/23 13:01, Ilya Maximets wrote: While running tests with ovn-heater it was observed that locking and unlocking dpg_lock can take more than 20% of CPU cycles in northd even without any contention. This series is trying to address that issue and

Re: [ovs-dev] [PATCH ovn v1 0/6] drop sampling: Fixes and optimizations

2023-02-13 Thread Mark Michelson
I have merged this to main. Thanks Adrian and Ales! On 2/10/23 03:30, Ales Musil wrote: On Tue, Jan 24, 2023 at 4:18 PM Adrián Moreno wrote: While testing, I discovered some problems with drop sampling (first 4 patches). Also, this series introduces an optimization. In order to avoid adding

Re: [ovs-dev] [PATCH ovn v2] utilities: Add simple container automation

2023-02-13 Thread Mark Michelson
On 2/10/23 04:28, Ales Musil wrote: Add simple script that allows user to run tests and builds using container. At the same time add example Dockerfile for Fedora 37. Basic usage is: ./utilities/containers/ci.sh This will compile the project with GCC, it expects podman as container platform

[ovs-dev] [PATCH ovn] Documentation: Fix the LTS link in ovn-upgrades doc.

2023-02-13 Thread Ilya Maximets
Even though it somehow works, we're not supposed to link sections of other documents directly via html page. For example, this will not work if someone will decide to build a PDF version of the docs. Use a reference to a tagged section instead. Fixes: e7ed121ee0f8 ("docs: Extend upgrade

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-02-13 Thread 0-day Robot
References: <20230213163539.4507-1-sangana.abhi...@nutanix.com> Bleep bloop. Greetings Abhiram Sangana, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82

[ovs-dev] [PATCH v3 3/3] route-table: Retrieving the preferred source address from Netlink.

2023-02-13 Thread Nobuhiro MIKI
We can use the "ip route add ... src ..." command to set the preferred source address for each entry in the kernel FIB. OVS has a mechanism to cache the FIB, but the preferred source address is ignored and calculated with its own logic. This patch resolves the difference between kernel FIB and OVS

[ovs-dev] [PATCH v3 0/3] Add support for preffered src address in ovs-router

2023-02-13 Thread Nobuhiro MIKI
With this series, the preferred source address in ovs-router is obtained from both ovs/route/add command and kernel FIB. v3: - Fix netdev-dummy to support multiple IP addresses - Add validation and unit tests for ovs/route/add - Refactor parsing for optional parameters in ovs/route/add command

[ovs-dev] [PATCH v3 2/3] ovs-router: Introduce src option in ovs/route/add command.

2023-02-13 Thread Nobuhiro MIKI
When adding a route with ovs/route/add command, the source address in "ovs_router_entry" structure is always the FIRST address that the interface has. See "ovs_router_get_netdev_source_address" function for more information. If an interface has multiple ipv4 and/or ipv6 addresses, there are use

[ovs-dev] [PATCH v3 1/3] netdev-dummy: Support multiple IP addresses

2023-02-13 Thread Nobuhiro MIKI
This is useful in test cases where multiple IPv4/IPv6 addresses are assigned together. Signed-off-by: Nobuhiro MIKI --- lib/netdev-dummy.c | 66 +- 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c

Re: [ovs-dev] [PATCH ovn v2] utilities: Add simple container automation

2023-02-13 Thread Ales Musil
On Mon, Feb 13, 2023 at 6:44 PM Mark Michelson wrote: > On 2/10/23 04:28, Ales Musil wrote: > > Add simple script that allows user to run tests and builds > > using container. At the same time add example Dockerfile for > > Fedora 37. > > > > Basic usage is: > > ./utilities/containers/ci.sh > >

Re: [ovs-dev] [PATCH ovn v1 0/6] drop sampling: Fixes and optimizations

2023-02-13 Thread Han Zhou
On Mon, Feb 13, 2023 at 8:56 AM Mark Michelson wrote: > > I have merged this to main. Thanks Adrian and Ales! > > On 2/10/23 03:30, Ales Musil wrote: > > On Tue, Jan 24, 2023 at 4:18 PM Adrián Moreno wrote: > > > >> While testing, I discovered some problems with drop sampling (first 4 > >>