Re: [ovs-dev] [PATCH v26 3/8] netdev-offload-tc: Introduce group ID management API

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > When offloading sample action to TC, userspace creates a unique ID > to map sample action and tunnel info and passes this ID to kernel > instead of the sample info. Kernel will send this ID and sampled > packet to userspace. Using the ID, userspace

Re: [ovs-dev] [PATCH v26 1/8] compat: Add psample and tc sample action defines for older kernels

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > Update kernel UAPI to support psample and the tc sample action. > > Signed-off-by: Chris Mi > Reviewed-by: Roi Dayan > Acked-by: Eelco Chaudron > --- Thanks for incorporating the requested changes. Explicitly acking v26: Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH v26 4/8] netdev-offload-tc: Add sample offload API for TC

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > Initialize psample socket. Add sample recv API to receive sampled > packets from psample socket. Add sample recv wait API to add psample > socket fd to poll list. Thanks for the update, see comments inline. //Eelco > Signed-off-by: Chris Mi >

Re: [ovs-dev] [PATCH v26 7/8] netdev-offload-tc: Add offload support for sFlow

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > Create a unique group ID to map the sFlow info when offloading sample > action to TC. When showing the offloaded datapath flows, translate the > group ID from TC sample action to sFlow info using the mapping. See comments inline. //Eelco >

Re: [ovs-dev] [PATCH v26 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > Add three sFlow offload test cases: > > 3: offloads - sflow with sampling=1 - offloads enabled ok > 4: offloads - sflow with sampling=2 - offloads enabled ok > 5: offloads - ping over vxlan tunnel with sflow - offloads enabled ok See some

[ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-12 Thread lmartins
From: Lucas Alvares Gomes In order for the CMS to know which Chassis a distributed gateway port is bond to, this patch updates the ovn-northd daemon to populate the Logical_Router_Port table with that information. To avoid changing the database schema, ovn-northd is setting a new key called

Re: [ovs-dev] [PATCH v26 2/8] ovs-kmod-ctl: Load kernel module psample

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > Update kernel UAPI to support psample and the tc sample action. > > Signed-off-by: Chris Mi > Reviewed-by: Roi Dayan > Acked-by: Eelco Chaudron > --- Thanks for incorporating the requested changes. Explicitly acking v26: Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH v26 2/8] ovs-kmod-ctl: Load kernel module psample

2023-04-12 Thread Eelco Chaudron
Oops, I replied with patch 1 to path 2 :( So here we go for patch 2: On 29 Mar 2023, at 13:42, Chris Mi wrote: > Load kernel module psample to receive sampled packets from TC. > Before removing kernel module psample, remove act_sample first. > > Signed-off-by: Chris Mi > Reviewed-by: Roi

Re: [ovs-dev] [PATCH net] selftests: openvswitch: adjust datapath NL message declaration

2023-04-12 Thread Aaron Conole
Hrrm... looks like I need to double check the filters on patch subject metadata. 0-day Robot writes: > Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details

Re: [ovs-dev] [PATCH v26 6/8] dpif-netlink: Add netdev offload recv in normal recv upcalls

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > In thread handler 0, add netdev offload recv in normal recv upcalls. > To avoid starvation, introduce a flag to alternate the order of > receiving normal upcalls and offload upcalls based on that flag. One small comment inline. //Eelco > Add similar

Re: [ovs-dev] [PATCH v26 5/8] netdev-offload: Add netdev offload recv and recv_wait APIs

2023-04-12 Thread Eelco Chaudron
On 29 Mar 2023, at 13:42, Chris Mi wrote: > Iterate each registered offload API. It's not a problem for today > since we only have one implementation. See comment inline. //Eelco > Signed-off-by: Chris Mi > Reviewed-by: Roi Dayan > --- > lib/netdev-offload.c | 35

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-12 Thread Han Zhou
On Wed, Apr 12, 2023 at 8:01 AM wrote: > > From: Lucas Alvares Gomes > > In order for the CMS to know which Chassis a distributed gateway port > is bond to, this patch updates the ovn-northd daemon to populate the > Logical_Router_Port table with that information. > > To avoid changing the

[ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-12 Thread Han Zhou
In RFC1812 section 5.3.1, it is mentioned that: If the TTL is reduced to zero (or less), the packet MUST be discarded, and if the destination is not a multicast address the router MUST send an ICMP Time Exceeded message ... So if the destionation is a multicast address the route

[ovs-dev] [PATCH ovn 1/2] northd.c: TTL discard flow should support for both ipv4 and ipv6.

2023-04-12 Thread Han Zhou
Remove 'ip4' from the match condition for this flow. Signed-off-by: Han Zhou --- northd/northd.c | 2 +- tests/ovn-northd.at | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index da3c8cf770bc..c4cb7232e0a1 100644 --- a/northd/northd.c

[ovs-dev] [PATCH 1/1] doc: Fix the list of supported tunnels in README.

2023-04-12 Thread Nobuhiro MIKI
Without distinguishing between IPv4 and IPv6, such as GRE and GRE-IPv6, nine types of tunneling are currently supported. Signed-off-by: Nobuhiro MIKI --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index a60a314feb34..e6c0d3d3061d

[ovs-dev] [PATCH net] selftests: openvswitch: adjust datapath NL message declaration

2023-04-12 Thread Aaron Conole
The netlink message for creating a new datapath takes an array of ports for the PID creation. This shouldn't cause much issue but correct it for future cases where we need to do decode of datapath information that could include the per-cpu PID map. Fixes: 25f16c873fb1 ("selftests: add

Re: [ovs-dev] [PATCH] ci: Separate DPDK from OVS build.

2023-04-12 Thread David Marchand
Hello Ilya, On Tue, Apr 4, 2023 at 8:01 PM Ilya Maximets wrote: > > On 3/30/23 11:24, David Marchand wrote: > > Let's separate DPDK compilation from the rest of OVS build: > > - this avoids multiple jobs building DPDK in parallel, which especially > > affects builds in the dpdk-latest branch,

Re: [ovs-dev] [PATCH ovn v8 2/2] northd: Make the use of common zone in NAT configurable

2023-04-12 Thread Ales Musil
On Tue, Apr 11, 2023 at 3:44 PM Dumitru Ceara wrote: > On 4/6/23 19:03, Ales Musil wrote: > > There are essentially three problems with the current > > combination of DGP + SNAT + LB: > > > > 1) The first packet is being SNATed in common zone due > > to a problem with pinctrl not preserving

[ovs-dev] [PATCH ovn] ci: Add job to build Fedora RPMs on every push/PR

2023-04-12 Thread Ales Musil
In order to have up-to-date Fedora RPMs from main branch add job that will build the RPMs automatically and publishes them as artifacts. Those artifacts are available for download to any logged-in user on GH. Reported-at: https://bugzilla.redhat.com/2178936 Signed-off-by: Ales Musil ---

Re: [ovs-dev] [PATCH net] selftests: openvswitch: adjust datapath NL message declaration

2023-04-12 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless