Re: [ovs-dev] [PATCH v4] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread Numan Siddique
On Sat, Jun 2, 2018 at 12:37 AM, aginwala wrote: > using pacemaker so that controllers can be placed in different fault > domains. > More background about the discussions can be found on: > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046770.html > > Signed-off-by: aginwala > ---

Re: [ovs-dev] [PATCH v5] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread Numan Siddique
On Tue, Jun 5, 2018 at 11:30 PM, Ben Pfaff wrote: > OK. Numan, will you provide a Tested-by and/or Acked-by for the patch? > Yes Ben. I will have a look into v5 and provide the same. > > On Tue, Jun 05, 2018 at 10:56:40AM -0700, aginwala wrote: > > Hi Ben: > > > > Numan and Han have helped

Re: [ovs-dev] [PATCH v5] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread Numan Siddique
d-off-by: aginwala > Thanks for the v5. Acked-by: Numan Siddique Tested-by: Numan Siddique > --- > Documentation/topics/integration.rst | 34 +--- > ovn/utilities/ovndb-servers.ocf | 75 +++--- > -- > 2 files changed, 85 insertions(

Re: [ovs-dev] [PATCH v4 2/2] Send gateway port ARP through router internal ports

2018-06-05 Thread Numan Siddique
On Tue, Jun 5, 2018 at 6:24 PM, wrote: > From: Venkata Anil > > External switches should learn the distributed gateway port MAC address > as they have to forward the packet tagged with tenant vlan network but > with this MAC as destination MAC address. So router has to send ARP > reply and gARP

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Set connections in NB and SB DB tables,

2018-06-19 Thread Numan Siddique
if [ "$MANAGE_NORTHD" = "yes" ]; then > > # Stop ovn-northd service. Set --ovn-manage-ovsdb=no so that > > @@ -355,7 +359,10 @@ ovsdb_server_start() { > > set $@ --db-nb-sync-from-proto=${NB_MASTER_PROTO} > > set $@ --

Re: [ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-06-20 Thread Numan Siddique
Southbound,SB_Global,connections and > --remote=db:OVN_Northbound,NB_Global,connections > > will be skipped for slave SB and NB dbs respectively by unsetting > --db-sb-use-remote-in-db and --db-nb-use-remote-in-db in ovn-ctl. > > Signed-off-by: aginwala > Acked-by: Numan S

Re: [ovs-dev] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-02 Thread Numan Siddique
On Mon, Jul 2, 2018, 10:25 PM 0-day Robot wrote: > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > Thanks Robot. I tho

Re: [ovs-dev] [PATCH v2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-08 Thread Numan Siddique
This patch is now part of this series - https://patchwork.ozlabs.org/project/openvswitch/list/?series=54336 Numan On Tue, Jul 3, 2018 at 12:21 AM wrote: > From: Numan Siddique > > Calling ovs.stream.open_block(ovs.stream.open("tcp:127.0.0.1:6641")) > returns > su

Re: [ovs-dev] OVS frozen for release

2018-07-08 Thread Numan Siddique
On Thu, Jul 5, 2018 at 11:46 PM Han Zhou wrote: > On Mon, Jul 2, 2018 at 9:48 AM, Ben Pfaff wrote: > > > > According to our release process, we should fork branch-2.10 from master > > July 1 (yesterday), then release on August 15. I'm going to propose > > that we modify this in the same way tha

Re: [ovs-dev] [PATCH v2 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-10 Thread Numan Siddique
On Mon, Jul 9, 2018 at 11:36 PM Ben Pfaff wrote: > On Sun, Jul 08, 2018 at 10:05:41PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Calling ovs.stream.open_block(ovs.stream.open("tcp:127.0.0.1:6641")) > returns > > success even if

Re: [ovs-dev] [PATCH 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-11 Thread Numan Siddique
On Wed, Jul 11, 2018 at 2:08 AM Ben Pfaff wrote: > On Wed, Jul 11, 2018 at 12:56:39AM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > The python function ovs.socket_util.check_connection_completion() uses > select() > > (provided by pyth

Re: [ovs-dev] [PATCH 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-11 Thread Numan Siddique
On Wed, Jul 11, 2018 at 10:26 PM Ben Pfaff wrote: > On Wed, Jul 11, 2018 at 12:37:28PM +0530, Numan Siddique wrote: > > On Wed, Jul 11, 2018 at 2:08 AM Ben Pfaff wrote: > > > > > On Wed, Jul 11, 2018 at 12:56:39AM +0530, nusid...@redhat.com wrote: >

Re: [ovs-dev] [PATCH 1/2] ovsdb-server: Don't log closing session at program termination.

2018-07-13 Thread Numan Siddique
vsdb-server is closing those sessions, since > > after all it's exiting! > > > > Reported-by: Sanket Sudake > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046840.html > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique

Re: [ovs-dev] [PATCH 2/2] test-unixctl.py: Don't suppress exceptions.

2018-07-13 Thread Numan Siddique
://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046840.html > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique > --- > tests/test-unixctl.py | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/tests/test-unixctl.py b/tests/test-

Re: [ovs-dev] [PATCH 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-08-07 Thread Numan Siddique
On Sat, Aug 4, 2018 at 3:20 AM Ben Pfaff wrote: > On Thu, Jul 12, 2018 at 01:37:33AM +0530, Numan Siddique wrote: > > On Wed, Jul 11, 2018 at 10:26 PM Ben Pfaff wrote: > > > > > On Wed, Jul 11, 2018 at 12:37:28PM +0530, Numan Siddique wrote: > > > > On We

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-08-08 Thread Numan Siddique
On Wed, Aug 8, 2018 at 2:58 AM Ben Pfaff wrote: > On Tue, Aug 07, 2018 at 05:12:32PM -0400, Mark Michelson wrote: > > On 08/07/2018 07:37 AM, nusid...@redhat.com wrote: > > >From: Numan Siddique > > > > > >The python function ovs.socket_util.check_c

Re: [ovs-dev] [PATCH v8 4/4] ovn: Generate Neighbor Solicitation packet for unknown MAC IPv6 packets

2017-09-28 Thread Numan Siddique
On Thu, Sep 28, 2017 at 2:12 AM, Mark Michelson wrote: > > > On Thu, Sep 21, 2017 at 11:12 AM wrote: > >> From: Numan Siddique >> >> In the router ingress pipeline, if the destination mac is unresolved >> by the time the packet reaches the ARP_REQUEST stag

Re: [ovs-dev] [PATCH v8 2/4] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-10-02 Thread Numan Siddique
Thanks Mark for the review. I will respin another patch set with your comments addressed. Numan On Fri, Sep 29, 2017 at 7:17 PM, Mark Michelson wrote: > > > On Thu, Sep 21, 2017 at 11:10 AM wrote: > >> From: Numan Siddique >> >> This patch adds a new OVN acti

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-13 Thread Numan Siddique
e: > >> Hi Andy. In the IRC meeting today, Numan suggested that you might be an > >> appropriate reviewer for this patch, so if you agree and you have a > >> chance to look at this then it would be appreciated. > >> > >> Thanks, > >> > >>

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-16 Thread Numan Siddique
On Sat, Oct 14, 2017 at 2:56 AM, Ben Pfaff wrote: > On Fri, Oct 13, 2017 at 12:06:56PM -0400, Russell Bryant wrote: > > On Fri, Oct 13, 2017 at 8:30 AM, Numan Siddique > wrote: > > > On Fri, Oct 13, 2017 at 6:05 AM, Andy Zhou wrote: > > > > > >>

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-16 Thread Numan Siddique
On Fri, Oct 13, 2017 at 9:36 PM, Russell Bryant wrote: > On Fri, Oct 13, 2017 at 8:30 AM, Numan Siddique > wrote: > > On Fri, Oct 13, 2017 at 6:05 AM, Andy Zhou wrote: > > > >> Hi, Numan, > >> > >> I am curious why default 5 seconds inactivity time

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-16 Thread Numan Siddique
On Sat, Oct 14, 2017 at 2:56 AM, Ben Pfaff wrote: > On Fri, Oct 13, 2017 at 12:06:56PM -0400, Russell Bryant wrote: > > On Fri, Oct 13, 2017 at 8:30 AM, Numan Siddique > wrote: > > > On Fri, Oct 13, 2017 at 6:05 AM, Andy Zhou wrote: > > > > > >>

Re: [ovs-dev] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

2017-10-24 Thread Numan Siddique
lease 7.3.1611 (Core) > Kernel version: 3.10.0-693.2.2.el7.x86_64 #1 SMP > OVS version: v2.8.1 (git tag) > #ovs-vswitchd --version > ovs-vswitchd (Open vSwitch) 2.8.1 > > Bug description: > > > Right now, OVN doesn't work using OVS 2.8.1 on Centos 7.

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

2017-10-25 Thread Numan Siddique
On Wed, Oct 25, 2017 at 3:09 PM, Daniel Alvarez Sanchez wrote: > > > On Tue, Oct 24, 2017 at 11:35 PM, Ben Pfaff wrote: > >> On Tue, Oct 24, 2017 at 02:27:59PM -0700, Ben Pfaff wrote: >> > On Tue, Oct 24, 2017 at 11:07:58PM +0200, Daniel Alvarez Sanchez wrote: >> > > Hi guys, >> > > >> > > Great

Re: [ovs-dev] [PATCH] Check flow's dl_type before setting ct_orig_tuple in 'pkt_metadata_from_flow()'

2017-10-25 Thread Numan Siddique
On Wed, Oct 25, 2017 at 10:46 PM, Ben Pfaff wrote: > On Wed, Oct 25, 2017 at 01:44:23PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Normally flow's dl_type will be a valid value. However when a packet is > sent to > > the contr

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

2017-10-25 Thread Numan Siddique
On Wed, Oct 25, 2017 at 10:51 PM, Ben Pfaff wrote: > On Wed, Oct 25, 2017 at 06:50:29PM +0530, Numan Siddique wrote: > > On Wed, Oct 25, 2017 at 3:09 PM, Daniel Alvarez Sanchez < > dalva...@redhat.com > > > wrote: > > > > > > > > > >

Re: [ovs-dev] [PATCH] ovn-northd: Do not add lflows in lr_in_arp_resolve stage for disabled logical ports

2017-10-25 Thread Numan Siddique
On Thu, Oct 26, 2017 at 2:59 AM, Ben Pfaff wrote: > On Wed, Sep 27, 2017 at 09:36:18PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > ovn-northd is adding the below logical flow for a disabled logical port > (with mac M > > and IP 'A&#

Re: [ovs-dev] [PATCH] ovn: Add LB flows for logical router with gateway port

2017-10-30 Thread Numan Siddique
On Fri, Oct 27, 2017 at 11:19 PM, Ben Pfaff wrote: > On Fri, Oct 27, 2017 at 10:03:07AM -0700, Guru Shetty wrote: > > On 27 October 2017 at 08:35, Ben Pfaff wrote: > > > > > This patch is one where I need help. I asked Guru because it's an area > > > he knows, but if you feel confident about it

Re: [ovs-dev] [PATCH] ovn-ctl: Provide the option to detach the OVN db servers or not when starting

2017-11-02 Thread Numan Siddique
On Thu, Nov 2, 2017 at 11:15 PM, Ben Pfaff wrote: > On Thu, Nov 02, 2017 at 04:55:14PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently if the user wants to start OVN db servers as separate > containers, 'ovn-ctl' > > scri

Re: [ovs-dev] [PATCH v10 0/4] Add Router Solicitation responder support and generate Neighbor Solicitation request for unknown

2017-11-02 Thread Numan Siddique
On Fri, Nov 3, 2017 at 2:10 AM, Ben Pfaff wrote: > On Thu, Nov 02, 2017 at 01:37:40PM -0700, Ben Pfaff wrote: > > Thank you for the patches! They look good to me, so I will apply them > > to master soon. I folded in a few minor changes to patch 2, which I'll > > mention in a reply to that patch

[ovs-dev] Few issues in my raft testing

2017-11-03 Thread Numan Siddique
Hi Ben, I have noticed a couple of issues when testing raft support in ovsdb-server. I am testing from your ovs-reviews/raft9 repo. 1) As I had mentioned in the IRC meeting yesterday, when I pass the options "--remote=db:OVN_Northbound,NB_Global,connections" to ovsdb-server, it is failing with th

Re: [ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

2017-11-03 Thread Numan Siddique
On Fri, Nov 3, 2017 at 9:54 PM, Mark Michelson wrote: > Thanks for the reviews Jakub. I've added an in-line comment below. > Otherwise consider that there is an implicit "Will do!" on all of your > other suggestions. > > On Fri, Nov 3, 2017 at 11:04 AM Jakub Sitnicki wrote: > > > Hi again Mark,

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Numan Siddique
t userbase :) ? > > "ovnsb_db" is misspelled twice in the commit message, but it's not worth > posting another version of the patch to fix those. Whoever commits this > change can edit those when merging. > > On Tue, Nov 7, 2017 at 9:32 AM wrote: > >> From: Nu

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 8:39 AM, Ben Pfaff wrote: > On Tue, Nov 07, 2017 at 09:01:27PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > ovn-ctl starts OVN DB servers with the options "--unixctl=ovnnb_db" > > and "--unixctl=ovnsb_db&

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 8:36 AM, Ben Pfaff wrote: > On Tue, Nov 07, 2017 at 09:01:06PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > In the RHEL environment, when OVN db servers are started using ovn-ctl, > > log files are empty. Adding "-vf

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 9:25 AM, Ben Pfaff wrote: > On Wed, Nov 08, 2017 at 08:57:38AM +0530, Numan Siddique wrote: > > On Wed, Nov 8, 2017 at 8:36 AM, Ben Pfaff wrote: > > > > > On Tue, Nov 07, 2017 at 09:01:06PM +0530, nusid...@redhat.com wrote: > > > > From

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 9:28 AM, Ben Pfaff wrote: > On Wed, Nov 08, 2017 at 08:48:25AM +0530, Numan Siddique wrote: > > On Wed, Nov 8, 2017 at 8:39 AM, Ben Pfaff wrote: > > > > > On Tue, Nov 07, 2017 at 09:01:27PM +0530, nusid...@redhat.com wrote: >

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-08 Thread Numan Siddique
On Wed, Nov 8, 2017 at 9:36 AM, Numan Siddique wrote: > > > On Wed, Nov 8, 2017 at 9:25 AM, Ben Pfaff wrote: > >> On Wed, Nov 08, 2017 at 08:57:38AM +0530, Numan Siddique wrote: >> > On Wed, Nov 8, 2017 at 8:36 AM, Ben Pfaff wrote: >> > >> > >

Re: [ovs-dev] [OVN] "Finish up ARP support" approach

2017-11-08 Thread Numan Siddique
Hi Tiago, Please see few comments inline On Wed, Nov 8, 2017 at 11:49 PM, Tiago Lam wrote: > Hey all, > > As pointed out in a previous email (email below), I'm hoping to work on > the "ARP re-checking bindings, expiring bindings" item on OVN's TODO.rst > file. I've since started tackling it,

Re: [ovs-dev] [PATCH v4 1/2] OVN: Add multicast keep-local flag.

2017-11-14 Thread Numan Siddique
lticast packets originate > from ovn-controller. Multiple ovn-controllers will be attempting to send > out those multicast packets, and so each should only be responsible for > delivering those packets to their local ports. > > Signed-off-by: Mark Michelson > Acked-by: Numan Si

Re: [ovs-dev] [PATCH v4 2/2] OVN: Add support for periodic router advertisements.

2017-11-14 Thread Numan Siddique
A few comments inline, otherwise LGTM. Thanks Numan On Mon, Nov 13, 2017 at 8:50 AM, Mark Michelson wrote: > This change adds three new options to the Northbound > Logical_Router_Port's ipv6_ra_configs option: > > * send_periodic: If set to "true", then OVN will send periodic router > advertis

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-20 Thread Numan Siddique
A gentle ping. Ben, is it possible to have a look at this patch set - https://patchwork.ozlabs.org/project/openvswitch/list/?series=12481. Thanks Numan On Wed, Nov 8, 2017 at 2:30 PM, Numan Siddique wrote: > > > On Wed, Nov 8, 2017 at 9:36 AM, Numan Siddique > wrote: > >>

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-21 Thread Numan Siddique
Thank you! On Nov 20, 2017 10:07 PM, "Ben Pfaff" wrote: > Yes, of course. I didn't get much work done last week with ovscon > going. > > On Mon, Nov 20, 2017 at 09:11:41PM +0530, Numan Siddique wrote: > > A gentle ping. Ben, is it possible to have a l

Re: [ovs-dev] [PATCH v2 0/2] OVN DB log fixes

2017-11-26 Thread Numan Siddique
ant backports. > > On Wed, Nov 08, 2017 at 02:28:13PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > v1 -> v2 > > --- > > In patch 2, changed the approach. Instead of fixing the issue in > > ovs-appctl, corrected the ovs logrotate

Re: [ovs-dev] [PATCH v2 0/2] OVN DB log fixes

2017-11-28 Thread Numan Siddique
backport all of the following commits to make > these patches apply cleanly: > > commit 2abbe32153b7e4719b39f477b35e7cc40231338a > Author: Numan Siddique > Date: Wed Nov 8 14:28:49 2017 +0530 > > ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options > >

Re: [ovs-dev] [PATCH v2] ovn-ctl: Add new commands 'run_nb_server' and 'run_sb_server'

2017-11-30 Thread Numan Siddique
On Wed, Nov 29, 2017 at 11:19 PM, Ben Pfaff wrote: > On Tue, Nov 21, 2017 at 12:35:56PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently if the user wants to start OVN db servers as separate > containers, 'ovn-ctl' > > scri

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-11-30 Thread Numan Siddique
On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff wrote: > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > In the case of OVN HA deployments with openstack, it has been noticed > > that the 5 seconds inactivity probe

Re: [ovs-dev] [PATCH v2] OVN pacemaker: Add the monitor action for Master role

2017-11-30 Thread Numan Siddique
rom: Numan Siddique > > Pacemaker Resource agent periodically calls the OVN OCF's "monitor" action > periodically to check the status. But the OVN OCF script doesn't add the > action "monitor" for the role "Master" because of which the pacemaker &

Re: [ovs-dev] [PATCH v2] ovn-ctl: Add new commands 'run_nb_server' and 'run_sb_server'

2017-11-30 Thread Numan Siddique
On Thu, Nov 30, 2017 at 11:27 PM, Ben Pfaff wrote: > On Thu, Nov 30, 2017 at 04:15:09PM +0530, Numan Siddique wrote: > > On Wed, Nov 29, 2017 at 11:19 PM, Ben Pfaff wrote: > > > > > On Tue, Nov 21, 2017 at 12:35:56PM +0530, nusid...@redhat.com wrote: >

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-11-30 Thread Numan Siddique
On Thu, Nov 30, 2017 at 11:21 PM, Ben Pfaff wrote: > On Thu, Nov 30, 2017 at 11:02:23PM +0530, Numan Siddique wrote: > > On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff wrote: > > > > > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote: >

Re: [ovs-dev] [PATCH v2] ovn-ctl: Add new commands 'run_nb_server' and 'run_sb_server'

2017-12-01 Thread Numan Siddique
On Thu, Nov 30, 2017 at 11:38 PM, Numan Siddique wrote: > > > On Thu, Nov 30, 2017 at 11:27 PM, Ben Pfaff wrote: > >> On Thu, Nov 30, 2017 at 04:15:09PM +0530, Numan Siddique wrote: >> > On Wed, Nov 29, 2017 at 11:19 PM, Ben Pfaff wrote: >> > >> &g

Re: [ovs-dev] [PATCH v2] OVN pacemaker: Add the monitor action for Master role

2017-12-03 Thread Numan Siddique
On Thu, Nov 30, 2017 at 11:35 PM, Numan Siddique wrote: > This patch needs so more testing. In one of my deployments I see no master > is promoted and all the ovn db resources running in 3 nodes are in slave > mode. In my previous testing it worked fine though. > > I will fix th

Re: [ovs-dev] [PATCH v3] OVN pacemaker: Add the monitor action for Master role

2017-12-04 Thread Numan Siddique
On Mon, Dec 4, 2017 at 7:12 PM, Russell Bryant wrote: > On Mon, Dec 4, 2017 at 12:29 AM, wrote: > > From: Numan Siddique > > > > Pacemaker Resource agent periodically calls the OVN OCF's "monitor" > action > > periodically to check the status. But

Re: [ovs-dev] [PATCH v3] OVN pacemaker: Add the monitor action for Master role

2017-12-04 Thread Numan Siddique
On Mon, Dec 4, 2017 at 7:39 PM, Numan Siddique wrote: > > > On Mon, Dec 4, 2017 at 7:12 PM, Russell Bryant wrote: > >> On Mon, Dec 4, 2017 at 12:29 AM, wrote: >> > From: Numan Siddique >> > >> > Pacemaker Resource agent periodically calls the OV

Re: [ovs-dev] [PATCH v4] OVN pacemaker: Add the monitor action for Master role

2017-12-05 Thread Numan Siddique
On Dec 5, 2017 9:16 PM, "Russell Bryant" wrote: On Mon, Dec 4, 2017 at 9:27 AM, wrote: > From: Numan Siddique > > Pacemaker Resource agent periodically calls the OVN OCF's "monitor" action > periodically to check the status. But the OVN OCF script doesn

Re: [ovs-dev] [PATCH] OVN pacemaker: Fix issues when started as pacemaker container bundles

2018-01-10 Thread Numan Siddique
On Jan 10, 2018 3:21 AM, "Russell Bryant" wrote: On Mon, Jan 8, 2018 at 2:35 AM, wrote: > From: Numan Siddique > > When OVN dbs are created as a pacemaker container bundle resource with > meta attribute "container-attribute-target=host" defined, the OVN OCF

Re: [ovs-dev] 答复: Re: [PATCH] The dependency between ovndb_servers-master andVirtualIP is wrong

2018-01-23 Thread Numan Siddique
Hi xurong, Please see below for some comments. On Wed, Jan 24, 2018 at 8:36 AM, wrote: > Hello,Liguoshuai: > > In my cluster environment, HA manages a lot of services, and VIP is not > just for ovsdb. > > When I move ovsdb out of HA, VIP can't start, and other services are so > abnormal, such

Re: [ovs-dev] [PATCH] ovn-northd: Do not add lflows in lr_in_arp_resolve stage for disabled logical ports

2018-02-02 Thread Numan Siddique
On Fri, Feb 2, 2018 at 6:02 AM, Ben Pfaff wrote: > On Thu, Oct 26, 2017 at 06:56:46AM +0530, Numan Siddique wrote: > > On Thu, Oct 26, 2017 at 2:59 AM, Ben Pfaff wrote: > > > > > On Wed, Sep 27, 2017 at 09:36:18PM +0530, nusid...@redhat.com wrote: >

Re: [ovs-dev] [PATCH V2] ovn-controller: Reduce the number of flows by use conjunction action

2018-02-03 Thread Numan Siddique
On Sat, Feb 3, 2018 at 4:37 AM, Ben Pfaff wrote: > On Wed, Oct 18, 2017 at 10:39:12AM +0800, wei wrote: > > This patch convert ovn-sb lflow match expr "(1 or 2) and (3 or 4)" to > > match 1 aciton connjunction(1, 1/2) > > match 2 aciton connjunction(1, 1/2) > > match 3 aciton connjunction(1, 2/2)

Re: [ovs-dev] [OVN][Request] New OVS 2.8 tag

2018-02-04 Thread Numan Siddique
On Tue, Jan 2, 2018 at 5:24 PM, Daniel Alvarez Sanchez wrote: > Hi folks, > > It'd be great if we could have 2.8.2 tag so that we can benefit > from some patches that we would require in OVN and its OpenStack > integration such as: > > * OVN: Add external_ids to NAT and Logical_Router_Static_Rout

Re: [ovs-dev] [PATCH V2] ovn-controller: Reduce the number of flows by use conjunction action

2018-02-05 Thread Numan Siddique
e. I will try it out. Thanks Numan I do not know how to deal with the conjunction of 'or' in level 2. 在 2018/2/3 18:12, Numan Siddique 写道: On Sat, Feb 3, 2018 at 4:37 AM, Ben Pfaff wrote: > On Wed, Oct 18, 2017 at 10:39:12AM +0800, wei wrote: > > This patch convert ovn-sb

Re: [ovs-dev] [PATCH V2] ovn-controller: Reduce the number of flows by use conjunction action

2018-02-05 Thread Numan Siddique
On Mon, Feb 5, 2018 at 3:21 PM, Numan Siddique wrote: > > > On Feb 5, 2018 12:32 PM, "Wei Li" wrote: > > your patch is better, pls ignore my patch, it has some bugs. > > and I have a question, have you considered that situasion: > > and(or(and(or))), i

Re: [ovs-dev] [RFC PATCH 1/1]: Enhance conjunctive match support in OVN

2018-02-06 Thread Numan Siddique
On Tue, Feb 6, 2018 at 11:31 PM, Ben Pfaff wrote: > On Fri, Feb 02, 2018 at 09:06:39PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently, if a logical flow has possible conjunctive matches, OVN > expression > > parser has support for tha

Re: [ovs-dev] [RFC PATCH 1/1]: Enhance conjunctive match support in OVN

2018-02-06 Thread Numan Siddique
On Feb 7, 2018 1:06 AM, "Ben Pfaff" wrote: On Wed, Feb 07, 2018 at 12:12:38AM +0530, Numan Siddique wrote: > On Tue, Feb 6, 2018 at 11:31 PM, Ben Pfaff wrote: > > > On Fri, Feb 02, 2018 at 09:06:39PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddiq

Re: [ovs-dev] [PATCH 1/3] expr: Fix some bad naming.

2018-02-07 Thread Numan Siddique
erator, it was a symbol. > > This commit improves both names. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique Thanks Numan > --- > ovn/lib/expr.c | 46 ++ > 1 file changed, 26 insertions(+), 20 deletions(-) >

Re: [ovs-dev] [PATCH 2/3] expr: Make expr_sort() always yield an expr that satisfies invariants.

2018-02-07 Thread Numan Siddique
hild > EXPR_T_AND expression x[0..1] == 3. This commit fixes the problem. > > I don't know of any externally visible negative consequences for this > problem, but it made the code harder to reason about. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique

Re: [ovs-dev] [PATCH 3/3] expr: Add additional invariant check in test.

2018-02-07 Thread Numan Siddique
On Tue, Feb 6, 2018 at 11:30 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique Thanks Numan > --- > tests/test-ovn.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/test-ovn.c b/tests/test-ovn.c > index d4dfc8151d9e..745

Re: [ovs-dev] [RFC PATCH 1/1]: Enhance conjunctive match support in OVN

2018-02-09 Thread Numan Siddique
; > > > It makes sense. Without your patch, each ACL results in ~1 million flows > > being generated. With your patch, each ACL results in ~2000 flows being > > generated. > > > > Definitely an improvement! If you make a v2, I'll test it as well. > > > > Tested-by

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-20 Thread Numan Siddique
On Tue, Feb 20, 2018 at 7:39 PM, Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > On Fri, Feb 16, 2018 at 05:10:29PM +0100, Jakub Sitnicki wrote: > >> Ben, > >> > >> On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > >> > Jakub Sitnicki demonstrated that repeatedly calculating row

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-21 Thread Numan Siddique
On Thu, Feb 22, 2018 at 4:49 AM, Mark Michelson wrote: > Hi, > > While testing an unrelated change in OVS master (using make sandbox > SANDBOXFLAGS="--ovn"), I noticed that my laptop was making way more noise > than normal. Looking at `top` output, an ovsdb-server process was running > at 100% CP

Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-23 Thread Numan Siddique
_run > 2.49% 0.17% ovn-northd ovn-northd [.] ovn_lflow_find > > Fixes: 8bf332225d4a ("ovn-northd: Reduce amount of flow hashing.") > Signed-off-by: Jakub Sitnicki > Acked-by: Numan Siddique Tested-by: Numan Siddique --- > ovn/lib/ovn-util.c | 8 +++-

Re: [ovs-dev] [PATCH] Fix possible timing issues in OVN test cases

2018-03-01 Thread Numan Siddique
On Feb 28, 2018 9:11 PM, "Ben Pfaff" wrote: On Tue, Feb 27, 2018 at 08:17:35PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch fixes timing related failures in some test cases when run with > -j option. It adds --wait=hv when calling ovn-nb

Re: [ovs-dev] [PATCH v3] ovn-controller: Support multiple gateway port on a distributed router

2018-03-01 Thread Numan Siddique
On Feb 28, 2018 6:12 PM, "Guru Shetty" wrote: This is a little more complicated for a quick review. I think it will need a round from me to understand the implications for gateway routers and one round from Numan (or someone from openstack) that use distributed gateway routers. Ack. I will tak

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Add 'dns_lookup' action

2017-03-29 Thread Numan Siddique
On Wed, Mar 29, 2017 at 11:12 PM, Ben Pfaff wrote: > On Mon, Mar 27, 2017 at 07:42:58PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds a new OVN action 'dns_lookup' to support native DNS. > > ovn-controller parses this ac

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support native DNS

2017-03-29 Thread Numan Siddique
On Wed, Mar 29, 2017 at 11:47 PM, Guru Shetty wrote: > >> >> Agree. It was in my mind. I somehow missed it out. >> >> >>> >>> The above would mean that for each logical port, we need to create a DNS >>> record in the DNS table. Having the schema like the above has advantages. >>> In the future, i

Re: [ovs-dev] [PATCH v4 3/3] ovn-northd: Add logical flows to support native DNS

2017-04-17 Thread Numan Siddique
On Sat, Apr 15, 2017 at 8:51 AM, Ben Pfaff wrote: > On Mon, Apr 03, 2017 at 04:10:27PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > OVN implements native DNS resolution which can be used to resolve the > > internal DNS names belonging to a l

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add 'dns_lookup' action

2017-04-24 Thread Numan Siddique
On Mon, Apr 24, 2017 at 10:04 PM, Guru Shetty wrote: > > > On 17 April 2017 at 08:13, wrote: > >> From: Numan Siddique >> >> This patch adds a new OVN action 'dns_lookup' to support native DNS. >> ovn-controller parses this action and adds a N

Re: [ovs-dev] [PATCH v6 3/3] ovn-northd: Add logical flows to support native DNS

2017-05-02 Thread Numan Siddique
On Wed, May 3, 2017 at 4:38 AM, Ben Pfaff wrote: > On Tue, Apr 25, 2017 at 07:59:54PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > OVN implements native DNS resolution which can be used to resolve the > > internal DNS names belonging to a l

Re: [ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread Numan Siddique
On Thu, May 4, 2017 at 8:48 PM, Aaron Conole wrote: > Hi Numan, > > nusid...@redhat.com writes: > > > From: Numan Siddique > > > > I have picked up the patch series authored by Zong Kai LI to support IPv6 > > Router Advertisement in ovn - > > https://m

Re: [ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread Numan Siddique
On Fri, May 5, 2017 at 9:31 AM, Ben Pfaff wrote: > On Fri, May 05, 2017 at 09:20:37AM +0530, Numan Siddique wrote: > > On Thu, May 4, 2017 at 8:48 PM, Aaron Conole wrote: > > > > > Hi Numan, > > > > > > nusid...@redhat.com writes: > > > &

Re: [ovs-dev] [PATCH v5 3/6] ovn: extend expr symbols for ND

2017-05-04 Thread Numan Siddique
ll", "nd.tll", to describe more clear about > "icmp6.type" > > predicate. > > It adds new symbols: > > - "nd_rs" stands for Router Solicitation message, > > - "nd_ra" stands for Router Advertisement message, > > > >

Re: [ovs-dev] [PATCH v5 5/6] ovn-controller: add 'put_nd_ra_addr_mode' and 'put_nd_opt_*' actions support

2017-05-15 Thread Numan Siddique
MTU Option for RA packet with inner > > integer value(32-bit unsigned integer). > > e.g. put_nd_ra_opt_mtu(1450); > > > > Action put_nd_ra_opt_prefix will append Prefix Information Option with > > following inner parameters for RA packet: > > - prefix length(8-bi

Re: [ovs-dev] [PATCH] ovn: increase size of ingress and egress pipelines

2017-05-15 Thread Numan Siddique
On Fri, May 12, 2017 at 12:06 AM, Mickey Spiegel wrote: > The OVN ingress pipeline for a logical switch is maxed out at 16 stages. > > This patch takes the simple approach of starting the ingress pipeline at > table 8 rather than table 16, and starting the egress pipeline at > table 40 rather tha

Re: [ovs-dev] [PATCH] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

2017-05-15 Thread Numan Siddique
On Mon, May 15, 2017 at 8:46 PM, Lance Richardson wrote: > > From: nusid...@redhat.com > > To: d...@openvswitch.org > > Sent: Monday, 15 May, 2017 11:03:47 AM > > Subject: [ovs-dev] [PATCH] python ovs: Fix SSL exceptions with > pyOpenSSL v0.13 > > > &g

Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

2017-05-18 Thread Numan Siddique
On Wed, May 17, 2017 at 9:15 PM, Ben Pfaff wrote: > From: Zhengwei Gao > > As ovn-northd servcie parse network element between ovnnb_db and > ovnsb_db, it ensures ovn-northd service connecting to ovnnb_db and > ovnsb_db. OVNDB-HA was supported with pacemaker, ovn-northd service > will be failov

Re: [ovs-dev] [PATCH] Fix flake8 check

2017-05-18 Thread Numan Siddique
On Fri, May 19, 2017 at 9:39 AM, Terry Wilson wrote: > Stop occluding the previous definition of filename. > > Signed-off-by: Terry Wilson > Acked-by: Numan Siddique > --- > Documentation/conf.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

2017-05-22 Thread Numan Siddique
r cases, it would be a no-op. +# Set --ovn-manage-ovsdb=no so that ovn-ctl doesn't stop ovsdb-servers. +${OVN_CTL} --ovn-manage-ovsdb=no stop_northd +fi + ovsdb_server_check_status case $? in $OCF_NOT_RUNNING)return ${OCF_SUCCESS};; -

Re: [ovs-dev] [PATCH 1/2] ovn pacemaker: Fix return code errors in start/stop action

2017-05-22 Thread Numan Siddique
On Tue, May 23, 2017 at 5:21 AM, Andy Zhou wrote: > On Sun, May 21, 2017 at 6:35 PM, wrote: > > From: Numan Siddique > > > > start action returns OCF_RUNNING_MASTER in certain scenarios. > > But as per the OCF guidelines, status code OCF_RUNNING_MASTER shoud >

Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

2017-05-23 Thread Numan Siddique
On Tue, May 23, 2017 at 9:44 AM, multi_t...@163.com wrote: > Hi Numan, > > Thank you very much, I had pushed the patch new version > https://github.com/openvswitch/ovs/pull/178 > Thanks. I tested it. Acked-by: Numan Siddique Tested-by: Numan Siddique I can post the patch

Re: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

2017-05-23 Thread Numan Siddique
On May 23, 2017 11:04 PM, "Russell Bryant" wrote: On Mon, May 15, 2017 at 11:39 AM, wrote: > From: Numan Siddique > > Centos provides pyOpenSSL version pyOpenSSL-0.13.1-3.el7.x86_64. > There are 2 issues using this version, which this patch fixes > > - The test ca

Re: [ovs-dev] [PATCH] ovn-ctl: Add commands to manage OVN DB ovsdb-servers individually

2017-05-26 Thread Numan Siddique
On Fri, May 26, 2017 at 3:30 AM, Andy Zhou wrote: > On Thu, May 25, 2017 at 1:55 AM, wrote: > > From: Numan Siddique > > > > This patch adds the following functions > > - start_nb_ovsdb, stop_nb_ovsdb, restart_nb_ovsdb to start, stop and > > r

Re: [ovs-dev] [PATCH] doc: Fix sphinx reference warning for windows.

2017-05-31 Thread Numan Siddique
Hi Ben, Can this commit [1] be backported to OVS 2.7 please. networking-ovn CI job is failing to compile OVS 2.7 with sphinx version 1.6.2 (CI job is using sphinx version 1.6.2). With this commit, it works fine. [1] - https://github.com/openvswitch/ovs/commit/01f92b743eb334d09bdeb511bf7d35e88a5

Re: [ovs-dev] [PATCH v3 3/3] ovn-northd: Add logical flows to support native IPv6 RA

2017-07-31 Thread Numan Siddique
table, which the CMS is expected to configure IPv6 RA >> configurations - "address_mode" and "mtu" for adding these flows. >> >> Co-authored-by: Numan Siddique >> Signed-off-by: Zongkai LI >> Signed-off-by: Numan Siddique >> --- >>

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

2017-08-01 Thread Numan Siddique
On Tue, Aug 1, 2017 at 5:00 AM, Han Zhou wrote: > On Mon, Jul 31, 2017 at 1:53 PM, Russell Bryant wrote: > > > > I wanted to share the idea before I code it to see if it makes sense. > > I imagine the patch would be small, though. > > > > We currently provide HA for ovn-northd by using Pacemaker

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

2017-08-01 Thread Numan Siddique
On Tue, Aug 1, 2017 at 4:25 PM, Numan Siddique wrote: > > > On Tue, Aug 1, 2017 at 5:00 AM, Han Zhou wrote: > >> On Mon, Jul 31, 2017 at 1:53 PM, Russell Bryant wrote: >> > >> > I wanted to share the idea before I code it to see if it makes sense. >

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

2017-08-01 Thread Numan Siddique
gt; > instance won't have a chance to be active any more. > > Good question ... I was assuming this scenario was due to a lost > connection, and that the IDL would automatically try to re-acquire the > lock. > > I tested to make sure I saw a second ovn-nor

Re: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL logging" test case

2017-08-02 Thread Numan Siddique
On Wed, Aug 2, 2017 at 7:37 PM, Lance Richardson wrote: > > From: nusid...@redhat.com > > To: d...@openvswitch.org > > Sent: Monday, 31 July, 2017 2:20:53 PM > > Subject: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL > logging"test case >

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-08-04 Thread Numan Siddique
On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote: > On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > > IPv6 Router Advertisement in OV

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-08-04 Thread Numan Siddique
On Fri, Aug 4, 2017 at 4:09 PM, Numan Siddique wrote: > > > On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote: > >> On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote: >> > From: Numan Siddique >> > >> > This patch adds a new

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-08-09 Thread Numan Siddique
On Aug 10, 2017 12:06 AM, "Ben Pfaff" wrote: On Fri, Aug 04, 2017 at 04:09:58PM +0530, Numan Siddique wrote: > On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote: > > > On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique

  1   2   3   4   5   6   7   8   9   10   >