Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-27 Thread Pablo Cascón
jumbo RX. Add a quirk for "igb" while the PMD is fixed. Thanks for the v3 Pablo, comments inline. Reported-by: Louis Peens <louis.pe...@netronome.com> Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> --- C

[ovs-dev] [PATCH v4 1/1] netdev-dpdk: don't enable scatter for jumbo RX support for nfp

2018-04-27 Thread Pablo Cascón
releases OVS/DPDK Reported-by: Louis Peens <louis.pe...@netronome.com> Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> --- lib/netdev-dpdk.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff

Re: [ovs-dev] [PATCH] netdev-dpdk: fix check for "net_nfp" driver

2018-05-18 Thread Pablo Cascón
On 17/05/18 17:45, Timothy Redaelli wrote: > Currently the check of "net_nfp" driver while enabling scatter compares > only the first 6 bytes, but "net_nfp" is 7 bytes long. > > This change fixes the check by comparing the first 7 bytes. > > CC: Pablo Ca

Re: [ovs-dev] [PATCH v4 1/1] netdev-dpdk: don't enable scatter for jumbo RX support for nfp

2018-05-02 Thread Pablo Cascón
On 01/05/18 11:34, Stokes, Ian wrote: On 04/27/2018 05:40 PM, Pablo Cascón wrote: Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo RX support. This change fixes the issue by not enabling scatter only for the PMD/NIC known not to need

[ovs-dev] [PATCH 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-10 Thread Pablo Cascón
Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo support on RX. This change fixes the issue by only enabling scatter for NICs supporting it. Reported-by: Louis Peens <louis.pe...@netronome.com> Signed-off-by: Pablo Cascón <

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-11 Thread Pablo Cascón
com> Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> --- lib/netdev-dpdk.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index ee39cbe..28b20b5 100644 --- a

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-13 Thread Pablo Cascón
-by: Louis Peens <louis.pe...@netronome.com> Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> --- lib/netdev-dpdk.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dp

[ovs-dev] [PATCH v2 0/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-13 Thread Pablo Cascón
Hello, here is a v2, this cover letter is to highlight that there is a quirk being added and that it has not been tested with "igb" (don't have an available system with igb at the moment). Some test with "igb" would be greatly appreciated, along with any feedback. Thanks, Pa

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-13 Thread Pablo Cascón
ouis Peens <louis.pe...@netronome.com> Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> --- lib/netdev-dpdk.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-d

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-18 Thread Pablo Cascón
pdk.org/ml/archives/dev/2018-April/097056.html Reported-by: Louis Peens<louis.pe...@netronome.com> Signed-off-by: Pablo Cascón<pablo.cas...@netronome.com> Reviewed-by: Simon Horman<simon.hor...@netronome.com> --- lib/netdev-dpdk.c | 10 +- 1 file changed, 9 insertions(+

[ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-20 Thread Pablo Cascón
ouis Peens <louis.pe...@netronome.com> Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> --- Changelog: v3->v2: - only check for driver_name - tested with "nfp" and not with "igb" lib

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-19 Thread Pablo Cascón
On 18/04/18 18:35, Kevin Traynor wrote: On 04/18/2018 03:41 PM, Pablo Cascón wrote: On 13/04/18 19:45, Kevin Traynor wrote: On 04/13/2018 04:20 PM, Stokes, Ian wrote: Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo support on RX

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-20 Thread Pablo Cascón
On 19/04/18 19:25, Kevin Traynor wrote: On 04/19/2018 03:32 PM, Pablo Cascón wrote: On 18/04/18 18:35, Kevin Traynor wrote: On 04/18/2018 03:41 PM, Pablo Cascón wrote: On 13/04/18 19:45, Kevin Traynor wrote: On 04/13/2018 04:20 PM, Stokes, Ian wrote: Currently to RX jumbo packets fails