Re: [ovs-dev] [PATCH v2] rhel: remove ovs-sim man page from temporary directory

workaround \ +$RPM_BUILD_ROOT%{_mandir}/man1/ovs-sim.1 \ $RPM_BUILD_ROOT%{_mandir}/man8/ovs-vlan-bug-workaround.8 %check Acked-by: Roi Dayan ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: remove ovs-sim man page from temporary directory (also for RHEL)

On 06/06/2018 08:49, Ansis Atteka wrote: > On Tue, 5 Jun 2018 at 20:32, Ben Pfaff wrote: >> >> On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote: >>> Fix following compilation error when building rpm packages >>> with rhel/openvswitch.spec file. >>> >>> error: Installed (but unpackag

Re: [ovs-dev] [PATCH] ovs-sim: Don't install manpage at all (except from ovs-sim itself).

e > inside ovs-sim itself, so that the user can invoke "man ovs-sim" from its > nested shell. > > This commit makes this happen. > > Suggested-by: Roi Dayan > Signed-off-by: Ben Pfaff thanks. tested make install and fedora package. Acked-by: Roi Dayan > -

Re: [ovs-dev] [PATCH 6/6] netdev-linux: monitor and offload LAG slaves to TC

On 21/06/2018 16:36, John Hurley wrote: > A LAG slave cannot be added directly to an OvS bridge, nor can a OvS > bridge port be added to a LAG dev. However, LAG masters can be added to > OvS. > > Use TC blocks to indirectly offload slaves when their master is attached > as a linux-netdev to an

Re: [ovs-dev] [PATCH v2 6/6] netdev-linux: monitor and offload LAG slaves to TC

On 26/06/2018 20:43, John Hurley wrote: > A LAG slave cannot be added directly to an OvS bridge, nor can a OvS > bridge port be added to a LAG dev. However, LAG masters can be added to > OvS. > > Use TC blocks to indirectly offload slaves when their master is attached > as a linux-netdev to an

[ovs-dev] [PATCH] netdev-tc-offloads: Fix probing multi mask per prio

ation. It's best the probe will add and del the ingress qdisc to have a clean start after it. Signed-off-by: Roi Dayan Acked-by: Paul Blakey --- lib/netdev-tc-offloads.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/lib/netdev-tc-offloa

Re: [ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

ich types of dumps to >> provide, rather than passing the type string and having dpif parse it. >> >> Signed-off-by: Gavi Teitz >> Acked-by: Roi Dayan > > Hi, > > this looks good to me. However, I wonder if it should wait until after the > v2.10 soft-freeze

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

On 27/07/2018 14:00, Simon Horman wrote: > Hi Gavi, > > On 26 July 2018 at 17:36, Justin Pettit > wrote: > > > > On Jul 26, 2018, at 7:29 AM, Gavi Teitz > wrote: > > > > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 A

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On 27/09/2017 12:08, Simon Horman wrote: On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote: On 18/09/2017 18:01, Simon Horman wrote: On Mon, Sep 18, 2017 at 07:16:03AM +0300, Roi Dayan wrote: From: Paul Blakey To be later used to implement ovs action set offloading. Signed

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On 16/11/2017 18:29, Simon Horman wrote: On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: On 27/09/2017 12:08, Simon Horman wrote: On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote: On 18/09/2017 18:01, Simon Horman wrote: On Mon, Sep 18, 2017 at 07:16:03AM +0300

Re: [ovs-dev] [PATCH V2 4/4] netdev-tc-offloads: Add support for action set

On 18/11/2017 21:52, Eric Garver wrote: On Mon, Sep 18, 2017 at 07:16:04AM +0300, Roi Dayan wrote: From: Paul Blakey Implement support for offloading ovs action set using tc header rewrite action. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 201

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On 20/11/2017 14:30, Simon Horman wrote: On Sun, Nov 19, 2017 at 08:45:19AM +0200, Roi Dayan wrote: On 16/11/2017 18:29, Simon Horman wrote: On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: On 27/09/2017 12:08, Simon Horman wrote: On Mon, Sep 25, 2017 at 04:31:42PM +0300

[ovs-dev] [PATCH 0/7] Fixes for header rewrite feature

Hi, The following series fixes some issues with header rewrite and some small refactoring. Thanks, Roi Paul Blakey (7): netdev-tc-offloads: Fix travis compilation error netdev-tc-offloads: Fix accidental skipping of extended pedit keys netdev-tc-offloads: Verify csum flags on dump from tc

[ovs-dev] [PATCH 1/7] netdev-tc-offloads: Fix travis compilation error

From: Paul Blakey Travis complains about variable length array usage, use a fixed size instead. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc

[ovs-dev] [PATCH 3/7] netdev-tc-offloads: Verify csum flags on dump from tc

From: Paul Blakey On dump, parse and verify the tc csum action update flags in the same way as we put them. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 117 ++- lib/tc.h | 2 ++ 2 files changed, 103 insertions

[ovs-dev] [PATCH 4/7] netdev-tc-offloads: Remove redundant brackets

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tc.c b/lib/tc.c index 360a770..4f82623 100644 --- a/lib/tc.c +++ b/lib/tc.c @@ -1059,7 +1059,7 @@ static void nl_msg_put_act_pedit(struct

[ovs-dev] [PATCH 7/7] tc: Send csum action only if we need to update csum

From: Paul Blakey Currently we send the tc csum action even if it's not needed. Fix that by sending it only if csum update flags isn't zero. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/

[ovs-dev] [PATCH 2/7] netdev-tc-offloads: Fix accidental skipping of extended pedit keys

From: Paul Blakey We only support extended pedit keys for now, so it's the type we expect. Skip the legacy ones instead. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tc.c b/lib/tc.c index 62

[ovs-dev] [PATCH 6/7] tc: Fix wrong struct variable order

From: Paul Blakey Fix the struct variable order to corrospond with it's usage. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tc.c b/lib/tc.c index 4f82623..9170e3e 100644 --- a/lib/tc.c +++ b/lib

[ovs-dev] [PATCH 5/7] netdev-tc-offloads: Remove redundant loop handling ovs action set

From: Paul Blakey OVS action set always has a single nested OVS_KEY_ATTR_* so there is no need to iterate it. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 90 +++- 1 file changed, 44 insertions(+), 46 deletions

[ovs-dev] [PATCH 0/2] TC offload dump fix and add frag

for frag. Thanks, Roi Roi Dayan (2): lib/tc: Handle error parsing action in nl_parse_single_action netdev-tc-offloads: Add support for offloading ip frag no lib/netdev-tc-offloads.c | 13 - lib/tc.c | 45 +++-- lib/tc.h

[ovs-dev] [PATCH 1/2] lib/tc: Handle error parsing action in nl_parse_single_action

Raise the error up instead of ignoring it. Before this commit beside an error an incorrect rule was also printed. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/tc.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/lib/tc.c b/lib/tc.c index

[ovs-dev] [PATCH 2/2] netdev-tc-offloads: Add support for offloading ip frag no

TC flower only support frag yes/no while OVS support first/later/no. Currently we can only support offloading of frag no. Signed-off-by: Roi Dayan Reviewed-by: Shahar Klein --- lib/netdev-tc-offloads.c | 13 - lib/tc.c | 28 lib/tc.h

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 23/03/2017 09:01, Joe Stringer wrote: I ran the make check-offloads tests on a recent net-next kernel and it failed, output was not as expected: ../../tests/system-offloaded-traffic.at:54 : ovs-appctl dpctl/dump-flows | grep "eth_type(0x0800)" | sed -e

[ovs-dev] [PATCH ovs V6 04/24] other-config: Add tc-policy switch to control tc flower flag

: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 6 ++ lib/tc.c | 43 ++- lib/tc.h | 1 + vswitchd/vswitch.xml | 17 + 4 files changed, 66 insertions(+), 1 deletion(-) diff --git a/lib/netdev.c

[ovs-dev] [PATCH ovs V6 03/24] other-config: Add hw-offload switch to control netdev flow offloading

-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 30 ++ lib/netdev.h | 2 ++ vswitchd/bridge.c| 1 + vswitchd/vswitch.xml | 11 +++ 4 files changed, 44 insertions(+) diff --git a/lib/netdev.c b/lib/netdev.c index f7b80b2..977844a

[ovs-dev] [PATCH ovs V6 05/24] dpif: Save added ports in a port map for netdev flow api use

From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

This patch series introduces rule offload functionality to dpif-netlink via netdev ports new flow offloading API. The user can specify whether to enable rule offloading or not via OVS configuration. Netdev providers are able to implement netdev flow offload API in order to offload rules. This patc

[ovs-dev] [PATCH ovs V6 02/24] netdev: Adding a new netdev api to be used for offloading flows

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c| 1 + lib/netdev-dummy.c | 2 + lib/netdev-linux.c | 15 +++-- lib/netdev-linux.h

[ovs-dev] [PATCH ovs V6 01/24] tc: Add tc flower interface

-by: Shahar Klein Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk|2 + lib/netdev-linux.c | 164 ++-- lib/tc.c | 1109 lib/tc.h | 128 ++ 4 files changed

[ovs-dev] [PATCH ovs V6 06/24] dpif-netlink: Flush added ports using netdev flow api

From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 5 + lib/netdev.c | 12 lib/netdev.h | 1 + 3 files

[ovs-dev] [PATCH ovs V6 07/24] netdev-tc-offloads: Implement netdev flow flush using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 946c2a6..2ea7fe3 100644

[ovs-dev] [PATCH ovs V6 09/24] netdev-tc-offloads: Add ufid to tc/netdev map

From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon

[ovs-dev] [PATCH ovs V6 08/24] dpif-netlink: Dump netdevs flows on flow dump

From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 179 - lib/netdev.c

[ovs-dev] [PATCH ovs V6 11/24] dpif-netlink: Use netdev flow put api to insert a flow

From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 213

[ovs-dev] [PATCH ovs V6 10/24] netdev-tc-offloads: Implement netdev flow dump api using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 182 --- 1 file changed, 174 insertions(+), 8 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc

[ovs-dev] [PATCH ovs V6 19/24] netdev-vport: Use common offloads interface

From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- lib/netdev-linux.c | 7 +++--- lib

[ovs-dev] [PATCH ovs V6 21/24] dpctl: Add an option to dump only certain kinds of flows

Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpctl.c | 21 ++- lib/dpctl.man | 7 - lib/dpif-netdev.c | 3 ++- lib/dpif-netlink.c| 62 ++- lib/dpif-provider.h

[ovs-dev] [PATCH ovs V6 20/24] netdev-tc-offloads: Add ingress on netdev flow api init

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 19aceba..2d0fe38

[ovs-dev] [PATCH ovs V6 22/24] tests: Add system-offloads-testsuite

From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed

[ovs-dev] [PATCH ovs V6 12/24] netdev-tc-offloads: Add flower mask to priority map

From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority for each new mask used. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 38

[ovs-dev] [PATCH ovs V6 24/24] netdev: Init flow api on already added ports on offload enable

From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 14 ++ 1 file changed, 14 insertions

[ovs-dev] [PATCH ovs V6 18/24] netdev-linux: Disallow setting policing when configured with hw offload

From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-linux.c | 8 1 file changed, 8 insertions(+) diff --git a/lib

[ovs-dev] [PATCH ovs V6 23/24] compat: Add tc compatibility headers for old kernels

headers. Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- acinclude.m4 | 26 ++ configure.ac | 1 + include/automake.mk | 1 + include/linux/automake.mk| 4 + include/linux

[ovs-dev] [PATCH ovs V6 14/24] dpif-netlink: Use netdev flow del api to delete a flow

From: Paul Blakey If a flow was offloaded to a netdev we delete it using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 12 +++- lib/netdev.c | 15 +++ lib/netdev.h | 2 ++ 3 files

[ovs-dev] [PATCH ovs V6 13/24] netdev-tc-offloads: Implement netdev flow put using tc interface

From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 2 +- lib/netdev-tc-offloads.c | 324 ++- 2 files changed, 318 insertions

[ovs-dev] [PATCH ovs V6 15/24] netdev-tc-offloads: Implement netdev flow del using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 48a98eb

[ovs-dev] [PATCH ovs V6 16/24] dpif-netlink: Use netdev flow get api to query a flow

From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 50 +- lib/netdev.c

[ovs-dev] [PATCH ovs V6 17/24] netdev-tc-offloads: Implement flow get using tc interface

From: Paul Blakey Search the requested ufid for a offloaded flow, and if found, dump and parse it back to required format. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 49 ++-- 1 file

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On 31/03/2017 01:11, Marcelo Ricardo Leitner wrote: On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote: On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote: This patch series introduces rule offload functionality to dpif-netlink via netdev ports new flow offloading

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On 02/04/2017 06:50, Roi Dayan wrote: On 31/03/2017 01:11, Marcelo Ricardo Leitner wrote: On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote: On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote: This patch series introduces rule offload functionality to dpif

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 29/03/2017 20:13, Joe Stringer wrote: On 29 March 2017 at 04:50, Roi Dayan wrote: On 23/03/2017 09:01, Joe Stringer wrote: I ran the make check-offloads tests on a recent net-next kernel and it failed, output was not as expected: ../../tests/system-offloaded-traffic.at:54 <h

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 04/04/2017 23:53, Joe Stringer wrote: On 3 April 2017 at 10:53, Joe Stringer wrote: On 3 April 2017 at 03:27, Roi Dayan wrote: On 29/03/2017 20:13, Joe Stringer wrote: On 29 March 2017 at 04:50, Roi Dayan wrote: On 23/03/2017 09:01, Joe Stringer wrote: I ran the make check

Re: [ovs-dev] [PATCH ovs V6 22/24] tests: Add system-offloads-testsuite

On 04/04/2017 23:47, Joe Stringer wrote: On 29 March 2017 at 05:43, Roi Dayan wrote: From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On 04/04/2017 21:40, Joe Stringer wrote: On 4 April 2017 at 06:21, Paul Blakey wrote: On 03/04/2017 21:00, Joe Stringer wrote: On 1 April 2017 at 20:50, Roi Dayan wrote: On 31/03/2017 01:11, Marcelo Ricardo Leitner wrote: On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 05/04/2017 07:18, Roi Dayan wrote: On 04/04/2017 23:53, Joe Stringer wrote: On 3 April 2017 at 10:53, Joe Stringer wrote: On 3 April 2017 at 03:27, Roi Dayan wrote: On 29/03/2017 20:13, Joe Stringer wrote: On 29 March 2017 at 04:50, Roi Dayan wrote: On 23/03/2017 09:01, Joe

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 05/04/2017 10:08, Joe Stringer wrote: On 4 April 2017 at 21:18, Roi Dayan wrote: On 04/04/2017 23:53, Joe Stringer wrote: On 3 April 2017 at 10:53, Joe Stringer wrote: On 3 April 2017 at 03:27, Roi Dayan wrote: On 29/03/2017 20:13, Joe Stringer wrote: On 29 March 2017 at 04

[ovs-dev] [PATCH ovs V7 04/24] other-config: Add tc-policy switch to control tc flower flag

: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 6 ++ lib/tc.c | 43 ++- lib/tc.h | 1 + vswitchd/vswitch.xml | 17 + 4 files changed, 66 insertions(+), 1 deletion(-) diff --git a/lib/netdev.c

[ovs-dev] [PATCH ovs V7 06/24] dpif-netlink: Flush added ports using netdev flow api

From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 5 + lib/netdev.c | 12 lib/netdev.h | 1 + 3 files

[ovs-dev] [PATCH ovs V7 03/24] other-config: Add hw-offload switch to control netdev flow offloading

-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 30 ++ lib/netdev.h | 2 ++ vswitchd/bridge.c| 1 + vswitchd/vswitch.xml | 11 +++ 4 files changed, 44 insertions(+) diff --git a/lib/netdev.c b/lib/netdev.c index f7b80b2..977844a

[ovs-dev] [PATCH ovs V7 05/24] dpif: Save added ports in a port map for netdev flow api use

From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V7 00/24] Introducing HW offload support for openvswitch

This patch series introduces rule offload functionality to dpif-netlink via netdev ports new flow offloading API. The user can specify whether to enable rule offloading or not via OVS configuration. Netdev providers are able to implement netdev flow offload API in order to offload rules. This patc

[ovs-dev] [PATCH ovs V7 12/24] netdev-tc-offloads: Add flower mask to priority map

From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority for each new mask used. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 38

[ovs-dev] [PATCH ovs V7 14/24] dpif-netlink: Use netdev flow del api to delete a flow

From: Paul Blakey If a flow was offloaded to a netdev we delete it using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 12 +++- lib/netdev.c | 15 +++ lib/netdev.h | 2 ++ 3 files

[ovs-dev] [PATCH ovs V7 11/24] dpif-netlink: Use netdev flow put api to insert a flow

From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 213

[ovs-dev] [PATCH ovs V7 10/24] netdev-tc-offloads: Implement netdev flow dump api using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 182 --- 1 file changed, 174 insertions(+), 8 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc

[ovs-dev] [PATCH ovs V7 09/24] netdev-tc-offloads: Add ufid to tc/netdev map

From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon

[ovs-dev] [PATCH ovs V7 15/24] netdev-tc-offloads: Implement netdev flow del using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 4ef29d1

[ovs-dev] [PATCH ovs V7 08/24] dpif-netlink: Dump netdevs flows on flow dump

From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 179 - lib/netdev.c

[ovs-dev] [PATCH ovs V7 13/24] netdev-tc-offloads: Implement netdev flow put using tc interface

From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 4 +- lib/netdev-tc-offloads.c | 390 ++- 2 files changed, 386 insertions

[ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c| 1 + lib/netdev-dummy.c | 2 + lib/netdev-linux.c | 15 +++-- lib/netdev-linux.h

[ovs-dev] [PATCH ovs V7 18/24] netdev-linux: Disallow setting policing when configured with hw offload

From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-linux.c | 8 1 file changed, 8 insertions(+) diff --git a/lib

[ovs-dev] [PATCH ovs V7 01/24] tc: Add tc flower interface

-by: Shahar Klein Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk|2 + lib/netdev-linux.c | 164 ++-- lib/tc.c | 1109 lib/tc.h | 128 ++ 4 files changed

[ovs-dev] [PATCH ovs V7 16/24] dpif-netlink: Use netdev flow get api to query a flow

From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 50 +- lib/netdev.c

[ovs-dev] [PATCH ovs V7 07/24] netdev-tc-offloads: Implement netdev flow flush using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 946c2a6..2ea7fe3 100644

[ovs-dev] [PATCH ovs V7 17/24] netdev-tc-offloads: Implement flow get using tc interface

From: Paul Blakey Search the requested ufid for a offloaded flow, and if found, dump and parse it back to required format. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 49 ++-- 1 file

[ovs-dev] [PATCH ovs V7 19/24] netdev-vport: Use common offloads interface

From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- lib/netdev-linux.c | 7 +++--- lib

[ovs-dev] [PATCH ovs V7 20/24] netdev-tc-offloads: Add ingress on netdev flow api init

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 1fd5120..808b761

[ovs-dev] [PATCH ovs V7 21/24] dpctl: Add an option to dump only certain kinds of flows

Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpctl.c | 21 ++- lib/dpctl.man | 7 - lib/dpif-netdev.c | 3 ++- lib/dpif-netlink.c| 62 ++- lib/dpif-provider.h

[ovs-dev] [PATCH ovs V7 23/24] compat: Add tc compatibility headers for old kernels

headers. Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- acinclude.m4 | 26 ++ configure.ac | 1 + include/automake.mk | 1 + include/linux/automake.mk| 4 + include/linux

[ovs-dev] [PATCH ovs V7 24/24] netdev: Init flow api on already added ports on offload enable

From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 14 ++ 1 file changed, 14 insertions

[ovs-dev] [PATCH ovs V7 22/24] tests: Add system-offloads-testsuite

From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed

[ovs-dev] [PATCH ovs] Documentation: fix broken links in maintainers page

The links were pointing to static non-existent location instead of internal doc link. Signed-off-by: Roi Dayan --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 28831ab..36c8d58 100644 --- a/MAINTAINERS.rst +++ b

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

On 14/04/2017 04:01, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- @@ -769,6 +777,49 @@ struct netdev_class { /* Discards all packets waiting to be received from

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

On 14/04/2017 04:11, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- diff --git a/lib/netdev.h b/lib/netdev.h index d6c07c1..6d2db7d 100644 --- a/lib/netdev.h +++ b/lib

Re: [ovs-dev] [PATCH ovs] Documentation: fix broken links in maintainers page

On 18/04/2017 19:26, Stephen Finucane wrote: On Tue, 2017-04-18 at 15:08 +0300, Roi Dayan wrote: The links were pointing to static non-existent location instead of internal doc link. Signed-off-by: Roi Dayan --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[ovs-dev] [PATCH ovs V2] Documentation: fix broken links in maintainers page

Missing the internals sub folder. Signed-off-by: Roi Dayan --- V2 - fix links but keep GitHub style as it's a top-level document MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 28831ab..60fa1f5 100644

Re: [ovs-dev] [PATCH ovs V7 05/24] dpif: Save added ports in a port map for netdev flow api use

On 14/04/2017 03:26, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to

Re: [ovs-dev] [PATCH ovs V7 08/24] dpif-netlink: Dump netdevs flows on flow dump

On 14/04/2017 03:51, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib

Re: [ovs-dev] [PATCH ovs V7 09/24] netdev-tc-offloads: Add ufid to tc/netdev map

On 14/04/2017 03:55, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of

Re: [ovs-dev] [PATCH ovs V7 15/24] netdev-tc-offloads: Implement netdev flow del using tc interface

On 14/04/2017 04:15, Joe Stringer wrote: On 7 April 2017 at 06:13, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3

Re: [ovs-dev] [PATCH ovs V7 11/24] dpif-netlink: Use netdev flow put api to insert a flow

On 14/04/2017 04:08, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul

Re: [ovs-dev] [PATCH ovs V7 19/24] netdev-vport: Use common offloads interface

On 14/04/2017 04:19, Joe Stringer wrote: On 7 April 2017 at 06:13, Roi Dayan wrote: From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey

Re: [ovs-dev] [PATCH ovs V7 21/24] dpctl: Add an option to dump only certain kinds of flows

On 12/04/2017 20:04, Joe Stringer wrote: On 12 April 2017 at 08:22, Flavio Leitner wrote: On Fri, Apr 07, 2017 at 04:13:08PM +0300, Roi Dayan wrote: From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

On 24/04/2017 14:35, Simon Horman wrote: On Tue, Apr 18, 2017 at 03:18:55PM +0300, Roi Dayan wrote: On 14/04/2017 04:11, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

ption to dump only certain kinds of flows tests: Add system-offloads-testsuite compat: Add tc compatibility headers for old kernels netdev: Init flow api on already added ports on offload enable Roi Dayan (2): dpif: Refactor flow logging functions to be used by other modules dpif-

[ovs-dev] [PATCH ovs V8 01/26] tc: Add tc flower interface

-by: Shahar Klein Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk|2 + lib/netdev-linux.c | 164 ++-- lib/tc.c | 1109 lib/tc.h | 128 ++ 4 files changed

[ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c| 1 + lib/netdev-dummy.c | 2 + lib/netdev-linux.c | 15 +++-- lib/netdev-linux.h

[ovs-dev] [PATCH ovs V8 03/26] other-config: Add hw-offload switch to control netdev flow offloading

-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 30 ++ lib/netdev.h | 2 ++ vswitchd/bridge.c| 1 + vswitchd/vswitch.xml | 11 +++ 4 files changed, 44 insertions(+) diff --git a/lib/netdev.c b/lib/netdev.c index 1677027..90c95cb

[ovs-dev] [PATCH ovs V8 04/26] other-config: Add tc-policy switch to control tc flower flag

: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 6 ++ lib/tc.c | 43 ++- lib/tc.h | 1 + vswitchd/vswitch.xml | 17 + 4 files changed, 66 insertions(+), 1 deletion(-) diff --git a/lib/netdev.c

  1   2   3   4   5   6   7   8   9   10   >