[ovs-dev] [PATCH] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-07 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

[ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-14 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-18 Thread Sriram Vatala via dev
Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 14 June 2019 19:08 To: ovs-dev@openvswitch.org Cc: Sriram Vatala Subject: [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports OVS may be unable to

Re: [ovs-dev] [PATCH] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-12 Thread Sriram Vatala via dev
Hi Ilya, Sorry for the late reply. Yes, whatever you suggested is doable. As of now ovs-bugtool has only dpctl/show command and i think we need to add this command "ovs-vsctl get interface" to ovs-bugtool. I will float the updated patch ASAP. Thanks & Regards, Sriram. -Original

Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-19 Thread Sriram Vatala via dev
ation directory. Maybe it's not strictly necessary for all stats, but when there's small explanations in the commit message for these ones, seems like they might be helpful in the docs. thanks, Kevin. > Thanks & Regards, > Sriram. > > -Original Message- > Fr

Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-19 Thread Sriram Vatala via dev
sctl. what do you think? Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 19 June 2019 01:09 To: Sriram Vatala ; ovs-dev@openvswitch.org Cc: Ilya Maximets Subject: Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports On 18/06/201

Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-19 Thread Sriram Vatala via dev
sctl. what do you think? Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 19 June 2019 01:09 To: Sriram Vatala ; ovs-dev@openvswitch.org Cc: Ilya Maximets Subject: Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports On 18/

[ovs-dev] [PATCH v4] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-16 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

[ovs-dev] [PATCH v3] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-15 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-06-25 Thread Sriram Vatala via dev
kely reason. Thanks, Pradeep -Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of Sriram Vatala via dev Sent: Wednesday, June 19, 2019 8:44 PM To: 'Kevin Traynor' ; ovs-dev@openvswitch.org Cc: 'Ilya Maximets' Subject: Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics

Re: [ovs-dev] [PATCH v2] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-02 Thread Sriram Vatala via dev
for sure the drop reason. If we want to use a generic name perhaps we can update the documentation to highlight the likely reason. Thanks, Pradeep -Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of Sriram Vatala via dev Sent: Wednesday, June 19, 2019 8:44 PM To: 'Kevin

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

2019-08-19 Thread Sriram Vatala via dev
-Original Message- From: Ilya Maximets Sent: 09 August 2019 17:44 To: ovs-dev@openvswitch.org Cc: Ian Stokes ; Kevin Traynor ; David Marchand ; Sriram Vatala ; Ilya Maximets Subject: [PATCH 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility. vHost interfaces currently

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-30 Thread Sriram Vatala via dev
Hi All, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 28 August 2019 18:29 To: ovs-dev@openvswitch.org; i.maxim...@samsung.com Cc: b...@ovn.org; ian.sto...@intel.com; Sriram Vatala Subject: [PATCH v7] Detailed packet

[ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

Re: [ovs-dev] [PATCH v6] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread Sriram Vatala via dev
Hi All, The patch " netdev-dpdk: Refactor vhost custom stats for extensibility" by Ilya is merged to master. So I will rebase and send updated patch to avoid any git conflicts. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 26 August 2019 18:29 To:

[ovs-dev] [PATCH v6] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-26 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-02 Thread Sriram Vatala via dev
Hi Ilya, Thanks for reviewing the patch and suggestions. Will address your comments in next patch. Thanks & Regards, Sriram. -Original Message- From: Ilya Maximets Sent: 30 August 2019 18:53 To: Sriram Vatala ; ovs-dev@openvswitch.org Cc: b...@ovn.org; ian.sto...@intel.com; Kevin

Re: [ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-23 Thread Sriram Vatala via dev
-Original Message- From: Ilya Maximets Sent: 06 August 2019 22:02 To: Sriram Vatala ; 'Ben Pfaff' ; 'Stokes, Ian' Cc: ovs-dev@openvswitch.org Subject: Re: [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports On 24.07.2019 11:55, Sriram Vatala wrote: > Hi, > > @Ben

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-04 Thread Sriram Vatala via dev
Hi Ilya, 1) I was working on addressing the comments provided by you. Had a small query on one of your comments. 2) I am trying to understand the problem of padding bytes in struct netdev_dpdk which you are referring to in your comment. 3) If I understand correctly, the macro

Re: [ovs-dev] [PATCH v8] netdev-dpdk:Detailed packet drop statistics

2019-09-10 Thread Sriram Vatala via dev
Hi All, I have addressed the comments given in patch v7. Please review the patch v8 and let me know your comments if any. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 08 September 2019 21:32 To: ovs-dev@openvswitch.org; i.maxim...@samsung.com Cc:

Re: [ovs-dev] [PATCH v8] netdev-dpdk:Detailed packet drop statistics

2019-09-10 Thread Sriram Vatala via dev
-Original Message- From: Ilya Maximets Sent: 10 September 2019 19:29 To: Sriram Vatala ; ovs-dev@openvswitch.org Cc: ktray...@redhat.com; ian.sto...@intel.com Subject: Re: [PATCH v8] netdev-dpdk:Detailed packet drop statistics On 08.09.2019 19:01, Sriram Vatala wrote: > OVS may be unable

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-05 Thread Sriram Vatala via dev
Hi Ilya, Thanks a lot for the explanation. As per your suggestion, I will move all the counters (including 'tx_retries')to some structure and place a pointer to it in netdev_dpdk structure so that the padding size will not vary with the introduction of new counters in future. @Kevin Traynor :

[ovs-dev] [PATCH v8] netdev-dpdk:Detailed packet drop statistics

2019-09-08 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

Re: [ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-04 Thread Sriram Vatala via dev
Please consider this as a gentle remainder. Thanks, Sriram. -Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of Sriram Vatala via dev Sent: 24 July 2019 14:26 To: 'Ben Pfaff' ; 'Ilya Maximets' ; 'Stokes, Ian' Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH v4] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-17 Thread Sriram Vatala via dev
-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4] Detailed packet drop statistics per dpdk and vhostuser ports On Tue, Jul 16, 2019 at 07:02:29PM +0530, Sriram Vatala via dev wrote: > OVS may be unable to transmit packets for multiple reasons and today > there is a single counter to

Re: [ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-24 Thread Sriram Vatala via dev
Hi, @Ben : Thanks for the response. @Ilya, @Ian : Can you please review the patch and provide comments if any. Thanks, Sriram. -Original Message- From: Ben Pfaff Sent: 22 July 2019 21:37 To: Sriram Vatala Cc: ovs-dev@openvswitch.org Subject: Re: [PATCH v5] Detailed packet drop

[ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-22 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

[ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-09-22 Thread Sriram Vatala via dev
From: Ilya Maximets This is yet another refactoring for upcoming detailed drop stats. It allowes to use single function for all the software calculated statistics in netdev-dpdk for both vhost and ETH ports. UINT64_MAX used as a marker for non-supported statistics in a same way as it's done in

[ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-09-22 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

Re: [ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-30 Thread Sriram Vatala via dev
Hi All, Please review the update patch. Changes since v10 : Corrected the spelling mistake in the commit message. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 29 October 2019 20:20 To: ovs-dev@openvswitch.org; ktray...@redhat.com; i.maxim...@ovn.org Cc: Ilya

[ovs-dev] [PATCH v11 2/3] netdev-dpdk : Detailed packet drop statistics

2019-10-30 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons on the userspace datapath and today there is a single counter to track packets dropped due to any of those reasons. This patch adds custom software stats for the different reasons packets may be dropped during tx/rx on the userspace

[ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-30 Thread Sriram Vatala via dev
From: Ilya Maximets This is yet another refactoring for upcoming detailed drop stats. It allows to use single function for all the software calculated statistics in netdev-dpdk for both vhost and ETH ports. UINT64_MAX used as a marker for non-supported statistics in a same way as it's done in

Re: [ovs-dev] [PATCH v10 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-30 Thread Sriram Vatala via dev
Thanks Kevin for reviewing and acknowledging the patch. I will correct the spelling and send the updated patch. Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 25 October 2019 20:36 To: Sriram Vatala ; ovs-dev@openvswitch.org; i.maxim...@ovn.org Cc: Ilya

[ovs-dev] [PATCH v11 3/3] ovs-bugtool: Script to collect the port statistics

2019-10-30 Thread Sriram Vatala via dev
Sometimes, analysing the drop statistics of the ports will be helpful in debugging. This patch adds script to collect all supported port stats which also includes the drop counters in userspace datapath. The output of this script is included in the bugtool output. Signed-off-by: Sriram Vatala

Re: [ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-11-04 Thread Sriram Vatala via dev
Hi All, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 30 October 2019 11:57 To: 'ovs-dev@openvswitch.org' ; 'ktray...@redhat.com' ; 'i.maxim...@ovn.org' Cc: 'Ilya Maximets' Subject: RE: [PATCH v11 1/3] netdev-dpdk:

Re: [ovs-dev] [PATCH v11 2/3] netdev-dpdk : Detailed packet drop statistics

2019-11-11 Thread Sriram Vatala via dev
Hi Ilya, Thanks for the review. I agree with your proposal to move the stats update code to existing special functions. Thanks for the incremental patch, it looks good to me. Will wait for Kevin's taught on this. Thanks & Regards, Sriram. -Original Message- From: Ilya Maximets Sent:

Re: [ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-31 Thread Sriram Vatala via dev
Hi, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 30 October 2019 11:57 To: 'ovs-dev@openvswitch.org' ; 'ktray...@redhat.com' ; 'i.maxim...@ovn.org' Cc: 'Ilya Maximets' Subject: RE: [PATCH v11 1/3] netdev-dpdk:

Re: [ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-11-05 Thread Sriram Vatala via dev
Thanks Kevin for your response. @i.maxim...@ovn.org : Can you please review the patch set. Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 05 November 2019 16:07 To: Sriram Vatala ; ovs-dev@openvswitch.org; i.maxim...@ovn.org Cc: 'Ilya Maximets' Subject: Re:

Re: [ovs-dev] [PATCH v10 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-25 Thread Sriram Vatala via dev
Hi, Please review the patch set v10. Changes since v9 : Patch - 1: Fixed the issue with index inside the for loop for copying the dpdk extended stats inside 'netdev_dpdk_get_custom_stats' function. Patch - 2: Modified the commit message. Changed the custom stats prefix from 'netdev_dpdk_' to

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Sriram Vatala via dev
-Original Message- From: Kevin Traynor Sent: 15 October 2019 19:21 To: Ilya Maximets ; Sriram Vatala ; ovs-dev@openvswitch.org Subject: Re: [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats. On 15/10/2019 14:43, Ilya Maximets wrote: > On 15.10.2019 15:35, Kevin

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-14 Thread Sriram Vatala via dev
Hi, Please consider this as gentle remainder and kindly review the patch set. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 11 October 2019 16:58 To: 'ovs-dev@openvswitch.org' ; 'i.maxim...@ovn.org' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-16 Thread Sriram Vatala via dev
Hi Kevin & Ilya, Thanks Kevin for reviewing the patch. Response inline. Thanks Ilya for your response. -Original Message- From: Ilya Maximets Sent: 16 October 2019 17:46 To: Kevin Traynor ; Sriram Vatala ; ovs-dev@openvswitch.org; Ilya Maximets Cc: Stokes, Ian Subject: Re: [PATCH v9

[ovs-dev] [PATCH v10 3/3] ovs-bugtool: Script to collect the port statistics

2019-10-24 Thread Sriram Vatala via dev
Sometimes, analysing the drop statistics of the ports will be helpful in debugging. This patch adds script to collect all supported port stats which also includes the drop counters in userspace datapath. The output of this scirpt is included in the bugtool output. Signed-off-by: Sriram Vatala

[ovs-dev] [PATCH v10 2/3] netdev-dpdk : Detailed packet drop statistics

2019-10-24 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons on the userspace datapath and today there is a single counter to track packets dropped due to any of those reasons. This patch adds custom software stats for the different reasons packets may be dropped during tx/rx on the userspace

[ovs-dev] [PATCH v10 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-24 Thread Sriram Vatala via dev
From: Ilya Maximets This is yet another refactoring for upcoming detailed drop stats. It allowes to use single function for all the software calculated statistics in netdev-dpdk for both vhost and ETH ports. UINT64_MAX used as a marker for non-supported statistics in a same way as it's done in

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Sriram Vatala via dev
Thanks Ilya and Kevin. I will send the updated patch set. Thanks & Regards, Sriram. -Original Message- From: Ilya Maximets Sent: 22 October 2019 16:07 To: Kevin Traynor ; Sriram Vatala ; 'Ilya Maximets' ; ovs-dev@openvswitch.org Cc: 'Stokes, Ian' Subject: Re: [PATCH v9 2/2]

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Sriram Vatala via dev
Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. 1) All custom stats calculated in OVS will have the prefix , so that these stats will not intersect with the names of other stats (driver/HW etc). 2) The prefix used for

Re: [ovs-dev] [PATCH v11 2/3] netdev-dpdk : Detailed packet drop statistics

2019-11-11 Thread Sriram Vatala via dev
Thanks Ilya and kevin. Regards, Sriram. -Original Message- From: Ilya Maximets Sent: 12 November 2019 00:08 To: Ilya Maximets ; Kevin Traynor ; Sriram Vatala ; ovs-dev@openvswitch.org Subject: Re: [PATCH v11 2/3] netdev-dpdk : Detailed packet drop statistics On 11.11.2019 17:11, Ilya

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-09-24 Thread Sriram Vatala via dev
Hi, Addressed comments given in patch v8. Kindly review patch v9. Changes since patch v8 : Rebased my changes on top of Ilya's patch " Reuse vhost function for dpdk ETH custom stats". Patch set 1/2. Addressed comments given in patch v8. Thanks & Regards, Sriram. -Original Message-

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-09 Thread Sriram Vatala via dev
Hi All, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 04 October 2019 13:37 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-04 Thread Sriram Vatala via dev
Hi, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 25 September 2019 09:58 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-11 Thread Sriram Vatala via dev
Hi, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 09 October 2019 11:53 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' ; 'i.maxim...@ovn.org' Subject: RE: [PATCH v9 2/2]