Move tunnel neigh snooping from do_xlate_actions() to
terminate_native_tunnel() in order to keep ARP neighbor cache clean.
Furthermore filter ARP reply and Neighbor Advertisement messages
addressing tunnel endpoint.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
include/
-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
tests/tunnel-push-pop-ipv6.at | 14 +++---
tests/tunnel-push-pop.at | 24
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/tests/tunnel-push-pop-ipv6.at b/tests/tunnel-push-pop-ipv6.at
-dpif-xlate when native_tunnel_output() is invoked. Otherwise the
output action of underlay bridge is getting counted as well if sFlow is
set on the overlay bridge.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
CC: Sugesh Chandran <sugesh.chand...@intel.com>
---
ofproto/
only tunnel neighbor data should be stored there.
In worst case tunnel peer data could be overwritten in the cache. Which
triggers revalidation as well.
This series resolves the issue, by trying to snoop ARP and ND messages
addressing tunnel end point in current bridge.
Zoltan Balogh (3
only tunnel neighbor data should be stored there.
In worst case tunnel peer data could be overwritten in the cache. Which
triggers revalidation as well.
This series resolves the issue, by trying to snoop ARP and ND messages
addressing tunnel end point in current bridge.
Zoltan Balogh (3
-dpif-xlate when native_tunnel_output() is invoked. Otherwise the
output action of underlay bridge is getting counted as well if sFlow is
set on the overlay bridge.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
ofproto/ofproto-dpif-sflow.c
-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
tests/tunnel-push-pop-ipv6.at | 14 +++---
tests/tunnel-push-pop.at | 24
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/tests/tunnel-push-pop-ipv6.at b/tests/tunnel-push-pop-ipv6.at
Move tunnel neigh snooping from do_xlate_actions() to
terminate_native_tunnel() in order to keep ARP neighbor cache clean.
Furthermore filter ARP reply and Neighbor Advertisement messages
addressing tunnel endpoint.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
include/
. It looks for
L3 tunnel port in case of L2 packet and vice versa.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
CC: Jan Scheurich <jan.scheur...@ericsson.com>
CC: Ben Pfaff <b...@ovn.org>
Fixes: 875ab13020b1 ("userspace: Handling of versatile tunnel ports"
When all OF actions have been translated, there could be actions at
the end of list of odp actions which are not needed to be executed.
So, the list can be normalized at the end of xlate_actions().
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
Signed-off-by: Sugesh Ch
.
With this series, these actions are omitted.
Zoltan Balogh (2):
xlate: rollback to valid known state in case of ctx->error on
translation
xlate: normalize the actions after translation
ofproto/ofproto-dpif-xlate.c | 204 ++
ming commit is going to implement 2).
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
Signed-off-by: Sugesh Chandran <sugesh.chand...@intel.com>
Co-authored-by: Sugesh Chandran <sugesh.chand...@intel.com>
CC: Ben Pfaff <b...@ovn.org>
CC: Jan Scheu
When all OF actions have been translated, there could be actions at
the end of list of odp actions which are not needed to be executed.
So, the list can be normalized at the end of xlate_actions().
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
Signed-off-by: Sugesh Ch
When all OF actions have been translated, there could be actions at
the end of list of odp actions which are not needed to be executed.
So, the list can be normalized at the end of xlate_actions().
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
Signed-off-by: Sugesh Ch
During translation of OF actions on a bridge, we can store the last
valid state of translated actions while iterating over the OF actions
and revert to it in case of error. This can be performed in the
do_xlate_actions() funtion.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
.
With this series, these actions are omitted.
Zoltan Balogh (2):
xlate: rollback to valid known state in case of ctx->error on
translation
xlate: normalize the actions after translation
ofproto/ofproto-dpif-xlate.c | 178 +
tests/ofproto-dpif.at
. Datapath flows can be checked in normal PTAP unit
tests by running 'make check'.
Reported-by: Darrell Ball <db...@vmware.com>
Suggested-by: Jan Scheurich <jan.scheur...@ericsson.com>
Tested-by: Darrell Ball <db...@vmware.com>
Signed-off-by: Zoltan Balogh <zoltan.bal...@eri
only tunnel neighbor data should be stored there.
In worst case tunnel peer data could be overwritten in the cache. Which
triggers revalidation as well.
This series resolves the issue, by trying to snoop ARP and ND messages
addressing native tunnel end point in current bridge.
Zoltan Balogh (3
extracted from an ARP or
Neighbor Advertisement message in is_neighbor_reply_correct() which is
invoked from terminate_native_tunnel().
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
include/sparse/netinet/in.h | 10 +++
ofproto/ofproto-dpif-xlate.c
-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
tests/tunnel-push-pop-ipv6.at | 14 +++---
tests/tunnel-push-pop.at | 24
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/tests/tunnel-push-pop-ipv6.at b/tests/tunnel-push-pop-ipv6.at
and restored in
ofproto-dpif-xlate when native_tunnel_output() is invoked. Otherwise the
output action of underlay bridge is getting counted too when sFlow is set
on the overlay bridge.
Both bugs are connected to sflows and were introduced by the commit in
the "Fixes:" tag below.
Signed-off-
are unit tests are updated with a new one to verify
this behavior.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
CC: Jan Scheurich <jan.scheur...@ericsson.com>
Fixes: beb75a40fdc2 ("userspace: Switching of L3 packets in L2 pipeline")
Signed-off-by: Ben Pfaff &l
by using the saved UUID
and xlate_lookup() should not be invoked.
Zoltan Balogh (2):
ofproto-dpif-xlate: add uuid to xports
xlate: fix xport lookup for recirc
ofproto/ofproto-dpif-rid.c | 5 +-
ofproto/ofproto-dpif-rid.h | 1 +
ofproto/ofproto-dpif-xlate.c | 64
This should make possible to look up xport by UUID and will be used by a
later commit.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
Signed-off-by: Ben Pfaff <b...@ovn.org>
---
ofproto/ofproto-dpif-xlate.c | 12
1 file changed, 12 insertions(+)
diff --g
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
CC: Zoltan Balogh <zoltan.balogh@gmail.com>
---
AUTHORS.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 5fbb27653..2ef51dcef 100644
--- a/AUTHORS.rst
+++ b
This should make possible to look up xport by UUID and will be used by a
later commit.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
---
ofproto/ofproto-dpif-xlate.c | 12
1 file changed, 12 insertions(+)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofprot
are unit tests are updated with a new one to verify
this behavior.
Signed-off-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
CC: Jan Scheurich <jan.scheur...@ericsson.com>
Fixes: beb75a40fdc2 ("userspace: Switching of L3 packets in L2
pipeline")
---
ofproto/ofproto-dpif-
packet
was received on in frozen state in case of recirculation. So, when upcall is
processed due to recirculation then xport can be found by using the saved UUID
and xlate_lookup() should not be invoked.
Zoltan Balogh (2):
ofproto-dpif-xlate: add uuid to xports
xlate: fix xport lookup for recirc
28 matches
Mail list logo
