Re: [ovs-dev] [PATCH v2 2/2] python: Force file system encoding on cmdline args

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Russell Bryant > Sent: Friday, August 18, 2017 11:18 PM > To: Alin Balutoiu > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2

Re: [ovs-dev] [PATCH] windows, python: set the reset event to automatic

Me and Alin talked about this offline. In the case of named pipes you need events with manual reset and initial signaled state. We need a different event when dealing with sockets on Windows, he will address this in a new patch. While looking over the code we see another good reason for using

Re: [ovs-dev] [PATCH] windows, python: Fix event type returned from poller

Does it make sense to use python ctypes instead of pypiwin32? It seems better to make our own calls instead of using wrappers which treat just certain cases. Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >

Re: [ovs-dev] [PATCH] windows, python: Remove code duplication in send/recv functions

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Tuesday, August 22, 2017 1:47 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] windows,

Re: [ovs-dev] [PATCH] windows, python: set the reset event to automatic

I forgot to mention why you need the events on manual reset: https://msdn.microsoft.com/en-us/library/windows/desktop/ms684342(v=vs.85).a spx "Functions such as ReadFile and WriteFile set this handle to the nonsignaled state before they begin an I/O operation. When the operation has completed,

Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command

Thanks Mark! I applied this on master and branch-2.8. Ben: Thanks for the encouragement . Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, September 12, 2017 2:03 AM > To:

Re: [ovs-dev] [PATCH] datapath-windows: Remove the workaround in NAT for TCP checksum

Thanks so much for the patch! Sorry for the long delay in testing. Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Saturday, September 16, 2017

Re: [ovs-dev] [PATCH] ovs-atomic-msvc: Add atomics x64 builds

I sent out a new version changing the commit message. Please disregard this patch. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Wednesday, September 6, 2017 1:30 AM > To:

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

I added a missing curly bracket to make it compile. Thanks Anand I applied it on master and branch-2.8. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of aserd...@ovn.org > Sent: Thursday, September 7, 2017 9:54

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

Acked-by: Alin Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Wednesday, September 6, 2017 2:53 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of atomic_store_relaxed().

Thanks a lot for fixing this! Acked-by: Alin Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Wednesday, September 6, 2017 6:58 PM > To: d...@openvswitch.org > Cc: Ben Pfaff

Re: [ovs-dev] [PATCH] github: Add Appveyor image and link to Readme

Thanks! I applied this on master. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Wednesday, September 6, 2017 7:06 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org >

Re: [ovs-dev] [PATCH v2] ovs-atomic-msvc: Add atomics x64 builds

Thanks for the quick review. I applied it on master. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Wednesday, September 6, 2017 7:06 PM > To: Alin Gabriel Serdean > Cc:

Re: [ovs-dev] [PATCH] windows, python: remove dead code in send_wait

Thanks Anand and Alin! I applied on master, branch-2.8 and branch-2.7. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Thursday, September 7, 2017 11:08 PM > To: aserd...@ovn.org; Alin

Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command

Tested-by: Alin Gabriel Serdean Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Mark Michelson > Sent: Monday, September 11, 2017 11:58 PM > To:

Re: [ovs-dev] [PATCH] tests: Skip OVN test if truncate command not found

Do you mind sending out a patch for it? Alin. Patch is here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338627.html [Alin Serdean] Thanks! I tested and acked it. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] tests: Fix sparse error on test-ovn.c

Thanks Shashank! I applied on master, branch-2.8, branch-2.7, branch-2.6. Alin. > -Original Message- > From: Shashank Ram [mailto:r...@vmware.com] > Sent: Tuesday, September 12, 2017 6:56 AM > To: Alin Gabriel Serdean ; d...@openvswitch.org > Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH] windows, python: Add restrictions to named pipes

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Wednesday, August 23, 2017 5:51 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] windows, python: Add restrictions to named pipes

Thanks Anand and Alin. I applied the patch on master, branch-2.8, branch-2.7. > -Original Message- > From: Anand Kumar [mailto:kumaran...@vmware.com] > Sent: Friday, September 8, 2017 2:10 AM > To: Alin Balutoiu ; > d...@openvswitch.org > Cc: Alin Serdean

Re: [ovs-dev] [PATCH 1/2] windows, python: create a different event for sockets

Thanks Russell and Alin! I applied the series on master, branch-2.8 and branch-2.7. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Russell Bryant > Sent: Tuesday, September 5, 2017 9:53 PM > To:

Re: [ovs-dev] [PATCH] tests: Fix MSVC compiler error on test-ovn.c

Thanks for the quick review. I applied it on master, branch-2.8, branch-2.7 and branch-2.6. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Monday, September 11, 2017 11:08 PM > To: Alin Gabriel

Re: [ovs-dev] [PATCH] windows, python: Remove code duplication in send/recv functions

Thanks Russell and Alin. I applied this on branch-2.7, branch-2.8 and master. Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Russell Bryant > Sent: Tuesday, August 22, 2017 3:32 PM > To: Alin Balutoiu

Re: [ovs-dev] [PATCH] datapath-windows: Move OvsCreateNewNBLsFromMultipleNBs to BuggerMgmt

Thanks Anand and Shashank! Acked-by: Alin Gabriel Serdean I applied this on branch-2.8 and master. Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Tuesday, August

Re: [ovs-dev] [PATCH v3] datapath-windows: Update Orig Tuple to use ICMP Type and Code

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Wednesday, August 16, 2017 9:23 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v3]

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

I applied this on master and branch-2.8 Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Thursday, August 17, 2017 10:47 PM > To: Anand Kumar ;

Re: [ovs-dev] [PATCH v3] datapath-windows: Update Orig Tuple to use ICMP Type and Code

I applied this on master and branch-2.8 Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of aserd...@ovn.org > Sent: Thursday, August 17, 2017 10:48 PM > To: 'Anand Kumar' ;

Re: [ovs-dev] [PATCH] windows, python: remove dead code in send_wait

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Friday, August 25, 2017 6:03 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH 1/2] windows, python: create a different event for sockets

CC: Russell Bryant ; Lance Richardson Can you please take a look? Tested-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu

Re: [ovs-dev] [PATCH 2/2] windows,python: remove unnecessary code

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Friday, August 25, 2017 6:03 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2]

Re: [ovs-dev] [RFC PATCH] daemon-windows: Set default error mode for services

Thanks, applied on master and branch-2.8. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Saturday, August 26, 2017 2:21 AM > To: Alin Gabriel Serdean ; d...@openvswitch.org

Re: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

Applied to master and branch-2.8. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent: Wednesday, August 30, 2017 11:29 PM > To: Sairam Venugopal ; d...@openvswitch.org >

Re: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent: Wednesday, August 30, 2017 11:29 PM > To: Sairam Venugopal ;

Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx

I applied this on master and branch-2.8. Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Thursday, August 31, 2017 2:04 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

Thanks Anand and Shashank, I applied this on master. > -Original Message- > From: Shashank Ram [mailto:r...@vmware.com] > Sent: Tuesday, November 28, 2017 8:18 AM > To: Anand Kumar ; d...@openvswitch.org; Alin > Serdean > Subject:

Re: [ovs-dev] [PATCH v1 2/3] datapath-windows: Add a global level RW lock for NAT

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Tuesday, November 14, 2017 8:48 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v1 2/3]

Re: [ovs-dev] [RFC PATCH v2] dpif-netdev: Add port/queue tiebreaker to rxq_cycle_sort.

> -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent: Thursday, November 23, 2017 3:30 PM > To: aserd...@ovn.org; 'Kevin Traynor' ; O Mahony, > Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [RFC PATCH v2]

Re: [ovs-dev] [PATCH v2 2/2] util: Add high resolution sleep support.

Looks ok to me. Acked-by: Alin Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Tuesday, November 14, 2017 10:43 PM > To: d...@openvswitch.org > Cc:

Re: [ovs-dev] [RFC PATCH v2] dpif-netdev: Add port/queue tiebreaker to rxq_cycle_sort.

> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, November 23, 2017 1:05 PM > To: O Mahony, Billy ; d...@openvswitch.org; > aserd...@ovn.org > Subject: Re: [ovs-dev] [RFC PATCH v2] dpif-netdev: Add port/queue > tiebreaker

Re: [ovs-dev] [PATCH v1] datapath-windows: Add support for deleting conntrack entry by 5-tuple.

I wanted to give it a few days to see if another review pops up. Mind if I wait until tomorrow? Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, November 29, 2017 7:44 PM > To: Alin Serdean > Cc: Anand Kumar

Re: [ovs-dev] [PATCH 3/7] util: High resolution sleep support for windows.

Thanks a lot for the patch. I have a few comments inlined. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Wednesday, November 8, 2017 6:36 PM > To: d...@openvswitch.org > Cc: Alin

Re: [ovs-dev] [PATCH 0/4] windows: Add support for compiling using 2015/2017

Thanks for the reviews. I applied the series on master. > -Original Message- > From: Alin Gabriel Serdean [mailto:aserd...@ovn.org] > Sent: Wednesday, November 1, 2017 7:19 PM > To: d...@openvswitch.org > Cc: Alin Gabriel Serdean > Subject: [PATCH 0/4] windows: Add

Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output from MSBuild

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, November 7, 2017 10:44 PM > To: 'Ben Pfaff' ; 'Alin Gabriel Serdean' > Cc: d...@openvswitch.org >

Re: [ovs-dev] [PATCH] ovn.at: Fix MSYS IPv6 interpretation

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, November 14, 2017 8:16 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] ovn.at: Fix

Re: [ovs-dev] [PATCH 0/6] installer fixes on msbuild64

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Wednesday, November 1, 2017 12:37 AM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/6]

Re: [ovs-dev] [PATCH v5 03/10] util: Add high resolution sleep support.

> Ben Pfaff writes: > > > On Mon, Nov 06, 2017 at 05:29:26PM +, Bodireddy, Bhanuprakash > wrote: > >> Hi Ben, > >> > > >> >On Fri, Sep 15, 2017 at 05:40:23PM +0100, Bhanuprakash Bodireddy > wrote: > >> >> This commit introduces xnanosleep() for the threads needing high > >> >>

Re: [ovs-dev] [PATCH 3/4] build-windows: Add check for struct timespec

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, November 3, 2017 8:38 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 3/4] build-windows: Add check for struct > timespec > > On Wed, Nov 01, 2017 at

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

I was concerned a bit about binary compatibility between the future userspace binaries and older kernel versions. But Windows users usually just use the MSI (because of the signing issues). Thanks both! Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Justin Pettit > Sent: Tuesday, December 5, 2017 9:30 AM > To: d...@openvswitch.org; Alin Gabriel Serdean ; > Sairam Venugopal >

Re: [ovs-dev] [PATCH] travis: Use pip2 instead of pip for OSX build.

I applied this on master. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of aserd...@ovn.org > Sent: Monday, December 11, 2017 4:23 PM > To: 'Ilya Maximets' ; ovs-dev@openvswitch.org > Cc: 'Lance

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 12, 2017 12:40 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > > On Mon, Dec 11, 2017 at

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl argument to match definition

Thanks Shashank and Sai. I pushed this on master. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent: Wednesday, October 25, 2017 10:53 PM > To: Sairam Venugopal ;

Re: [ovs-dev] [PATCH] Embrace anonymous unions.

> > On May 24, 2018, at 10:32 AM, Ben Pfaff wrote: > > > > Several OVS structs contain embedded named unions, like this: > > > > struct { > >... > >union { > >... > >} u; > > }; > > > > C11 standardized a feature that many compilers already implemented > >

Re: [ovs-dev] [PATCH v5 0/3] Optimize conntrack performance

> This patch series is primarily to refactor conntrack code for better throughput > with conntrack. > > With this patch series TCP throughput with conntrack increased by ~50%. > > Anand Kumar (3): > datapath-windows: Use spinlock instead of RW lock for ct entry > datapath-windows: Implement

Re: [ovs-dev] [PATCH v4 1/3] datapath-windows: Use spinlock instead of RW lock for ct entry

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Tuesday, June 19, 2018 8:33 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH v4 1/3] datapath-windows: Use spinlock instead of > RW lock for ct entry > > This

Re: [ovs-dev] [PATCH v4 3/3] datapath-windows: Compute ct hash based on 5-tuple and zone

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Tuesday, June 19, 2018 8:33 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH v4 3/3] datapath-windows: Compute ct hash > based on 5-tuple and zone > >

Re: [ovs-dev] [PATCH] dpif-netlink: Add meter support.

> > From: Andy Zhou > > To work with kernel datapath that supports meter. > > Signed-off-by: Andy Zhou > Co-authored-by: Justin Pettit > Signed-off-by: Justin Pettit > --- > Documentation/faq/releases.rst | 1 + > lib/dpif-netlink.c | 302 ++--- >

Re: [ovs-dev] [PATCH v2] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Thursday, October 19, 2017 11:26 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v2]

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

Thanks Ben! Applied on master. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, January 5, 2018 5:14 PM > To: aserd...@ovn.org > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and > VS2017 > > OK. > > Acked-by:

Re: [ovs-dev] [PATCH] ovn-northd.at: Fix MSYS IPv6 interpretation

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 10, 2018 11:16 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] ovn-northd.at: Fix MSYS IPv6 interpretation > > On Wed, Jan 10, 2018 at

Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 10, 2018 11:19 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version > > On Wed, Jan 10, 2018 at 09:06:16PM

Re: [ovs-dev] [PATCH] MSI: Use platform specific netcfg location

Thanks for the review. Applied on master. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 4, 2018 11:36 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] MSI: Use platform specific netcfg

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

Sure. Do you mind if I add your acked-by on each one? Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 4, 2018 11:37 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes

Re: [ovs-dev] [PATCH] windows: Fix x64 build

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 10, 2018 7:30 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] windows: Fix x64 build > > On Wed, Jan 10, 2018 at 07:27:52PM +0200, Alin

Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct state.

-Mesaj original- De la: Anand Kumar [mailto:kumaran...@vmware.com] Trimis: Saturday, February 3, 2018 12:28 AM Către: Alin Serdean ; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct

Re: [ovs-dev] [PATCH v2] datapath-windows: Add trace level logs in conntrack for invalid ct state.

Much better  Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Saturday, February 3, 2018 12:43 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2]

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

It looks a bit complicated. What do you think about the following approach: git diff datapath-windows/automake.mk diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index 3820041f6..164567734 100644 --- a/datapath-windows/automake.mk +++ b/datapath-windows/automake.mk @@

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

Trimming the message a bit. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Shashank Ram Trimis: Thursday, February 8, 2018 7:50 PM Către: aserd...@ovn.org; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows:

Re: [ovs-dev] [PATCH v1 1/2] datapath-windows: Allow compiling all targets using SDK 10.0

I applied the patch set on master. Thanks! -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele aserd...@ovn.org Trimis: Tuesday, February 6, 2018 5:49 PM Către: 'Shashank Ram' ; d...@openvswitch.org Subiect: Re:

Re: [ovs-dev] [PATCH v1 1/2] datapath-windows: Allow compiling all targets using SDK 10.0

Thanks a lot for the series. Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Shashank Ram Trimis: Thursday, February 1, 2018 4:59 AM Către: d...@openvswitch.org Subiect: [ovs-dev]

Re: [ovs-dev] [PATCH v1 2/2] datapath-windows: Specify platform arch during compilation

Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Shashank Ram Trimis: Thursday, February 1, 2018 4:59 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v1 2/2]

Re: [ovs-dev] [PATCH 3/4] unixctl: Make path to unixctl_server socket available to the client.

> Signed-off-by: Ben Pfaff > --- <---B<--> > if (error) { > -ovs_error(error, "could not initialize control socket %s", punix_path); [Alin Serdean] Changing the log message will make the following test fail: 130. daemon.at:148: testing daemon

Re: [ovs-dev] [PATCH] pcap-file: Fix formatting of log message.

> Signed-off-by: Ben Pfaff > --- > lib/pcap-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/pcap-file.c b/lib/pcap-file.c index 981d56d48830..ea5cfa3b274e > 100644 > --- a/lib/pcap-file.c > +++ b/lib/pcap-file.c > @@ -163,7 +163,7 @@ ovs_pcap_read(FILE *file,

Re: [ovs-dev] [PATCH] meta-flow: Make mf_vl_mff_mf_from_nxm_header() require a valid field.

> > All the users of mf_vl_mff_mf_from_nxm_header() expect it to always > obtain a valid field or to report an error. In practice, it did not report an error > in the case where the field was unknown (although it did report an error in > some other cases). This commit fixes the problem. > >

Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Tuesday, July 31, 2018 7:37 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers > > On

Re: [ovs-dev] [PATCH] ofctl: Fixup compare_flows function

Can you also provide a Signed-off-by pls? > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Tuesday, August 7, 2018 12:40 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ofctl:

Re: [ovs-dev] [PATCH 1/2] windows: Add set_deatch function to daemon-windows.c

> On Tue, 21 Aug 2018 at 11:19, Ben Pfaff wrote: > > > On Tue, Aug 21, 2018 at 05:57:47PM +0300, Alin Gabriel Serdean wrote: > > > The daemon-windows file is missing a `set_detach` routine, so add it. > > > > > > This will be useful in the long run. > > > > > > Signed-off-by: Alin Gabriel

Re: [ovs-dev] [PATCH] tunnel, tests: Sort flow output in ERSPAN v1/v2 metadata

> > On Tue, Aug 21, 2018 at 11:01 AM Ben Pfaff wrote: > > > > On Tue, Aug 21, 2018 at 05:18:06PM +0300, Alin Gabriel Serdean wrote: > > > Sort the flows by input port in the test: > > > tunnel.at:512: testing tunnel - ERSPAN v1/v2 metadata ... > > > > > > This tests fails on Windows due to the

Re: [ovs-dev] build: Add gitattribute file to build-aux

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Aaron Conole > Trimis: Wednesday, July 18, 2018 6:02 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] build: Add gitattribute file to build-aux > > Hi Alin,

Re: [ovs-dev] [PATCH] ovn.at: Fix IPv6 periodic RA test on Windows

Thanks for the review! I have a "\n" which isn't OK. Also, even with that changed I get the following: +++ /c/_2018/january/23/ovs/tests/testsuite.dir/at-groups/2378/stdout 2018-01-23 22:58:49 +0200 @@ -1 +1 @@ -ff4001010001050105dc03044080fff

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

(facepalm). Thanks for pointing me to the right direction. I will look into it. Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, January 23, 2018 2:24 AM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH] datapath-windows: Fix static analysis in Stt.c

Thanks. Applied on master. Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Sairam Venugopal Trimis: Tuesday, March 6, 2018 7:56 PM Către: Alin Gabriel Serdean ; d...@openvswitch.org Subiect: Re: [ovs-dev]

Re: [ovs-dev] [PATCH] [RFC] build-windows: Add pthread to windows build

Adding Ben to thread also. The footprint isn't that bad compares to the MSI images: alin@DESKTOP-IUDEFLM /c/_2018/march/temp/ovs/windows $ ls -lh ovs-windows-installer/images/ total 582K -rw-r--r-- 1 alin Administrators 132K Mar 6 20:00 bannrbmp.bmp -rw-r--r-- 1 alin Administrators 450K Mar 6

Re: [ovs-dev] [PATCH 2/2] ovsdb-server: Don't be picky about particular error in test.

Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:19 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 2:11 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging >

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Applied on master! Thanks, Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Thursday, March 8, 2018 2:16 AM > Către: aserd...@ovn.org; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Do

Re: [ovs-dev] [PATCH 1/2] tests: Fix hang when "SSL db: implementation" test failed.

Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:19 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:07 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging >

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

-Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Ben Pfaff Trimis: Wednesday, March 7, 2018 10:53 PM Către: Alin Gabriel Serdean Cc: d...@openvswitch.org Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC]

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:20 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb

Re: [ovs-dev] [PATCH] tests-windows: Make flow extractor work on Windows

Thanks for the quick review. I removed the import and changed a bit the message. Applied on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:07 PM > Către: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix ambiguous variable flake8 warnings

No worries! > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:25 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovs-bugtool: Fix

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 2:12 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add > pthread to

Re: [ovs-dev] [PATCH] tests-windows: Add OpenSSL directory to autotest path

Thanks for the review! Applied on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:09 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re:

Re: [ovs-dev] [PATCH] datapath-windows: fix hash creation on ct mark

Thanks Ben and Anand. I applied from master to branch-2.6. Thanks, Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Ben Pfaff Trimis: Wednesday, February 21, 2018 8:41 PM Către: Alin Gabriel Serdean Cc:

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 8:55 PM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test > on Win >

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 8:45 PM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test > on Win

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

It's been a while . I sent a patch as you suggested: https://patchwork.ozlabs.org/patch/883250/ . Mind taking a look? Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Tuesday, January 23, 2018 11:01 PM >

Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary mode when doing backup/restore

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 14, 2018 8:11 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Acked-by: Alin Gabriel Serdean Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Anand Kumar Trimis: Wednesday, March 7, 2018 1:48 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows: Do

Re: [ovs-dev] [PATCH] tests: Skip tests that need "normal" diff if not available.

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Monday, April 2, 2018 8:15 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Stuart Cardall > Subiect: [ovs-dev] [PATCH] tests:

  1   2   >