Re: [ovs-dev] [PATCH] Makefile.am: Use correct path separator for Windows

2018-02-02 Thread Shashank Ram 


From: Ben Pfaff <b...@ovn.org>
Sent: Friday, February 2, 2018 2:07 PM
To: Shashank Ram
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Makefile.am: Use correct path separator for 
Windows

On Thu, Feb 01, 2018 at 05:03:52PM -0800, Shashank Ram wrote:
> Signed-off-by: Shashank Ram <r...@vmware.com>
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5988c02..1d336b6 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -398,7 +398,7 @@ CLEANFILES += flake8-check
>
>  include $(srcdir)/manpages.mk
>  $(srcdir)/manpages.mk: $(MAN_ROOTS) build-aux/sodepends.py 
> python/build/soutil.py
> - @PYTHONPATH=$$PYTHONPATH:$(srcdir)/python $(PYTHON) 
> $(srcdir)/build-aux/sodepends.py -I. -I$(srcdir) $(MAN_ROOTS) >$(@F).tmp
> + @PYTHONPATH=$$PYTHONPATH$(psep)$(srcdir)/python $(PYTHON) 
> $(srcdir)/build-aux/sodepends.py -I. -I$(srcdir) $(MAN_ROOTS) >$(@F).tmp
>   @if cmp -s $(@F).tmp $@; then \
> touch $@; \
> rm -f $(@F).tmp; \

Thanks for the fix.

There's a very similar instance elsewhere in the same file, doesn't it
need to be corrected also?

Both of these have been there approximately forever.  I don't understand
how they didn't get found before?

diff --git a/Makefile.am b/Makefile.am
index 85a09a5c8fbd..8632d6993cd8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -148,7 +148,7 @@ ro_shell = printf '\043 Generated automatically -- do not 
modify!-*- buffer-

 SUFFIXES += .in
 .in:
-   $(AM_V_GEN)PYTHONPATH=$$PYTHONPATH:$(srcdir)/python $(PYTHON) 
$(srcdir)/build-aux/soexpand.py -I$(srcdir) < $< | \
+   $(AM_V_GEN)PYTHONPATH=$$PYTHONPATH$(psep)$(srcdir)/python $(PYTHON) 
$(srcdir)/build-aux/soexpand.py -I$(srcdir) < $< | \
  $(PYTHON) $(srcdir)/build-aux/dpdkstrip.py $(DPDKSTRIP_FLAGS) | \
  sed \
-e 's,[@]PKIDIR[@],$(PKIDIR),g' \


Looks like this got introduced in 2.9 time frame when the commands looked like 
this:

$(AM_V_GEN)$(PERL) $(srcdir)/build-aux/soexpand.pl -I$(srcdir) < $< | \
  $(PERL) $(srcdir)/build-aux/dpdkstrip.pl $(DPDKSTRIP_FLAGS) | \

$(AM_V_GEN)$(PERL) $(srcdir)/build-aux/soexpand.pl -I$(srcdir) < $< | \
  $(PERL) $(srcdir)/build-aux/dpdkstrip.pl $(DPDKSTRIP_FLAGS) | \

Will send out a v2, thanks!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Makefile.am: Use correct path separator for Windows

2018-02-01 Thread Yi-Hung Wei 
Looks good to me.

Acked-by: Yi-Hung Wei 


On Thu, Feb 1, 2018 at 5:03 PM, Shashank Ram  wrote:
> Signed-off-by: Shashank Ram 
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5988c02..1d336b6 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -398,7 +398,7 @@ CLEANFILES += flake8-check
>
>  include $(srcdir)/manpages.mk
>  $(srcdir)/manpages.mk: $(MAN_ROOTS) build-aux/sodepends.py 
> python/build/soutil.py
> -   @PYTHONPATH=$$PYTHONPATH:$(srcdir)/python $(PYTHON) 
> $(srcdir)/build-aux/sodepends.py -I. -I$(srcdir) $(MAN_ROOTS) >$(@F).tmp
> +   @PYTHONPATH=$$PYTHONPATH$(psep)$(srcdir)/python $(PYTHON) 
> $(srcdir)/build-aux/sodepends.py -I. -I$(srcdir) $(MAN_ROOTS) >$(@F).tmp
> @if cmp -s $(@F).tmp $@; then \
>   touch $@; \
>   rm -f $(@F).tmp; \
> --
> 2.9.3.windows.2
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] Makefile.am: Use correct path separator for Windows

2018-02-01 Thread Shashank Ram 
Signed-off-by: Shashank Ram 
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 5988c02..1d336b6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -398,7 +398,7 @@ CLEANFILES += flake8-check
 
 include $(srcdir)/manpages.mk
 $(srcdir)/manpages.mk: $(MAN_ROOTS) build-aux/sodepends.py 
python/build/soutil.py
-   @PYTHONPATH=$$PYTHONPATH:$(srcdir)/python $(PYTHON) 
$(srcdir)/build-aux/sodepends.py -I. -I$(srcdir) $(MAN_ROOTS) >$(@F).tmp
+   @PYTHONPATH=$$PYTHONPATH$(psep)$(srcdir)/python $(PYTHON) 
$(srcdir)/build-aux/sodepends.py -I. -I$(srcdir) $(MAN_ROOTS) >$(@F).tmp
@if cmp -s $(@F).tmp $@; then \
  touch $@; \
  rm -f $(@F).tmp; \
-- 
2.9.3.windows.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev