Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Sairam Venugopal 
Thanks!

On 11/15/18, 10:45 AM, "Ben Pfaff"  wrote:

Alin already did that.

On Thu, Nov 15, 2018 at 06:40:00PM +, Sairam Venugopal wrote:
> Is it too late to backport this to 2.10?
> 
> On 11/15/18, 7:03 AM, "Alin Serdean"  
wrote:
> 
> I applied the patch on master and as far as it goes without conflicts.
> 
> --
> Alin.
> 
> > -Mesaj original-
> > De la: ovs-dev-boun...@openvswitch.org  > boun...@openvswitch.org> În numele aserd...@ovn.org
> > Trimis: Thursday, November 15, 2018 4:52 PM
> > Către: 'Sairam Venugopal' ; d...@openvswitch.org
> > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid 
reference in
> > Buffermgmt.c
> > 
> > Thanks for the fix!
> > 
> > Acked-by: Alin Gabriel Serdean 
> > 
> > > -Mesaj original-
> > > De la: ovs-dev-boun...@openvswitch.org  > > boun...@openvswitch.org> În numele Sairam Venugopal
> > > Trimis: Wednesday, November 14, 2018 10:07 PM
> > > Către: d...@openvswitch.org
> > > Subiect: [ovs-dev] [PATCH] datapath-windows: Fix invalid 
reference in
> > > Buffermgmt.c
> > >
> > > OVS_BUFFER_CONTEXT gets cleared as part of
> > > NdisFreeNetBufferListContext function call. This causes an invalid
> > reference
> > > error.
> > >
> > > Found while testing with driver verifier enabled.
> > >
> > > Signed-off-by: Sairam Venugopal 
> > > ---
> > >  datapath-windows/ovsext/BufferMgmt.c | 6 --
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-
> > > windows/ovsext/BufferMgmt.c index 448cd76..da5c04a 100644
> > > --- a/datapath-windows/ovsext/BufferMgmt.c
> > > +++ b/datapath-windows/ovsext/BufferMgmt.c
> > 
> > ___
> > dev mailing list
> > d...@openvswitch.org
> > 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-devdata=02%7C01%7Cvsairam%40vmware.com%7C0354cc7dee7d477cb53108d64b2a7f97%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636779043242021462sdata=mvAm5BLoz21%2FNhURhoFdj%2FwZY4VcDHzfQx6UMxOh99c%3Dreserved=0
> 
> 
> ___
> dev mailing list
> d...@openvswitch.org
> 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-devdata=02%7C01%7Cvsairam%40vmware.com%7C0354cc7dee7d477cb53108d64b2a7f97%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636779043242021462sdata=mvAm5BLoz21%2FNhURhoFdj%2FwZY4VcDHzfQx6UMxOh99c%3Dreserved=0


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Sairam Venugopal 
Is it too late to backport this to 2.10?

On 11/15/18, 7:03 AM, "Alin Serdean"  wrote:

I applied the patch on master and as far as it goes without conflicts.

--
Alin.

> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org  boun...@openvswitch.org> În numele aserd...@ovn.org
> Trimis: Thursday, November 15, 2018 4:52 PM
> Către: 'Sairam Venugopal' ; d...@openvswitch.org
    > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in
> Buffermgmt.c
> 
> Thanks for the fix!
> 
> Acked-by: Alin Gabriel Serdean 
> 
> > -Mesaj original-
> > De la: ovs-dev-boun...@openvswitch.org  > boun...@openvswitch.org> În numele Sairam Venugopal
> > Trimis: Wednesday, November 14, 2018 10:07 PM
    > > Către: d...@openvswitch.org
> > Subiect: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in
> > Buffermgmt.c
> >
> > OVS_BUFFER_CONTEXT gets cleared as part of
> > NdisFreeNetBufferListContext function call. This causes an invalid
> reference
> > error.
> >
> > Found while testing with driver verifier enabled.
> >
> > Signed-off-by: Sairam Venugopal 
> > ---
> >  datapath-windows/ovsext/BufferMgmt.c | 6 --
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-
> > windows/ovsext/BufferMgmt.c index 448cd76..da5c04a 100644
> > --- a/datapath-windows/ovsext/BufferMgmt.c
> > +++ b/datapath-windows/ovsext/BufferMgmt.c
> 
> ___
> dev mailing list
> d...@openvswitch.org
> 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-devdata=02%7C01%7Cvsairam%40vmware.com%7Ccb97b47b8b964d81494708d64b0b6ce3%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636778909792412676sdata=DRZ%2FcHxQoIhqwjl2WZbHNOOI89jwASyJat7oY0qwoD8%3Dreserved=0


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Ben Pfaff 
Alin already did that.

On Thu, Nov 15, 2018 at 06:40:00PM +, Sairam Venugopal wrote:
> Is it too late to backport this to 2.10?
> 
> On 11/15/18, 7:03 AM, "Alin Serdean"  wrote:
> 
> I applied the patch on master and as far as it goes without conflicts.
> 
> --
> Alin.
> 
> > -Mesaj original-
> > De la: ovs-dev-boun...@openvswitch.org  > boun...@openvswitch.org> În numele aserd...@ovn.org
> > Trimis: Thursday, November 15, 2018 4:52 PM
> > Către: 'Sairam Venugopal' ; d...@openvswitch.org
> > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference 
> in
> > Buffermgmt.c
> > 
> > Thanks for the fix!
> > 
> > Acked-by: Alin Gabriel Serdean 
> > 
> > > -Mesaj original-
> > > De la: ovs-dev-boun...@openvswitch.org  > > boun...@openvswitch.org> În numele Sairam Venugopal
> > > Trimis: Wednesday, November 14, 2018 10:07 PM
> > > Către: d...@openvswitch.org
> > > Subiect: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in
> > > Buffermgmt.c
> > >
> > > OVS_BUFFER_CONTEXT gets cleared as part of
> > > NdisFreeNetBufferListContext function call. This causes an invalid
> > reference
> > > error.
> > >
> > > Found while testing with driver verifier enabled.
> > >
> > > Signed-off-by: Sairam Venugopal 
> > > ---
> > >  datapath-windows/ovsext/BufferMgmt.c | 6 --
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-
> > > windows/ovsext/BufferMgmt.c index 448cd76..da5c04a 100644
> > > --- a/datapath-windows/ovsext/BufferMgmt.c
> > > +++ b/datapath-windows/ovsext/BufferMgmt.c
> > 
> > ___
> > dev mailing list
> > d...@openvswitch.org
> > 
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-devdata=02%7C01%7Cvsairam%40vmware.com%7Ccb97b47b8b964d81494708d64b0b6ce3%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636778909792412676sdata=DRZ%2FcHxQoIhqwjl2WZbHNOOI89jwASyJat7oY0qwoD8%3Dreserved=0
> 
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread aserdean 
Thanks for the fix!

Acked-by: Alin Gabriel Serdean 

> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org  boun...@openvswitch.org> În numele Sairam Venugopal
> Trimis: Wednesday, November 14, 2018 10:07 PM
> Către: d...@openvswitch.org
> Subiect: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in
> Buffermgmt.c
> 
> OVS_BUFFER_CONTEXT gets cleared as part of
> NdisFreeNetBufferListContext function call. This causes an invalid
reference
> error.
> 
> Found while testing with driver verifier enabled.
> 
> Signed-off-by: Sairam Venugopal 
> ---
>  datapath-windows/ovsext/BufferMgmt.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-
> windows/ovsext/BufferMgmt.c
> index 448cd76..da5c04a 100644
> --- a/datapath-windows/ovsext/BufferMgmt.c
> +++ b/datapath-windows/ovsext/BufferMgmt.c

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Alin Serdean 
I applied the patch on master and as far as it goes without conflicts.

--
Alin.

> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org  boun...@openvswitch.org> În numele aserd...@ovn.org
> Trimis: Thursday, November 15, 2018 4:52 PM
> Către: 'Sairam Venugopal' ; d...@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in
> Buffermgmt.c
> 
> Thanks for the fix!
> 
> Acked-by: Alin Gabriel Serdean 
> 
> > -Mesaj original-
> > De la: ovs-dev-boun...@openvswitch.org  > boun...@openvswitch.org> În numele Sairam Venugopal
> > Trimis: Wednesday, November 14, 2018 10:07 PM
> > Către: d...@openvswitch.org
> > Subiect: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in
> > Buffermgmt.c
> >
> > OVS_BUFFER_CONTEXT gets cleared as part of
> > NdisFreeNetBufferListContext function call. This causes an invalid
> reference
> > error.
> >
> > Found while testing with driver verifier enabled.
> >
> > Signed-off-by: Sairam Venugopal 
> > ---
> >  datapath-windows/ovsext/BufferMgmt.c | 6 --
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-
> > windows/ovsext/BufferMgmt.c index 448cd76..da5c04a 100644
> > --- a/datapath-windows/ovsext/BufferMgmt.c
> > +++ b/datapath-windows/ovsext/BufferMgmt.c
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-14 Thread Sairam Venugopal 
OVS_BUFFER_CONTEXT gets cleared as part of NdisFreeNetBufferListContext
function call. This causes an invalid reference error.

Found while testing with driver verifier enabled.

Signed-off-by: Sairam Venugopal 
---
 datapath-windows/ovsext/BufferMgmt.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/datapath-windows/ovsext/BufferMgmt.c 
b/datapath-windows/ovsext/BufferMgmt.c
index 448cd76..da5c04a 100644
--- a/datapath-windows/ovsext/BufferMgmt.c
+++ b/datapath-windows/ovsext/BufferMgmt.c
@@ -1622,6 +1622,7 @@ OvsCompleteNBL(PVOID switch_ctx,
 {
 POVS_BUFFER_CONTEXT ctx;
 UINT16 flags;
+UINT32 dataOffsetDelta;
 PNET_BUFFER_LIST parent;
 NDIS_STATUS status;
 NDIS_HANDLE poolHandle;
@@ -1653,6 +1654,7 @@ OvsCompleteNBL(PVOID switch_ctx,
 nb = NET_BUFFER_LIST_FIRST_NB(nbl);
 
 flags = ctx->flags;
+dataOffsetDelta = ctx->dataOffsetDelta;
 if (!(flags & OVS_BUFFER_FRAGMENT) &&
 NET_BUFFER_DATA_LENGTH(nb) != ctx->origDataLength) {
 UINT32 diff;
@@ -1667,7 +1669,7 @@ OvsCompleteNBL(PVOID switch_ctx,
 }
 }
 
-if (ctx->flags & OVS_BUFFER_PRIVATE_CONTEXT) {
+if (flags & OVS_BUFFER_PRIVATE_CONTEXT) {
 NdisFreeNetBufferListContext(nbl, sizeof (OVS_BUFFER_CONTEXT));
 }
 
@@ -1740,7 +1742,7 @@ OvsCompleteNBL(PVOID switch_ctx,
 #ifdef DBG
 InterlockedDecrement((LONG volatile *)>fragNBLCount);
 #endif
-NdisFreeFragmentNetBufferList(nbl, ctx->dataOffsetDelta, 0);
+NdisFreeFragmentNetBufferList(nbl, dataOffsetDelta, 0);
 }
 
 if (parent != NULL) {
-- 
2.9.0.windows.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev