Re: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code comparison in CT lookup

2017-08-15 Thread Anand Kumar
t; Subject: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code > comparison in CT lookup > > - Update the CT comparison function to compare individual fields instead of > NdisEqualMemory. [Alin Serdean] I don't like this change,

Re: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code comparison in CT lookup

2017-08-14 Thread Alin Serdean
1:42 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code > comparison in CT lookup > > - Update the CT comparison function to compare individual fields instead of > NdisEqualMemory. [Alin Serdean] I don't like this change

Re: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code comparison in CT lookup

2017-08-11 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 8/11/17, 1:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: > - Update the CT comparison function to compare individual fields instead of >NdisEqualMemory. >- Add in some padding for the ct_endpoint's union. >- Update the Orig Tuple to

[ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code comparison in CT lookup

2017-08-11 Thread Anand Kumar
- Update the CT comparison function to compare individual fields instead of NdisEqualMemory. - Add in some padding for the ct_endpoint's union. - Update the Orig Tuple to use ICMP Type and Code instead of Port for ICMP Co-authored-by: Sairam Venugopal Signed-off-by: Anand Kumar --- datapath-wi