Re: [ovs-dev] [PATCH] ofp-print: #include its own header first.
On Tue, Aug 08, 2017 at 04:23:10PM -0700, Joe Stringer wrote: > On 8 August 2017 at 16:11, Ben Pfaff wrote: > > The OVS coding style document says that a .c file should include the > > corresponding .h file first, to ensure that the .h file includes all of > > its dependencies, but this file didn't do that. > > > > Signed-off-by: Ben Pfaff > > --- > > Acked-by: Joe Stringer Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] ofp-print: #include its own header first.
On 8 August 2017 at 16:11, Ben Pfaff wrote: > The OVS coding style document says that a .c file should include the > corresponding .h file first, to ensure that the .h file includes all of > its dependencies, but this file didn't do that. > > Signed-off-by: Ben Pfaff > --- Acked-by: Joe Stringer ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] ofp-print: #include its own header first.
The OVS coding style document says that a .c file should include the corresponding .h file first, to ensure that the .h file includes all of its dependencies, but this file didn't do that. Signed-off-by: Ben Pfaff --- Depends on https://patchwork.ozlabs.org/patch/799445/. lib/ofp-print.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 16d617ab5008..f77b31baf0b4 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -16,6 +16,8 @@ #include +#include "openvswitch/ofp-print.h" + #include #include #include @@ -43,7 +45,6 @@ #include "openvswitch/ofp-actions.h" #include "openvswitch/ofp-errors.h" #include "openvswitch/ofp-msgs.h" -#include "openvswitch/ofp-print.h" #include "openvswitch/ofp-util.h" #include "openvswitch/ofpbuf.h" #include "openvswitch/type-props.h" -- 2.10.2 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
