Re: [ovs-dev] [PATCH 00/20] Update and backport of upstream Linux

2018-06-09 Thread wenxu 
Hi Greg,


I have one question about the patches.


why the patch "openvswitch: Add meter action support" in the series of  
"Openvswitch meter action" is not add in openvswitch ?
https://patchwork.ozlabs.org/cover/836867/

BR
wenxu


At 2018-01-31 07:40:02, "Greg Rose"  wrote:
>Allow OVS to compile and build on Linux 4.14.x kernels.  Added
>necessary compatability layer changes to the respective patches
>as required for our OOT build environment.
>
>Note that NSH and ERSPAN patches are not in this series.  We
>are working with the authors of those patches to get them
>backported.
>
>This series of patches was originally sent as two separate sets
>however the dependencies and compatability layer requirements
>made it more convenient to combine the two sets.
>
>Andy Zhou (3):
>  datapath: export get_dp() API
>  datapath: Add meter netlink definitions
>  datapath: Add meter infrastructure
>
>Arnd Bergmann (1):
>  datapath: use ktime_get_ts64() instead of ktime_get_ts()
>
>Christophe JAILLET (1):
>  datapath:  Fix an error handling path in
>'ovs_nla_init_match_and_action()
>
>Florian Westphal (1):
>  datapath: conntrack: make protocol tracker pointers const
>
>Greg Rose (8):
>  datapath: Fix netdev_master_upper_dev_link for 4.14
>  compat: Do not include headers when not compiling
>  datapath: Fix SKB_GSO_UDP usage
>  acinclude.m4: Enable Linux 4.14
>  travis: Update kernel test list from kernel.org
>  compat: Fix compiler headers
>  compat:inet_frag.h: Check for frag_percpu_counter_batch
>  Documentation: Update NEWS and faq
>
>Gustavo A. R. Silva (2):
>  datapath: meter: fix NULL pointer dereference in
>ovs_meter_cmd_reply_start
>  datapath: fix data type in queue_gso_packets
>
>Jiri Benc (1):
>  datapath: reliable interface indentification in port dumps
>
>Wei Yongjun (2):
>  datapath: Fix return value check in ovs_meter_cmd_features()
>  datapath: Using kfree_rcu() to simplify the code
>
>zhangliping (1):
>  datapath: fix the incorrect flow action alloc size
>
> .travis.yml|  17 +-
> Documentation/faq/releases.rst |   1 +
> NEWS   |   2 +
> acinclude.m4   |  16 +-
> datapath/Modules.mk|   6 +-
> datapath/conntrack.c   |   4 +-
> datapath/datapath.c| 106 ++--
> datapath/datapath.h|  38 +-
> datapath/dp_notify.c   |   3 +-
> datapath/flow.c|  11 +-
> datapath/flow_netlink.c|  16 +-
> datapath/linux/compat/include/linux/compiler-gcc.h |   2 +
> datapath/linux/compat/include/linux/netdevice.h|  15 +-
> datapath/linux/compat/include/linux/openvswitch.h  |  53 ++
> datapath/linux/compat/include/net/inet_frag.h  |  14 +
> datapath/linux/compat/include/net/netlink.h|   9 +
> datapath/linux/compat/ip_gre.c |   2 +-
> datapath/linux/compat/ip_output.c  |   2 +-
> datapath/linux/compat/stt.c|  11 +-
> datapath/meter.c   | 607 +
> datapath/meter.h   |  54 ++
> datapath/vport-netdev.c|   9 +-
> 22 files changed, 915 insertions(+), 83 deletions(-)
> create mode 100644 datapath/meter.c
> create mode 100644 datapath/meter.h
>
>-- 
>1.8.3.1
>
>___
>dev mailing list
>d...@openvswitch.org
>https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/20] Update and backport of upstream Linux

2018-02-02 Thread Gregory Rose 

On 2/2/2018 10:20 AM, Pravin Shelar wrote:

On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose  wrote:

Allow OVS to compile and build on Linux 4.14.x kernels.  Added
necessary compatability layer changes to the respective patches
as required for our OOT build environment.

Note that NSH and ERSPAN patches are not in this series.  We
are working with the authors of those patches to get them
backported.

This series of patches was originally sent as two separate sets
however the dependencies and compatability layer requirements
made it more convenient to combine the two sets.

Andy Zhou (3):
   datapath: export get_dp() API
   datapath: Add meter netlink definitions
   datapath: Add meter infrastructure

Arnd Bergmann (1):
   datapath: use ktime_get_ts64() instead of ktime_get_ts()

Christophe JAILLET (1):
   datapath:  Fix an error handling path in
 'ovs_nla_init_match_and_action()

Florian Westphal (1):
   datapath: conntrack: make protocol tracker pointers const

Greg Rose (8):
   datapath: Fix netdev_master_upper_dev_link for 4.14
   compat: Do not include headers when not compiling
   datapath: Fix SKB_GSO_UDP usage
   acinclude.m4: Enable Linux 4.14
   travis: Update kernel test list from kernel.org
   compat: Fix compiler headers
   compat:inet_frag.h: Check for frag_percpu_counter_batch
   Documentation: Update NEWS and faq

Gustavo A. R. Silva (2):
   datapath: meter: fix NULL pointer dereference in
 ovs_meter_cmd_reply_start
   datapath: fix data type in queue_gso_packets

Jiri Benc (1):
   datapath: reliable interface indentification in port dumps

Wei Yongjun (2):
   datapath: Fix return value check in ovs_meter_cmd_features()
   datapath: Using kfree_rcu() to simplify the code

zhangliping (1):
   datapath: fix the incorrect flow action alloc size


The patch series looks good. I have few comment on couple of patches.
About metering and namespace related userspace patches are not in 2.9,
so can you create two separate series. one with fixes for master ( and
can be backported  2.9) and second with the features which can be
targeted for master branch only.

Thanks.


I will do that.  Thanks for the reviews Pravin!!

- Greg
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/20] Update and backport of upstream Linux

2018-02-02 Thread Pravin Shelar 
On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose  wrote:
> Allow OVS to compile and build on Linux 4.14.x kernels.  Added
> necessary compatability layer changes to the respective patches
> as required for our OOT build environment.
>
> Note that NSH and ERSPAN patches are not in this series.  We
> are working with the authors of those patches to get them
> backported.
>
> This series of patches was originally sent as two separate sets
> however the dependencies and compatability layer requirements
> made it more convenient to combine the two sets.
>
> Andy Zhou (3):
>   datapath: export get_dp() API
>   datapath: Add meter netlink definitions
>   datapath: Add meter infrastructure
>
> Arnd Bergmann (1):
>   datapath: use ktime_get_ts64() instead of ktime_get_ts()
>
> Christophe JAILLET (1):
>   datapath:  Fix an error handling path in
> 'ovs_nla_init_match_and_action()
>
> Florian Westphal (1):
>   datapath: conntrack: make protocol tracker pointers const
>
> Greg Rose (8):
>   datapath: Fix netdev_master_upper_dev_link for 4.14
>   compat: Do not include headers when not compiling
>   datapath: Fix SKB_GSO_UDP usage
>   acinclude.m4: Enable Linux 4.14
>   travis: Update kernel test list from kernel.org
>   compat: Fix compiler headers
>   compat:inet_frag.h: Check for frag_percpu_counter_batch
>   Documentation: Update NEWS and faq
>
> Gustavo A. R. Silva (2):
>   datapath: meter: fix NULL pointer dereference in
> ovs_meter_cmd_reply_start
>   datapath: fix data type in queue_gso_packets
>
> Jiri Benc (1):
>   datapath: reliable interface indentification in port dumps
>
> Wei Yongjun (2):
>   datapath: Fix return value check in ovs_meter_cmd_features()
>   datapath: Using kfree_rcu() to simplify the code
>
> zhangliping (1):
>   datapath: fix the incorrect flow action alloc size
>
The patch series looks good. I have few comment on couple of patches.
About metering and namespace related userspace patches are not in 2.9,
so can you create two separate series. one with fixes for master ( and
can be backported  2.9) and second with the features which can be
targeted for master branch only.

Thanks.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 00/20] Update and backport of upstream Linux

2018-01-30 Thread Greg Rose 
Allow OVS to compile and build on Linux 4.14.x kernels.  Added
necessary compatability layer changes to the respective patches
as required for our OOT build environment.

Note that NSH and ERSPAN patches are not in this series.  We
are working with the authors of those patches to get them
backported.

This series of patches was originally sent as two separate sets
however the dependencies and compatability layer requirements
made it more convenient to combine the two sets.

Andy Zhou (3):
  datapath: export get_dp() API
  datapath: Add meter netlink definitions
  datapath: Add meter infrastructure

Arnd Bergmann (1):
  datapath: use ktime_get_ts64() instead of ktime_get_ts()

Christophe JAILLET (1):
  datapath:  Fix an error handling path in
'ovs_nla_init_match_and_action()

Florian Westphal (1):
  datapath: conntrack: make protocol tracker pointers const

Greg Rose (8):
  datapath: Fix netdev_master_upper_dev_link for 4.14
  compat: Do not include headers when not compiling
  datapath: Fix SKB_GSO_UDP usage
  acinclude.m4: Enable Linux 4.14
  travis: Update kernel test list from kernel.org
  compat: Fix compiler headers
  compat:inet_frag.h: Check for frag_percpu_counter_batch
  Documentation: Update NEWS and faq

Gustavo A. R. Silva (2):
  datapath: meter: fix NULL pointer dereference in
ovs_meter_cmd_reply_start
  datapath: fix data type in queue_gso_packets

Jiri Benc (1):
  datapath: reliable interface indentification in port dumps

Wei Yongjun (2):
  datapath: Fix return value check in ovs_meter_cmd_features()
  datapath: Using kfree_rcu() to simplify the code

zhangliping (1):
  datapath: fix the incorrect flow action alloc size

 .travis.yml|  17 +-
 Documentation/faq/releases.rst |   1 +
 NEWS   |   2 +
 acinclude.m4   |  16 +-
 datapath/Modules.mk|   6 +-
 datapath/conntrack.c   |   4 +-
 datapath/datapath.c| 106 ++--
 datapath/datapath.h|  38 +-
 datapath/dp_notify.c   |   3 +-
 datapath/flow.c|  11 +-
 datapath/flow_netlink.c|  16 +-
 datapath/linux/compat/include/linux/compiler-gcc.h |   2 +
 datapath/linux/compat/include/linux/netdevice.h|  15 +-
 datapath/linux/compat/include/linux/openvswitch.h  |  53 ++
 datapath/linux/compat/include/net/inet_frag.h  |  14 +
 datapath/linux/compat/include/net/netlink.h|   9 +
 datapath/linux/compat/ip_gre.c |   2 +-
 datapath/linux/compat/ip_output.c  |   2 +-
 datapath/linux/compat/stt.c|  11 +-
 datapath/meter.c   | 607 +
 datapath/meter.h   |  54 ++
 datapath/vport-netdev.c|   9 +-
 22 files changed, 915 insertions(+), 83 deletions(-)
 create mode 100644 datapath/meter.c
 create mode 100644 datapath/meter.h

-- 
1.8.3.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev