Re: [ovs-dev] [PATCH 1/2] datapath-windows: Add Win10Analyze target

2018-05-08 Thread Alin Balutoiu 
Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com>

> -Original Message-
> From: ovs-dev-boun...@openvswitch.org  boun...@openvswitch.org> On Behalf Of Alin Gabriel Serdean
> Sent: Saturday, March 3, 2018 1:42 AM
> To: d...@openvswitch.org
> Cc: Alin Gabriel Serdean <aserd...@ovn.org>
> Subject: [ovs-dev] [PATCH 1/2] datapath-windows: Add Win10Analyze target
> 
> This patch adds a new target called `Win10Analyze` to the driver solution.
> 
> It enables us to trigger static analysis over the Win10 target.
> 
> Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org>
> ---
>  datapath-windows/Package/package.VcxProj  | 21 ++-
>  datapath-windows/Package/package.VcxProj.user |  5 +++-
>  datapath-windows/ovsext.sln   |  5 
>  datapath-windows/ovsext/ovsext.vcxproj| 37
> ++-
>  datapath-windows/ovsext/ovsext.vcxproj.user   |  5 +++-
>  5 files changed, 69 insertions(+), 4 deletions(-)
> 
> diff --git a/datapath-windows/Package/package.VcxProj b/datapath-
> windows/Package/package.VcxProj
> index de747eed2..5939a8816 100644
> --- a/datapath-windows/Package/package.VcxProj
> +++ b/datapath-windows/Package/package.VcxProj
> @@ -9,6 +9,10 @@
>Win10 Release
>x64
>  
> +
> +  Win10Analyze
> +  x64
> +
>  
>Win8.1 Debug
>x64
> @@ -71,6 +75,13 @@
> 
> WindowsKernelModeDriver$(PlatformToolsetVer) Toolset>
>  Desktop
>
> +   Condition="'$(Configuration)|$(Platform)'=='Win10Analyze|x64'"
> Label="Configuration">
> +
> +true
> +10.0
> +
> WindowsKernelModeDriver$(PlatformToolsetVer) Toolset>
> +Desktop
> +  
>
>  Windows8
>  true
> @@ -113,6 +124,9 @@
>
>  true
>
> +   Condition="'$(Configuration)|$(Platform)'=='Win10Analyze|x64'">
> +true
> +  
>
>  DbgengKernelDebugger
>  False
> @@ -148,6 +162,11 @@
>true
>  
>
> +   Condition="'$(Configuration)|$(Platform)'=='Win10Analyze|x64'">
> +
> +  true
> +
> +  
>
>  
>true @@ -185,4 +204,4 @@
>
>
>
> -
> +
> \ No newline at end of file
> diff --git a/datapath-windows/Package/package.VcxProj.user b/datapath-
> windows/Package/package.VcxProj.user
> index 6231d93f7..5b0c53539 100644
> --- a/datapath-windows/Package/package.VcxProj.user
> +++ b/datapath-windows/Package/package.VcxProj.user
> @@ -15,6 +15,9 @@
>
>  TestSign
>
> +   Condition="'$(Configuration)|$(Platform)'=='Win10Analyze|x64'">
> +TestSign
> +  
>
>  TestSign
>
> @@ -24,4 +27,4 @@
>
>  TestSign
>
> -
> +
> \ No newline at end of file
> diff --git a/datapath-windows/ovsext.sln b/datapath-windows/ovsext.sln index
> 1000104f1..ab006e84f 100644
> --- a/datapath-windows/ovsext.sln
> +++ b/datapath-windows/ovsext.sln
> @@ -12,6 +12,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") =
> "ovsext", "ovsext\ovsext.vcx  EndProject  Global
>   GlobalSection(SolutionConfigurationPlatforms) = preSolution
> + Win10Analyze|x64 = Win10Analyze|x64
>   Win10Debug|x64 = Win10Debug|x64
>   Win10Release|x64 = Win10Release|x64
>   Win8.1Analyze|x64 = Win8.1Analyze|x64 @@ -22,6 +23,8 @@
> Global
>   Win8Release|x64 = Win8Release|x64
>   EndGlobalSection
>   GlobalSection(ProjectConfigurationPlatforms) = postSolution
> + {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win10Analyze|x64.ActiveCfg = Win10Analyze|x64
> + {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win10Analyze|x64.Build.0 =
> +Win10Analyze|x64
>   {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win10Debug|x64.ActiveCfg = Win10 Debug|x64
>   {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win10Debug|x64.Build.0 = Win10 Debug|x64
>   {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win10Debug|x64.Deploy.0 = Win10 Debug|x64 @@ -42,6
> +45,8 @@ Global
>   {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win8Debug|x64.Build.0 = Win8 Debug|x64
>   {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win8Release|x64.ActiveCfg = Win8 Release|x64
>   {911D7389-3E61-449F-B8F3-
> 14AD7EE9A0F2}.Win8Release|x64.Build.0 = Win8 Release|x64
> + {63FE215D-98BE-4440-8081-
> C6160EFB80FA}.Win10Analyze|x64.ActiveCfg = Win10Analyze|x64
> + {63FE215D-98BE-4440-8081-
> C6160EFB80FA}.Win10Analyze|x64.Build.0 =
> +Win10Analyze|x

[ovs-dev] [PATCH 1/2] datapath-windows: Add Win10Analyze target

2018-03-02 Thread Alin Gabriel Serdean 
This patch adds a new target called `Win10Analyze` to the driver solution.

It enables us to trigger static analysis over the Win10 target.

Signed-off-by: Alin Gabriel Serdean 
---
 datapath-windows/Package/package.VcxProj  | 21 ++-
 datapath-windows/Package/package.VcxProj.user |  5 +++-
 datapath-windows/ovsext.sln   |  5 
 datapath-windows/ovsext/ovsext.vcxproj| 37 ++-
 datapath-windows/ovsext/ovsext.vcxproj.user   |  5 +++-
 5 files changed, 69 insertions(+), 4 deletions(-)

diff --git a/datapath-windows/Package/package.VcxProj 
b/datapath-windows/Package/package.VcxProj
index de747eed2..5939a8816 100644
--- a/datapath-windows/Package/package.VcxProj
+++ b/datapath-windows/Package/package.VcxProj
@@ -9,6 +9,10 @@
   Win10 Release
   x64
 
+
+  Win10Analyze
+  x64
+
 
   Win8.1 Debug
   x64
@@ -71,6 +75,13 @@
 
WindowsKernelModeDriver$(PlatformToolsetVer)
 Desktop
   
+  
+
+true
+10.0
+
WindowsKernelModeDriver$(PlatformToolsetVer)
+Desktop
+  
   
 Windows8
 true
@@ -113,6 +124,9 @@
   
 true
   
+  
+true
+  
   
 DbgengKernelDebugger
 False
@@ -148,6 +162,11 @@
   true
 
   
+  
+
+  true
+
+  
   
 
   true
@@ -185,4 +204,4 @@
   
   
   
-
+
\ No newline at end of file
diff --git a/datapath-windows/Package/package.VcxProj.user 
b/datapath-windows/Package/package.VcxProj.user
index 6231d93f7..5b0c53539 100644
--- a/datapath-windows/Package/package.VcxProj.user
+++ b/datapath-windows/Package/package.VcxProj.user
@@ -15,6 +15,9 @@
   
 TestSign
   
+  
+TestSign
+  
   
 TestSign
   
@@ -24,4 +27,4 @@
   
 TestSign
   
-
+
\ No newline at end of file
diff --git a/datapath-windows/ovsext.sln b/datapath-windows/ovsext.sln
index 1000104f1..ab006e84f 100644
--- a/datapath-windows/ovsext.sln
+++ b/datapath-windows/ovsext.sln
@@ -12,6 +12,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ovsext", 
"ovsext\ovsext.vcx
 EndProject
 Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
+   Win10Analyze|x64 = Win10Analyze|x64
Win10Debug|x64 = Win10Debug|x64
Win10Release|x64 = Win10Release|x64
Win8.1Analyze|x64 = Win8.1Analyze|x64
@@ -22,6 +23,8 @@ Global
Win8Release|x64 = Win8Release|x64
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
+   
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Analyze|x64.ActiveCfg = 
Win10Analyze|x64
+   {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Analyze|x64.Build.0 
= Win10Analyze|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Debug|x64.ActiveCfg 
= Win10 Debug|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Debug|x64.Build.0 = 
Win10 Debug|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Debug|x64.Deploy.0 
= Win10 Debug|x64
@@ -42,6 +45,8 @@ Global
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Debug|x64.Build.0 = 
Win8 Debug|x64

{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Release|x64.ActiveCfg = Win8 
Release|x64
{911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Release|x64.Build.0 
= Win8 Release|x64
+   
{63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Analyze|x64.ActiveCfg = 
Win10Analyze|x64
+   {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Analyze|x64.Build.0 
= Win10Analyze|x64
{63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Debug|x64.ActiveCfg 
= Win10 Debug|x64
{63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Debug|x64.Build.0 = 
Win10 Debug|x64
{63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Debug|x64.Deploy.0 
= Win10 Debug|x64
diff --git a/datapath-windows/ovsext/ovsext.vcxproj 
b/datapath-windows/ovsext/ovsext.vcxproj
index 0509b765b..faec342dd 100644
--- a/datapath-windows/ovsext/ovsext.vcxproj
+++ b/datapath-windows/ovsext/ovsext.vcxproj
@@ -9,6 +9,10 @@
   Win10 Release
   x64
 
+
+  Win10Analyze
+  x64
+
 
   Win8.1 Debug
   x64
@@ -71,6 +75,13 @@
 
WindowsKernelModeDriver$(PlatformToolsetVer)
 Desktop
   
+  
+
+True
+10.0
+
WindowsKernelModeDriver$(PlatformToolsetVer)
+Desktop
+  
   
 Windows8
 True
@@ -131,6 +142,9 @@
   
 
   
+  
+
+  
   
 
 
@@ -182,6 +196,11 @@
   
 true
   
+  
+true
+..\..\..\..\..\Program Files (x86)\Windows 
Kits\10\CodeAnalysis\DriverMinimumRules.ruleset
+true
+  
   
 true
   
@@ -276,6 +295,17 @@
   
%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1
 
   
+  
+
+  
%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1
+
+
+  
%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1
+
+
+  
%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1
+
+