Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

> -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent: Tuesday, 27 March, 2018 16:21 > To: Ilya Maximets ; Jan Scheurich > ; d...@openvswitch.org > Cc: ktray...@redhat.com; O Mahony, Billy

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

> Comments inline. > > Best regards, Ilya Maximets. > > On 18.03.2018 20:55, Jan Scheurich wrote: > > This patch instruments the dpif-netdev datapath to record detailed > > statistics of what is happening in every iteration of a PMD thread. > > > > The collection of detailed statistics can be

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

Comments inline. Best regards, Ilya Maximets. On 18.03.2018 20:55, Jan Scheurich wrote: > This patch instruments the dpif-netdev datapath to record detailed > statistics of what is happening in every iteration of a PMD thread. > > The collection of detailed statistics can be controlled by a new

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

> To: Jan Scheurich <jan.scheur...@ericsson.com> > Cc: d...@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance > stats for PMDs > > Hi Jan, > > Some stylistic type comments follow. Sorry to jump in at t

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

Hi Jan, Some stylistic type comments follow. Sorry to jump in at the end - but you asked for checkpatch changes, so I improved and ran it against your patch and found some stuff for which I have an opinion. :) Maybe nothing to hold up merging but cleanup stuff. Jan Scheurich

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Sunday, March 18, 2018 5:55 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O

[ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

This patch instruments the dpif-netdev datapath to record detailed statistics of what is happening in every iteration of a PMD thread. The collection of detailed statistics can be controlled by a new Open_vSwitch configuration parameter "other_config:pmd-perf-metrics". By default it is disabled.