Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-09 Thread Wang, Yipeng1
Thanks for the comments, please see my reply inlined. I made all the changes you suggested and included in v5 which I will send out soon. >> diff --git a/lib/cmap.c b/lib/cmap.c >> index 07719a8..db1c806 100644 >> --- a/lib/cmap.c >> +++ b/lib/cmap.c >> @@ -373,6 +373,79 @@ cmap_find(const

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-05 Thread Wang, Yipeng1
Thanks for the comments, please see my reply inlined. >I've checked the latest patch and the performance results I get are similar to >the ones give in the previous patches. Also >enabling/disabling the DFC on the fly works as expected. > >The main query I have regards the slow sweep for SMC >

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-05 Thread O Mahony, Billy
Hi Yipeng, Some further comments below. Mainly to do with readability and understanding of the changes. Regards, Billy. > -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 6:53 PM > To: d...@openvswitch.org > Cc: Wang, Yipeng1 ; jan.scheur...@ericsson.com; >

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-04 Thread O Mahony, Billy
Hi, I've checked the latest patch and the performance results I get are similar to the ones give in the previous patches. Also enabling/disabling the DFC on the fly works as expected. The main query I have regards the slow sweep for SMC [[BO'M]] The slow sweep removes EMC entries that are no

[ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-06-29 Thread Yipeng Wang
This patch adds a signature match cache (SMC) after exact match cache (EMC). The difference between SMC and EMC is SMC only stores a signature of a flow thus it is much more memory efficient. With same memory space, EMC can store 8k flows while SMC can store 1M flows. It is generally beneficial to