Re: [ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-09 Thread Ilya Maximets
On 09.08.2017 15:29, Bodireddy, Bhanuprakash wrote: > Hi Ilya, >>> >>> +/* Flush tx queues. >>> + * This is done periodically to empty the intermediate queue in case >>> +of >>> + * fewer packets (< INTERIM_QUEUE_BURST_THRESHOLD) buffered in the >> queue. >>> + */ >>> +static int >>> +netdev_dpdk_t

Re: [ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-09 Thread Bodireddy, Bhanuprakash
Hi Ilya, >> >> +/* Flush tx queues. >> + * This is done periodically to empty the intermediate queue in case >> +of >> + * fewer packets (< INTERIM_QUEUE_BURST_THRESHOLD) buffered in the >queue. >> + */ >> +static int >> +netdev_dpdk_txq_flush(struct netdev *netdev, int qid , bool >> +concurrent_tx

Re: [ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-09 Thread Ilya Maximets
Not a full review. Comments inline. > Add netdev_txq_flush(), that flush packets on a queue. This is needed > to transmit packets on the intermediate queue. > > This commit also implements netdev_dpdk_txq_flush() function. If there > are any packets waiting in the queue, they are transmitted inst

[ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-08 Thread Bhanuprakash Bodireddy
Add netdev_txq_flush(), that flush packets on a queue. This is needed to transmit packets on the intermediate queue. This commit also implements netdev_dpdk_txq_flush() function. If there are any packets waiting in the queue, they are transmitted instantly using the rte_eth_tx_burst function. In X