Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-02 Thread Ilya Maximets
On 28.06.2019 19:37, William Tu wrote: >> >> >> One more thing I noticed is the same issue as you had with completion queue, >> but >> with rx queue. When I'm trying to send traffic from 2 threads to the same >> port, > > Is the 2 threads send traffic using afxdp tx? Yes. > >> I'm starting

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-28 Thread William Tu
> > > +int > > +netdev_afxdp_batch_send(struct netdev *netdev, int qid, > > +struct dp_packet_batch *batch, > > +bool concurrent_txq) > > +{ > > +struct netdev_linux *dev = netdev_linux_cast(netdev); > > +struct xsk_socket_info *xsk_info =

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-28 Thread Ilya Maximets
Few more bits. On 19.06.2019 22:51, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-27 Thread William Tu
Hi Ilya, Thanks for the feedback. > > +static struct dp_packet_afxdp * > > +dp_packet_cast_afxdp(const struct dp_packet *d) > > +{ > > +ovs_assert(d->source == DPBUF_AFXDP); > > +return CONTAINER_OF(d, struct dp_packet_afxdp, packet); > > +} > > + > > +static inline void > >

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-27 Thread Ilya Maximets
Just a few comments inline. Best regards, Ilya Maximets. On 19.06.2019 22:51, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-26 Thread William Tu
On Fri, Jun 21, 2019 at 7:56 AM Ilya Maximets wrote: > > On 19.06.2019 22:51, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the eBPF and XDP technology. It

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-25 Thread William Tu
> 7. It's a known issue that tunneling is not working right now in > system-traffic > userspace tests. Could be workarounded by removing '--disable-system' from > OVS_TRAFFIC_VSWITCHD_START in tests/system-userspace-macros.at. I'm going to > prepare a patch for this issue in a near future. > I

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-24 Thread Ilya Maximets
On 24.06.2019 20:23, Ilya Maximets wrote: > On 22.06.2019 9:18, William Tu wrote: >> Hi Ilya, >> >> Thanks for such a detailed review! >> >> I wasn't thinking about making all "make check-afxdp" test cases >> passed because there are some errors not related to XDP. >> But since you've done lots of

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-24 Thread Ilya Maximets
On 22.06.2019 9:18, William Tu wrote: > Hi Ilya, > > Thanks for such a detailed review! > > I wasn't thinking about making all "make check-afxdp" test cases > passed because there are some errors not related to XDP. > But since you've done lots of investigation, let's fix all and make it passed.

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-22 Thread William Tu
Hi Ilya, Thanks for such a detailed review! I wasn't thinking about making all "make check-afxdp" test cases passed because there are some errors not related to XDP. But since you've done lots of investigation, let's fix all and make it passed. > Hi! > I finally managed to successfully run

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-21 Thread Ilya Maximets
On 19.06.2019 22:51, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK but cooperate

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-21 Thread Ilya Maximets
On 19.06.2019 22:51, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK but cooperate

[ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-19 Thread William Tu
The patch introduces experimental AF_XDP support for OVS netdev. AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket type built upon the eBPF and XDP technology. It is aims to have comparable performance to DPDK but cooperate better with existing kernel's networking stack.