Re: [ovs-dev] [PATCH] Adding cli for displaying LACP counters

2018-04-18 Thread Ben Pfaff 
On Wed, Apr 18, 2018 at 11:57:43PM +0530, Nitin Katiyar wrote:
> Currently OVS does not provide any command to display stats for LACP
> without which it is difficult to debug LACP issues. Here we propose
> to display various statistics about LACP PDUs and slave state change.
> 
> Sample output:
> 
> ovs_lacp # ovs-appctl lacp/stats-show
>  bond-prv statistics 
> 
> slave: dpdk0:
> RX PDUs: 128
> RX Bad PDUs: 0
> TX PDUs: 5
> Link Expired: 2
> Link Defaulted: 1
> Carrier Status Changed: 0
> 
> Signed-off-by: Nitin Katiyar 

Thanks!  I applied this to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Adding cli for displaying LACP counters

2018-04-12 Thread Nitin Katiyar 

Hi Ben,
Thanks for reviewing it.
Will update the documentation and NEWS item soon.

Regards,
Nitin
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org] 
Sent: Sunday, April 01, 2018 6:06 AM
To: Nitin Katiyar <nitin.kati...@ericsson.com>
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Adding cli for displaying LACP counters

On Thu, Mar 29, 2018 at 02:16:34AM +0530, Nitin Katiyar wrote:
> Currently OVS does not provide any command to display stats for LACP 
> without which it is difficult to debug LACP issues. Here we propose to 
> display various statistics about LACP PDUs and slave state change.

Thanks for adding this feature.  The implementation looks good.

Please add documentation for this feature in ovs-vswitchd(8).

Please add a NEWS item.

Thanks,

Ben.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Adding cli for displaying LACP counters

2018-03-31 Thread Ben Pfaff 
On Thu, Mar 29, 2018 at 02:16:34AM +0530, Nitin Katiyar wrote:
> Currently OVS does not provide any command to display stats for LACP
> without which it is difficult to debug LACP issues. Here we propose
> to display various statistics about LACP PDUs and slave state change.

Thanks for adding this feature.  The implementation looks good.

Please add documentation for this feature in ovs-vswitchd(8).

Please add a NEWS item.

Thanks,

Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev