Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct state.

-Mesaj original- De la: Anand Kumar [mailto:kumaran...@vmware.com] Trimis: Saturday, February 3, 2018 12:28 AM Către: Alin Serdean <aserd...@cloudbasesolutions.com>; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for inva

Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct state.

Hi Alin, Thanks for the quick review. I will expand log messages to “Invalid XXX packet detected”. I’m not sure if I follow your comment about “s/syn/SYN/g”. Do you want me to change it to Uppercase? Thanks, Anand Kumar On 2/2/18, 2:06 PM, "Alin Serdean"

Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct state.

Looks good just a small nit: s/syn/SYN/g s/ack/ACK/g Also I would prefer if you drop the text `Invalid!`. Either just remove it or expand it, i.e.: "Invalid! ICMPhdr cannot be NULL" => "Invalid ICMP packet detected the header cannot be NULL" Thanks, Alin. -Mesaj original- De la: