Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

2018-03-10 Thread Daniel Alvarez Sanchez
Done: https://patchwork.ozlabs.org/patch/884143/ Thanks a lot again for taking a look. I'd appreciate the backport into 2.9 as well if you all agree. Regards, Daniel On Sat, Mar 10, 2018 at 1:35 PM, Daniel Alvarez Sanchez wrote: > Thanks a lot Ben and Mark. > Yes, I'll be sending it right away.

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

2018-03-10 Thread Daniel Alvarez Sanchez
Thanks a lot Ben and Mark. Yes, I'll be sending it right away. Thanks a lot guys. On Fri, Mar 9, 2018 at 8:13 PM, Ben Pfaff wrote: > On Fri, Mar 09, 2018 at 08:05:22AM -0600, Mark Michelson wrote: > > Hi Daniel, > > > > Mostly this looks correct. I had one small finding and have noted it > in-li

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

2018-03-09 Thread Ben Pfaff
On Fri, Mar 09, 2018 at 08:05:22AM -0600, Mark Michelson wrote: > Hi Daniel, > > Mostly this looks correct. I had one small finding and have noted it in-line > down below. > > On 03/08/2018 04:20 PM, Daniel Alvarez wrote: > >Before this patch, the databases were automatically compacted when a > >

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

2018-03-09 Thread Ben Pfaff
On Thu, Mar 08, 2018 at 11:20:56PM +0100, Daniel Alvarez wrote: > Before this patch, the databases were automatically compacted when a > transaction is logged when: > > * It's been > 10 minutes after last compaction AND > * At least 100 commits have occurred AND > * Database has grown at least 4x

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

2018-03-09 Thread Mark Michelson
Hi Daniel, Mostly this looks correct. I had one small finding and have noted it in-line down below. On 03/08/2018 04:20 PM, Daniel Alvarez wrote: Before this patch, the databases were automatically compacted when a transaction is logged when: * It's been > 10 minutes after last compaction AN