Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-11-03 Thread Ben Pfaff
On Fri, Nov 03, 2017 at 07:26:05PM +0100, Timothy M. Redaelli wrote: > On 11/03/2017 07:20 PM, Ben Pfaff wrote: > [...] > >> > >> This looks good to me, my only comment is that the script is in rhel/ > >> and uses systemd so maybe we should reflect that in the script's name? > >> Because OVS itself

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-11-03 Thread Timothy M. Redaelli
On 11/03/2017 07:20 PM, Ben Pfaff wrote: [...] >> >> This looks good to me, my only comment is that the script is in rhel/ >> and uses systemd so maybe we should reflect that in the script's name? >> Because OVS itself might provide an ovs-reload too and then we will >> have issues. >> >> What do y

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-11-03 Thread Ben Pfaff
On Fri, Nov 03, 2017 at 01:55:00PM -0200, Flavio Leitner wrote: > On Tue, 31 Oct 2017 12:11:32 +0100 > Timothy Redaelli wrote: > > > The reload procedure will trigger a script that saves the flows and tlv > > maps (using ovs-save) then it restarts ovsdb-server, it stops ovs-vswitchd, > > it sets

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-11-03 Thread Flavio Leitner
On Tue, 31 Oct 2017 12:11:32 +0100 Timothy Redaelli wrote: > The reload procedure will trigger a script that saves the flows and tlv > maps (using ovs-save) then it restarts ovsdb-server, it stops ovs-vswitchd, > it sets other_config:flow-restore-wait=true (to wait till flow restore is > finished

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-13 Thread Markos Chandras
On 08/08/2017 11:01 PM, Timothy M. Redaelli wrote: > > The script is actually "specialized" to how Fedora/RHEL starts > openvswitch since, I think, only Fedora/RHEL have ovsdb-server and > ovs-vswitchd as splitted systemd unit files. For the record, SUSE uses the same approach > [...] > > Sound

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-08 Thread Timothy M. Redaelli
On 08/08/2017 08:24 PM, Guru Shetty wrote: > > > On 8 August 2017 at 11:05, Russell Bryant > wrote: > > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty > wrote: > > On 8 August 2017 at 07:42, Timothy Redaelli >

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-08 Thread Guru Shetty
On 8 August 2017 at 11:05, Russell Bryant wrote: > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty wrote: > > On 8 August 2017 at 07:42, Timothy Redaelli > wrote: > > > >> The reload procedure will trigger a script that saves the flows and tlv > >> maps then it restarts ovsdb-server, it stops ovs-v

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-08 Thread Russell Bryant
On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty wrote: > On 8 August 2017 at 07:42, Timothy Redaelli wrote: > >> The reload procedure will trigger a script that saves the flows and tlv >> maps then it restarts ovsdb-server, it stops ovs-vswitchd, it sets >> other_config:flow-restore-wait=true (to wai

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-08 Thread Guru Shetty
On 8 August 2017 at 07:42, Timothy Redaelli wrote: > The reload procedure will trigger a script that saves the flows and tlv > maps then it restarts ovsdb-server, it stops ovs-vswitchd, it sets > other_config:flow-restore-wait=true (to wait till flow restore is > finished), it starts ovs-vswitchd