Re: [ovs-dev] [PATCH] xlate: Correct handling of double encap() actions

2018-04-05 Thread Ben Pfaff
On Thu, Apr 05, 2018 at 02:17:49PM +, Jan Scheurich wrote: > > > > > > This fix should be backported OVS 2.8 and 2.9 > > > > This seems tricky. Do you plan to write a test? > > Hi Ben, > > I have just posted v2 where I have added an NSH unit test for double NSH plus > Ethernet

Re: [ovs-dev] [PATCH] xlate: Correct handling of double encap() actions

2018-04-05 Thread Jan Scheurich
> > > > This fix should be backported OVS 2.8 and 2.9 > > This seems tricky. Do you plan to write a test? Hi Ben, I have just posted v2 where I have added an NSH unit test for double NSH plus Ethernet encapsulation. The test also covers encap() actions in group buckets. BR, Jan

Re: [ovs-dev] [PATCH] xlate: Correct handling of double encap() actions

2018-04-04 Thread Ben Pfaff
On Mon, Mar 26, 2018 at 09:44:21AM +0200, Jan Scheurich wrote: > When the same encap() header was pushed twice onto a packet (e.g in the > case of NSH in NSH), the translation logic only generated a datapath push > action for the first encap() action. The second encap() did not emit a > push