Re: [ovs-dev] [PATCH 1/3] checkpatch: Check for infix operator whitespace.

[Joe Stringer]

On 9 August 2017 at 13:58, Ben Pfaff  wrote:
> On Wed, Aug 09, 2017 at 01:37:50PM -0700, Joe Stringer wrote:
>> The 'Expressions' section of the coding style specifies that one space
>> should be on either side of infix binary and ternary operators. This
>> adds a check to checkpatch.py for most of these.
>>
>> The regex won't match if there are speech marks on the line, because
>> the style should not apply to the contents of strings.
>>
>> This check is left at warning level because there isn't a good way to
>> determine whether a line is within a multiline comment or string, so it
>> will occasionally flag such lines which contain hyphenated words.
>>
>> Signed-off-by: Joe Stringer 
>
> Acked-by: Ben Pfaff 

Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] checkpatch: Check for infix operator whitespace.

[Ben Pfaff]

On Wed, Aug 09, 2017 at 01:37:50PM -0700, Joe Stringer wrote:
> The 'Expressions' section of the coding style specifies that one space
> should be on either side of infix binary and ternary operators. This
> adds a check to checkpatch.py for most of these.
> 
> The regex won't match if there are speech marks on the line, because
> the style should not apply to the contents of strings.
> 
> This check is left at warning level because there isn't a good way to
> determine whether a line is within a multiline comment or string, so it
> will occasionally flag such lines which contain hyphenated words.
> 
> Signed-off-by: Joe Stringer 

Acked-by: Ben Pfaff 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev