Re: [ovs-dev] [PATCH 2/3] ofproto-dpif: Improve dp_hash selection method for select groups

2018-04-11 Thread Jan Scheurich
Hi Ychen, Thanks a lot for your tests of corner cases and suggested bug fixes. I will include fixes in the next version, possibly also unit test cases for those. A bucket weight of zero should in my eyes imply no traffic to that bucket. I will check how to achieve that. I will also look into y

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif: Improve dp_hash selection method for select groups

2018-04-10 Thread ychen
Hi, Jan: When I test dp_hash with the new patch, vswitchd was killed by segment fault in some conditions. 1. add group with no buckets, then winner will be NULL 2. add buckets with weight with 0, then winner will also be NULL I did little modify to the patch, will you help to check w