Re: [ovs-dev] [PATCH 4/7] Add OpenFlow extensions for group support in OpenFlow 1.0.

2018-05-17 Thread Ben Pfaff 
On Wed, May 16, 2018 at 10:37:15PM -0700, Justin Pettit wrote:
> 
> 
> > On May 10, 2018, at 4:24 PM, Ben Pfaff  wrote:
> > 
> > Signed-off-by: Ben Pfaff 
> > ---
> > include/openflow/openflow-1.5.h  |   3 +-
> > include/openvswitch/ofp-errors.h |  54 +
> > include/openvswitch/ofp-msgs.h   |  35 ---
> > lib/nx-match.c   |  11 +---
> > lib/ofp-group.c  | 120 +
> > lib/ofp-print.c  |   2 +-
> > manpages.mk  |   1 +
> > tests/ofp-print.at   | 126 
> > ++-
> > tests/ofproto.at |  93 +++--
> > 9 files changed, 304 insertions(+), 141 deletions(-)
> 
> Do you think it's worth mentioning in NEWS?  Also, the ovs-ofctl man
> page should probably be updated to indicate this is no longer limited
> to OpenFlow 1.1.  Also, it mentions that specific groups can only be
> dumped with OpenFlow 1.5, but it looks like it now also includes
> OpenFlow 1.0+NXT.

Thanks, I added docs.  I applied this series to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/7] Add OpenFlow extensions for group support in OpenFlow 1.0.

2018-05-16 Thread Justin Pettit 


> On May 10, 2018, at 4:24 PM, Ben Pfaff  wrote:
> 
> Signed-off-by: Ben Pfaff 
> ---
> include/openflow/openflow-1.5.h  |   3 +-
> include/openvswitch/ofp-errors.h |  54 +
> include/openvswitch/ofp-msgs.h   |  35 ---
> lib/nx-match.c   |  11 +---
> lib/ofp-group.c  | 120 +
> lib/ofp-print.c  |   2 +-
> manpages.mk  |   1 +
> tests/ofp-print.at   | 126 ++-
> tests/ofproto.at |  93 +++--
> 9 files changed, 304 insertions(+), 141 deletions(-)

Do you think it's worth mentioning in NEWS?  Also, the ovs-ofctl man page 
should probably be updated to indicate this is no longer limited to OpenFlow 
1.1.  Also, it mentions that specific groups can only be dumped with OpenFlow 
1.5, but it looks like it now also includes OpenFlow 1.0+NXT.

> diff --git a/manpages.mk b/manpages.mk
> index f579e5cbd95e..da0b16203afa 100644
> --- a/manpages.mk
> +++ b/manpages.mk
> @@ -273,6 +273,7 @@ lib/memory-unixctl.man:
> lib/netdev-dpdk-unixctl.man:
> lib/service.man:
> lib/ssl-bootstrap.man:
> +lib/ssl-peer-ca-cert.man:
> lib/ssl.man:
> lib/unixctl.man:
> lib/vlog-unixctl.man:

Did you mean to include this?

Acked-by: Justin Pettit 

--Justin


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev