Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

2024-04-12 Thread Dumitru Ceara
On 4/5/24 11:55, Xavier Simonart wrote: > Hi Mark > > Thanks for the review. > > On Thu, Apr 4, 2024 at 10:25 PM Mark Michelson wrote: > >> Hi Xavier, the patch looks good, but I have one question down below. >> >> On 3/26/24 07:56, Xavier Simonart wrote: >>> The macro

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

2024-04-05 Thread Xavier Simonart
Hi Mark Thanks for the review. On Thu, Apr 4, 2024 at 10:25 PM Mark Michelson wrote: > Hi Xavier, the patch looks good, but I have one question down below. > > On 3/26/24 07:56, Xavier Simonart wrote: > > The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then > > recomputes, then

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

2024-04-04 Thread Mark Michelson
Hi Xavier, the patch looks good, but I have one question down below. On 3/26/24 07:56, Xavier Simonart wrote: The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then recomputes, then dumps again the Openflows, and finally compares both sets of flows. The test fails if flows are

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

2024-03-28 Thread Ales Musil
On Tue, Mar 26, 2024 at 12:57 PM Xavier Simonart wrote: > The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then > recomputes, then dumps again the Openflows, and finally compares > both sets of flows. The test fails if flows are different. > As of now, the macro cannot be used in all