Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-05-10 Thread Han Zhou
On Thu, Apr 12, 2018 at 10:19 AM, Ben Pfaff wrote: > > On Wed, Apr 11, 2018 at 11:29:28PM -0700, Han Zhou wrote: > > On Tue, Apr 10, 2018 at 6:21 PM, Han Zhou wrote: > > > > > > > > > > > > On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > > >

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-12 Thread Ben Pfaff
On Wed, Apr 11, 2018 at 11:29:28PM -0700, Han Zhou wrote: > On Tue, Apr 10, 2018 at 6:21 PM, Han Zhou wrote: > > > > > > > > On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > > > > > On Fri, Apr 06, 2018 at 02:40:21PM -0700, Han Zhou wrote: > > > > On Fri,

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-12 Thread Han Zhou
On Tue, Apr 10, 2018 at 6:21 PM, Han Zhou wrote: > > > > On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > > > On Fri, Apr 06, 2018 at 02:40:21PM -0700, Han Zhou wrote: > > > On Fri, Apr 6, 2018 at 1:54 PM, Ben Pfaff wrote: > > > > > > > >

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-10 Thread Han Zhou
On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > On Fri, Apr 06, 2018 at 02:40:21PM -0700, Han Zhou wrote: > > On Fri, Apr 6, 2018 at 1:54 PM, Ben Pfaff wrote: > > > > > > Thanks for working on making OVN faster and scale better. > > > > > > I see what you mean

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-10 Thread Ben Pfaff
On Fri, Apr 06, 2018 at 02:40:21PM -0700, Han Zhou wrote: > On Fri, Apr 6, 2018 at 1:54 PM, Ben Pfaff wrote: > > > > Thanks for working on making OVN faster and scale better. > > > > I see what you mean about how nb_cfg can be a scale problem. Really, > > each hypervisor only cares

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-06 Thread Han Zhou
On Fri, Apr 6, 2018 at 1:54 PM, Ben Pfaff wrote: > > Thanks for working on making OVN faster and scale better. > > I see what you mean about how nb_cfg can be a scale problem. Really, > each hypervisor only cares about its own row, but each of them is being > notified about the

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-06 Thread Ben Pfaff
Thanks for working on making OVN faster and scale better. I see what you mean about how nb_cfg can be a scale problem. Really, each hypervisor only cares about its own row, but each of them is being notified about the current value in every row. Ideally, we want the HVs to be able to say to

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-03-25 Thread Anil Venkata
Acked-By: Venkata Anil I have reviewed and tested the patch. It looks good to me. Thanks Anil On Mon, Mar 26, 2018 at 11:09 AM, Anil Venkata wrote: > > On Sat, Mar 24, 2018 at 7:06 AM, Han Zhou wrote: > >> Anil, thanks for the

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-03-25 Thread Anil Venkata
On Sat, Mar 24, 2018 at 7:06 AM, Han Zhou wrote: > Anil, thanks for the review! > > On Thu, Mar 22, 2018 at 11:12 PM, Anil Venkata > wrote: > > > > Is it possible to add a test for this patch i.e testing if hypervisors > correctly updating > >

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-03-23 Thread Han Zhou
Anil, thanks for the review! On Thu, Mar 22, 2018 at 11:12 PM, Anil Venkata wrote: > > Is it possible to add a test for this patch i.e testing if hypervisors correctly updating > Chassis_NB_Cfg's nb_cfg when a new value is assigned to NB_Global's nb_cfg? > Please see

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-03-23 Thread Anil Venkata
Is it possible to add a test for this patch i.e testing if hypervisors correctly updating Chassis_NB_Cfg's nb_cfg when a new value is assigned to NB_Global's nb_cfg? Please see other comments inline Thanks Anil On Thu, Mar 22, 2018 at 4:57 AM, Han Zhou wrote: > nb_cfg as a