Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-02-01 Thread Ben Pfaff
On Fri, Jan 26, 2018 at 04:23:44PM -0200, Flavio Leitner wrote: > Hi Ben, > > > On Wed, Jan 10, 2018 at 04:07:38PM -0800, Ben Pfaff wrote: > > Thanks for the series. I actually think that it's pretty close. For > > me, this series falls into the category of "obviously the right > > direction

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-26 Thread Flavio Leitner
Hi Ben, On Wed, Jan 10, 2018 at 04:07:38PM -0800, Ben Pfaff wrote: > Thanks for the series. I actually think that it's pretty close. For > me, this series falls into the category of "obviously the right > direction but impossible to fully validate before applying it". It > builds fine and I

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-11 Thread Flavio Leitner
On Wed, Jan 10, 2018 at 04:07:38PM -0800, Ben Pfaff wrote: > Thanks for the series. I actually think that it's pretty close. For > me, this series falls into the category of "obviously the right > direction but impossible to fully validate before applying it". It I have the same feeling and

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-10 Thread Ben Pfaff
Thanks for the series. I actually think that it's pretty close. For me, this series falls into the category of "obviously the right direction but impossible to fully validate before applying it". It builds fine and I was about to push it when I realized that it breaks most of the unit tests

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

2018-01-05 Thread Flavio Leitner
Hi, I know this change is not easy to review, but at the same time we are getting close to the release date. I am afraid that delaying the acceptance will reduce its exposure and testing. Please let me know the questions you might have to help you reviewing this patchset. Thanks, fbl On