Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-11 Thread Ilya Maximets
On 11.08.2017 16:11, Bodireddy, Bhanuprakash wrote: >> On 09.08.2017 15:35, Bodireddy, Bhanuprakash wrote: > > +static int > +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) { > +struct dpdk_tx_queue *txq = >tx_q[qid]; > +struct rte_mbuf **cur_pkts =

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-11 Thread Ilya Maximets
On 10.08.2017 21:52, Bodireddy, Bhanuprakash wrote: >>> > } else { > +/* If the queue is disabled in the guest, the > corresponding qid > + * map shall be set to OVS_VHOST_QUEUE_DISABLED(-2). > + * > +

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-11 Thread Bodireddy, Bhanuprakash
>On 09.08.2017 15:35, Bodireddy, Bhanuprakash wrote: +static int +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) { +struct dpdk_tx_queue *txq = >tx_q[qid]; +struct rte_mbuf **cur_pkts = (struct rte_mbuf +**)txq->vhost_burst_pkts; + +

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-10 Thread Bodireddy, Bhanuprakash
>> } else { +/* If the queue is disabled in the guest, the corresponding qid + * map shall be set to OVS_VHOST_QUEUE_DISABLED(-2). + * + * The packets that were queued in 'qid' could be

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
On 09.08.2017 15:35, Bodireddy, Bhanuprakash wrote: >>> >>> +static int >>> +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) { >>> +struct dpdk_tx_queue *txq = >tx_q[qid]; >>> +struct rte_mbuf **cur_pkts = (struct rte_mbuf >>> +**)txq->vhost_burst_pkts; >>> + >>> +int

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Bodireddy, Bhanuprakash
>enable) if (enable) { dev->tx_q[qid].map = qid; >> >> Here flushing required too because we're possibly enabling previously >remapped queue. >> } else { +/* If the queue is disabled in the guest, the

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Bodireddy, Bhanuprakash
>> >> +static int >> +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) { >> +struct dpdk_tx_queue *txq = >tx_q[qid]; >> +struct rte_mbuf **cur_pkts = (struct rte_mbuf >> +**)txq->vhost_burst_pkts; >> + >> +int tx_vid = netdev_dpdk_get_vid(dev); >> +int tx_qid = qid *

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
On 09.08.2017 13:03, Ilya Maximets wrote: > One more comment inline. > > On 09.08.2017 11:06, Ilya Maximets wrote: >> Not a full review. >> One comment inline. >> >>> Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User >>> port queues. Also add netdev_dpdk_vhost_tx_burst()

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
One more comment inline. On 09.08.2017 11:06, Ilya Maximets wrote: > Not a full review. > One comment inline. > >> Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User >> port queues. Also add netdev_dpdk_vhost_tx_burst() function that >> uses rte_vhost_enqueue_burst() to

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
Not a full review. One comment inline. > Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User > port queues. Also add netdev_dpdk_vhost_tx_burst() function that > uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User > ports. > > Signed-off-by: Bhanuprakash