Thanks Darrell. Patch looks ok to me.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 28, 2019 at 1:43 AM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> That is interesting
>
> i just tried applying on top of tree and I see that the git applies some
> changes (2 lines)
>
> in extract_l4_icmp6() rather the intended extract_l4_icmp() as in the
> patch I
That is interesting
i just tried applying on top of tree and I see that the git applies some
changes (2 lines)
in extract_l4_icmp6() rather the intended extract_l4_icmp() as in the patch I
sent out.
My guess is that the surrounding lines are identical in the 2 functions and I
had other
patches
On Tue, Aug 27, 2019 at 2:02 AM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> Hi Darrell,
>
> Thanks for the patch. When I applied the patch to latest master,
> I see that we take care of length check (< 8) only for ICMPv6 and
> not for ICMPv4.
That is interesting
i just tried
Hi Darrell,
Thanks for the patch. When I applied the patch to latest master,
I see that we take care of length check (< 8) only for ICMPv6 and
not for ICMPv4. We need to do it for ICMPv4 as well.
Also, we are already using 'related' to skip or not to skip length check.
* If 'related' is
Resent this patch, as it had a bad e-mail address
Darrell
On Mon, Aug 26, 2019 at 9:06 AM Darrell Ball wrote:
> The ICMP error data L4 length check was found to be too strict for TCP,
> expecting a minimum of 20 rather than 8 bytes. This worked by
> hapenstance for other inner protocols. The
