Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-12-03 Thread Daniel Alvarez Sanchez
On Mon, Dec 3, 2018 at 3:48 PM Mark Michelson wrote: > > On 12/01/2018 03:44 PM, Han Zhou wrote: > > > > > > On Fri, Nov 30, 2018 at 7:29 AM Daniel Alvarez Sanchez > > mailto:dalva...@redhat.com>> wrote: > > > > > > Thanks folks again for the discussion. > > > I sent an RFC patch here [0]. I

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-12-01 Thread Han Zhou
On Fri, Nov 30, 2018 at 7:29 AM Daniel Alvarez Sanchez wrote: > > Thanks folks again for the discussion. > I sent an RFC patch here [0]. I tried it out with my reproducer and it > seems to work well. Instead of outputting the packet to the localnet > ofport, it will inject it to the public switch

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-30 Thread Daniel Alvarez Sanchez
Thanks folks again for the discussion. I sent an RFC patch here [0]. I tried it out with my reproducer and it seems to work well. Instead of outputting the packet to the localnet ofport, it will inject it to the public switch pipeline so it'll get broadcasted to the rest of the ports resulting in

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-28 Thread Ben Pfaff
On Wed, Nov 28, 2018 at 03:17:10PM +0100, Daniel Alvarez Sanchez wrote: > On Wed, Nov 28, 2018 at 3:10 PM Ben Pfaff wrote: > > > > On Wed, Nov 28, 2018 at 12:07:55PM +0100, Daniel Alvarez Sanchez wrote: > > > On Mon, Nov 26, 2018 at 9:30 PM Ben Pfaff wrote: > > > > > > > > On Fri, Nov 16, 2018

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-28 Thread Daniel Alvarez Sanchez
Hi all, As this thread is getting big I'm summarizing the issue I see so far: * When a dnat_and_snat entry is added to a logical router (or port gets bound to a chassis), ovn-controller will send GARPs to announce the MAC address of the FIP(s) (either the gw port or of the actual FIP MAC address

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-28 Thread Daniel Alvarez Sanchez
On Wed, Nov 28, 2018 at 3:10 PM Ben Pfaff wrote: > > On Wed, Nov 28, 2018 at 12:07:55PM +0100, Daniel Alvarez Sanchez wrote: > > On Mon, Nov 26, 2018 at 9:30 PM Ben Pfaff wrote: > > > > > > On Fri, Nov 16, 2018 at 06:41:33PM +0100, Daniel Alvarez Sanchez wrote: > > > > +static void > > > >

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-28 Thread Ben Pfaff
On Wed, Nov 28, 2018 at 12:07:55PM +0100, Daniel Alvarez Sanchez wrote: > On Mon, Nov 26, 2018 at 9:30 PM Ben Pfaff wrote: > > > > On Fri, Nov 16, 2018 at 06:41:33PM +0100, Daniel Alvarez Sanchez wrote: > > > +static void > > > +delete_mac_binding_by_ip(struct northd_context *ctx, const char *ip)

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-28 Thread Daniel Alvarez Sanchez
On Mon, Nov 26, 2018 at 9:30 PM Ben Pfaff wrote: > > On Fri, Nov 16, 2018 at 06:41:33PM +0100, Daniel Alvarez Sanchez wrote: > > +static void > > +delete_mac_binding_by_ip(struct northd_context *ctx, const char *ip) > > +{ > > +const struct sbrec_mac_binding *b, *n; > > +

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-26 Thread Ben Pfaff
On Fri, Nov 16, 2018 at 06:41:33PM +0100, Daniel Alvarez Sanchez wrote: > +static void > +delete_mac_binding_by_ip(struct northd_context *ctx, const char *ip) > +{ > +const struct sbrec_mac_binding *b, *n; > +SBREC_MAC_BINDING_FOR_EACH_SAFE (b, n, ctx->ovnsb_idl) { > +if

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-23 Thread Daniel Alvarez Sanchez
On Wed, Nov 21, 2018 at 9:04 PM Han Zhou wrote: > > > > On Tue, Nov 20, 2018 at 5:21 AM Mark Michelson wrote: > > > > Hi Daniel, > > > > I agree with Numan that this seems like a good approach to take. > > > > On 11/16/2018 12:41 PM, Daniel Alvarez Sanchez wrote: > > > > > > On Sat, Nov 10, 2018

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-23 Thread Daniel Alvarez Sanchez
Hi Han, Yes, I agree that the patch is not enough. I'll take a look at the GARP thing because it's either not implemented or not working. Here's a reproducer while I jump back into it. When you ping 172.24.4.200 from the namespace 1 the first time, a MAC_Binding entry gets created: # ovn-sbctl

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-21 Thread Han Zhou
On Tue, Nov 20, 2018 at 5:21 AM Mark Michelson wrote: > > Hi Daniel, > > I agree with Numan that this seems like a good approach to take. > > On 11/16/2018 12:41 PM, Daniel Alvarez Sanchez wrote: > > > > On Sat, Nov 10, 2018 at 12:21 AM Ben Pfaff > > wrote: > > > > > > On

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-20 Thread Mark Michelson
Hi Daniel, I agree with Numan that this seems like a good approach to take. On 11/16/2018 12:41 PM, Daniel Alvarez Sanchez wrote: On Sat, Nov 10, 2018 at 12:21 AM Ben Pfaff > wrote: > > On Mon, Oct 29, 2018 at 05:21:13PM +0530, Numan Siddique wrote: > > On Mon, Oct

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-19 Thread Numan Siddique
On Mon, Nov 19, 2018 at 2:56 PM Daniel Alvarez Sanchez wrote: > Having thought this again, I'd rather merge the patch I proposed in my > previous email (I'd need tests and propose a formal patch after your > feedback) but in the long term I think it'd make sense to also implement > some sort of

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-19 Thread Daniel Alvarez Sanchez
Having thought this again, I'd rather merge the patch I proposed in my previous email (I'd need tests and propose a formal patch after your feedback) but in the long term I think it'd make sense to also implement some sort of aging to the MAC_Binding entries so that they eventually expire,

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-16 Thread Daniel Alvarez Sanchez
On Sat, Nov 10, 2018 at 12:21 AM Ben Pfaff wrote: > > On Mon, Oct 29, 2018 at 05:21:13PM +0530, Numan Siddique wrote: > > On Mon, Oct 29, 2018 at 5:00 PM Daniel Alvarez Sanchez < dalva...@redhat.com> > > wrote: > > > > > Hi, > > > > > > After digging further. The problem seems to be reduced to

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-11-09 Thread Ben Pfaff
On Mon, Oct 29, 2018 at 05:21:13PM +0530, Numan Siddique wrote: > On Mon, Oct 29, 2018 at 5:00 PM Daniel Alvarez Sanchez > wrote: > > > Hi, > > > > After digging further. The problem seems to be reduced to reusing an > > old gateway IP address for a dnat_and_snat entry. > > When a gateway port

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-10-29 Thread Numan Siddique
On Mon, Oct 29, 2018 at 5:00 PM Daniel Alvarez Sanchez wrote: > Hi, > > After digging further. The problem seems to be reduced to reusing an > old gateway IP address for a dnat_and_snat entry. > When a gateway port is bound to a chassis, its entry will show up in > the MAC_Binding table (at

Re: [ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-10-29 Thread Daniel Alvarez Sanchez
Hi, After digging further. The problem seems to be reduced to reusing an old gateway IP address for a dnat_and_snat entry. When a gateway port is bound to a chassis, its entry will show up in the MAC_Binding table (at least when that Logical Switch is connected to more than one Logical Router).

[ovs-discuss] OVN: MAC_Binding entries not getting updated leads to unreachable destinations

2018-10-26 Thread Daniel Alvarez Sanchez
Hi all, While analyzing a problem in OpenStack I think I have found out a severe bug in OVN when it comes to reuse floating IPs (which is a very common use case in OpenStack and Kubernetes). Let me explain the scenario, issue and possible solutions: * Three logical switches (Neutron networks)