Re: [ovs-discuss] Lost in translation! OFP to DPDK datapath OVS actions?

2018-01-24 Thread Ben Pfaff
Maybe. Sometimes it's too hard to keep track of changes just by looking at the flow. On Wed, Jan 24, 2018 at 08:18:12PM +0100, Alan Kayahan wrote: > Thanks for bearing with me so far Ben. I will post my experience in > creating a custom action and match step by step like some others have done >

Re: [ovs-discuss] Lost in translation! OFP to DPDK datapath OVS actions?

2018-01-22 Thread Ben Pfaff
Actions that just set fields don't emit ODP actions to do that immediately because controllers often change fields multiple times between outputs, so that it would be wasteful to emit the changes multiple times. Instead, at the time of emitting an output (or other visible side effect), OVS emits

Re: [ovs-discuss] Lost in translation! OFP to DPDK datapath OVS actions?

2018-01-13 Thread Alan Kayahan
Indeed. My custom action works when I put nl_msg_put_flag(ctx->odp_actions, OVS_ACTION_ATTR_MY_ACTION); however none of the other cases follow this pattern. They all set flow->xxx from the struct casted ofpact instead. Since both setting ctx->odp_actions and flow->xxx works, I have the following

Re: [ovs-discuss] Lost in translation! OFP to DPDK datapath OVS actions?

2018-01-12 Thread Ben Pfaff
On Fri, Jan 12, 2018 at 11:39:44AM +0100, Alan Kayahan wrote: > Hello, > > Per my understanding from /ovs-discuss/2015-May/037313.html, > ofproto-dpif-xlate translates OFP actions into Netlink format, which is > useful for datapath actions implemented in the kernel module. Does that > hold for