Re: [ovs-discuss] Confusing errors in response to incorrectly formed OFPGroupMod

2019-01-09 Thread Ben Pfaff
On Tue, Jan 08, 2019 at 04:04:37PM +0300, Artem Gromov wrote: > Hi, > OVS sends confusing error message to incorrectly formed OFPGroupMod message > with OFPGC_ADD command and command_bucket_id set. > > This condition (absence of else keyword and body) is probably the main > cause: >

[ovs-discuss] Confusing errors in response to incorrectly formed OFPGroupMod

2019-01-08 Thread Artem Gromov
Hi, OVS sends confusing error message to incorrectly formed OFPGroupMod message with OFPGC_ADD command and command_bucket_id set. This condition (absence of else keyword and body) is probably the main cause: https://github.com/openvswitch/ovs/blob/master/lib/ofp-group.c#L2188 It should be