> > > PS. Would it be possible to get my current work reviewed? I'm not > > > quite ready to push it upstream, but it would be good to know early if > > > there is anything there that would prevent it from being merged. My > repo > > is here: > > > https://github.com/InfernoEmbedded/owfs/tree/infernoembedded > > > > > Please do not use the same source file for both your upcoming host and > > your > > current LED controller and relay boards. > > > > No worries, this would be a completely separate device. > > The other devices are shared as they have to maintain the same serial > number > when they drop to their bootloader for firmware update. I've separated the > code, but for the compiler's sake, they are #included into a single > amorphous blob to avoid leaking symbols. > > > > > If you are happy with your current devices **and have them tested against > > the current version of owfs**, prepare a patch and I will push it into > > master. > > You are the only one who can test it anyway as long noone else has this > > hardware. > > > > Ok, I'll retest over the next few days, thanks :) >
Resurrecting this thread as I've just submitted a PR on Github: https://github.com/owfs/owfs/pull/21 One question, my code has C99isms, which are fine for modern compilers as they default to C99. Older compilers default to C90. I can fix this in 2 ways: Easy way: add std=c99 to CFLAGS to force C99 mode Hard(er) way: Remove C99isms from the code. It's not that hard, but it will result in some vars getting a larger scope than they need. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alast...@d-silva.org blog: http://alastair.d-silva.org Twitter: @EvilDeece _______________________________________________ Owfs-developers mailing list Owfs-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/owfs-developers
