[
https://issues.apache.org/jira/browse/HDDS-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4024:
-
Labels: pull-request-available (was: )
> Avoid while loop too soon when exception happen
> --
runzhiwang opened a new pull request #1253:
URL: https://github.com/apache/hadoop-ozone/pull/1253
## What changes were proposed in this pull request?
When exception throw in `context.execute(executorService,
heartbeatFrequency, TimeUnit.MILLISECONDS)`, thread will not sleep and start
adoroszlai commented on a change in pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#discussion_r459868266
##
File path: hadoop-hdds/docs/content/start/StartFromDockerHub.md
##
@@ -72,7 +72,7 @@ connecting to the SCM's UI at
[http://localhost:9876](htt
runzhiwang created HDDS-4024:
Summary: Avoid while loop too soon when exception happen
Key: HDDS-4024
URL: https://issues.apache.org/jira/browse/HDDS-4024
Project: Hadoop Distributed Data Store
I
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4018:
-
Labels: pull-request-available (was: )
> Datanode log spammed by NPE
> --
runzhiwang commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663360990
@adoroszlai Thanks. I will file a new issue for that.
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4018:
---
Labels: (was: pull-request-available)
> Datanode log spammed by NPE
> --
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-4018.
Fix Version/s: 0.7.0
Resolution: Fixed
> Datanode log spammed by NPE
> --
adoroszlai commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663360651
Thanks @runzhiwang and @xiaoyuyao for the review.
> The reason of so many logs when NPE happen is when NPE happen, the thread
did not sleep and start another while
adoroszlai merged pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
maobaolong commented on a change in pull request #1096:
URL: https://github.com/apache/hadoop-ozone/pull/1096#discussion_r459858064
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
##
@@ -222,9 +224,7 @@ public Allocated
maobaolong commented on a change in pull request #1096:
URL: https://github.com/apache/hadoop-ozone/pull/1096#discussion_r459855685
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##
@@ -287,6 +287,9 @@
public static final String
cxorm commented on pull request #1247:
URL: https://github.com/apache/hadoop-ozone/pull/1247#issuecomment-663342109
Thank you @aeioulisa for the work (and all checks have passed), LGTM +1.
This is an automated message fro
captainzmc commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-663341909
Thanks for @cxorm 's review. I had revised the review issues. Could you take
another look？
This is an a
[
https://issues.apache.org/jira/browse/HDDS-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen reassigned HDDS-4023:
Assignee: Sammi Chen
> Delete closed container after all blocks have been deleted
> ---
[
https://issues.apache.org/jira/browse/HDDS-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen reassigned HDDS-3943:
Assignee: Sammi Chen
> Cleanup empty container directory
> -
>
>
Sammi Chen created HDDS-4023:
Summary: Delete closed container after all blocks have been deleted
Key: HDDS-4023
URL: https://issues.apache.org/jira/browse/HDDS-4023
Project: Hadoop Distributed Data Store
runzhiwang commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663328826
@adoroszlai Hi, There is one more comment.
The reason of so many logs when NPE happen is when NPE happen, the thread
did not sleep and start another while loop immedia
[
https://issues.apache.org/jira/browse/HDDS-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen updated HDDS-4011:
-
Target Version/s: 0.6.0
> Update S3 related documentation
> ---
>
>
[
https://issues.apache.org/jira/browse/HDDS-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen resolved HDDS-3658.
--
Resolution: Fixed
> Stop to persist container related pipeline info of each key into OM DB to
> reduce
[
https://issues.apache.org/jira/browse/HDDS-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen updated HDDS-3658:
-
Fix Version/s: 0.7.0
> Stop to persist container related pipeline info of each key into OM DB to
> reduce
ChenSammi commented on pull request #1012:
URL: https://github.com/apache/hadoop-ozone/pull/1012#issuecomment-663318814
Thanks @elek and @adoroszlai for review the code.
This is an automated message from the Apache Git Ser
ChenSammi merged pull request #1012:
URL: https://github.com/apache/hadoop-ozone/pull/1012
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
captainzmc closed pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/HDDS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham reassigned HDDS-4010:
Assignee: Bharat Viswanadham
> S3G startup fails when multiple service ids are conf
[
https://issues.apache.org/jira/browse/HDDS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4010:
-
Labels: pull-request-available (was: newbie pull-request-available)
> S3G startup fails w
bharatviswa504 opened a new pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252
## What changes were proposed in this pull request?
This Jira is to fix this TODO.
**OzoneServiceProvider.java L59:
// HA cluster.
//For now if multiple s
[
https://issues.apache.org/jira/browse/HDDS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4010:
-
Labels: newbie pull-request-available (was: newbie)
> S3G startup fails when multiple service ids
runzhiwang commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663285841
LGTM +1
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/HDDS-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4021:
Summary: Organize Recon DBs into a 'Definition'. (was: Recon NodeDB should
be part of the R
[
https://issues.apache.org/jira/browse/HDDS-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4021:
Summary: Organize Recon DBs into a 'DBDefinition'. (was: Organize Recon
DBs into a 'Definit
[
https://issues.apache.org/jira/browse/HDDS-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4021:
Description:
* ReconNodeManager uses node db in an old format which is not part of
ReconDBD
bharatviswa504 opened a new pull request #1251:
URL: https://github.com/apache/hadoop-ozone/pull/1251
## What changes were proposed in this pull request?
Ozone s3 API returns 400 Bad Request for head-bucket for non-existing bucket.
**hrt_qa$ aws s3api --ca-bundle=/usr/local/sha
[
https://issues.apache.org/jira/browse/HDDS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4022:
-
Labels: pull-request-available (was: )
> Ozone s3 API return 400 Bad Request for head-bucket for
[
https://issues.apache.org/jira/browse/HDDS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4022:
-
Labels: (was: S3)
> Ozone s3 API return 400 Bad Request for head-bucket for non existing
Bharat Viswanadham created HDDS-4022:
Summary: Ozone s3 API return 400 Bad Request for head-bucket for
non existing bucket
Key: HDDS-4022
URL: https://issues.apache.org/jira/browse/HDDS-4022
Proje
[
https://issues.apache.org/jira/browse/HDDS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4022:
-
Reporter: Namit Maheshwari (was: Bharat Viswanadham)
> Ozone s3 API return 400 Bad Reques
[
https://issues.apache.org/jira/browse/HDDS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4022:
-
Component/s: S3
> Ozone s3 API return 400 Bad Request for head-bucket for non existing buc
[
https://issues.apache.org/jira/browse/HDDS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4022:
-
Target Version/s: 0.6.0
Priority: Blocker (was: Major)
> Ozone s3 API return
[
https://issues.apache.org/jira/browse/HDDS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4022:
-
Labels: S3 (was: )
> Ozone s3 API return 400 Bad Request for head-bucket for non existing
Vivek Ratnavel Subramanian created HDDS-4021:
Summary: Recon NodeDB should be part of the ReconDBDefinition
Key: HDDS-4021
URL: https://issues.apache.org/jira/browse/HDDS-4021
Project: Hado
[
https://issues.apache.org/jira/browse/HDDS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan resolved HDDS-4008.
-
Resolution: Fixed
Merged the PR.
> Recon should fallback to ozone.om.service.ids when the
avijayanhwx merged pull request #1243:
URL: https://github.com/apache/hadoop-ozone/pull/1243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
avijayanhwx commented on pull request #1243:
URL: https://github.com/apache/hadoop-ozone/pull/1243#issuecomment-663225883
Thank you for the reviews @bharatviswa504 & @vivekratnavel.
This is an automated message from the Apac
[
https://issues.apache.org/jira/browse/HDDS-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4009:
Target Version/s: 0.7.0 (was: 0.6.0)
> Recon Overview page: The volume, bucket and key coun
bharatviswa504 commented on a change in pull request #1243:
URL: https://github.com/apache/hadoop-ozone/pull/1243#discussion_r459660177
##
File path:
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx
##
@@ -180,7 +180,7 @@ expo
bharatviswa504 edited a comment on pull request #1244:
URL: https://github.com/apache/hadoop-ozone/pull/1244#issuecomment-663149010
>As the parameter omMultipartKeyInfo of S3MultipartUploadCommitPartResponse
is annotation to Nullable, so, we should >consider possible NPE, for this, i
have
bharatviswa504 edited a comment on pull request #1244:
URL: https://github.com/apache/hadoop-ozone/pull/1244#issuecomment-663149010
>As the parameter omMultipartKeyInfo of S3MultipartUploadCommitPartResponse
is annotation to Nullable, so, we should >consider possible NPE, for this, i
have
bharatviswa504 edited a comment on pull request #1244:
URL: https://github.com/apache/hadoop-ozone/pull/1244#issuecomment-663150794
>BTW, i don't think i have a abortMPU operation by executed the following
command
>$ zcat logs/om-audit-host-*log.gz | grep "COMPLETE_MULTIPART_UPLOAD"
bharatviswa504 commented on pull request #1244:
URL: https://github.com/apache/hadoop-ozone/pull/1244#issuecomment-663150794
>BTW, i don't think i have a abortMPU operation by executed the following
command
>$ zcat logs/om-audit-host-*log.gz | grep "COMPLETE_MULTIPART_UPLOAD" | grep
bharatviswa504 commented on pull request #1244:
URL: https://github.com/apache/hadoop-ozone/pull/1244#issuecomment-663149010
>As the parameter omMultipartKeyInfo of S3MultipartUploadCommitPartResponse
is annotation to Nullable, so, we should >consider possible NPE, for this, i
have two sug
bharatviswa504 edited a comment on pull request #1244:
URL: https://github.com/apache/hadoop-ozone/pull/1244#issuecomment-663149010
>As the parameter omMultipartKeyInfo of S3MultipartUploadCommitPartResponse
is annotation to Nullable, so, we should >consider possible NPE, for this, i
have
avijayanhwx commented on a change in pull request #1243:
URL: https://github.com/apache/hadoop-ozone/pull/1243#discussion_r459622263
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
##
@@ -527,4 +529,45 @@ public static void validateKeyName(
[
https://issues.apache.org/jira/browse/HDDS-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163785#comment-17163785
]
Istvan Fajth commented on HDDS-4020:
I would like to suggest a few things for consider
[
https://issues.apache.org/jira/browse/HDDS-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163765#comment-17163765
]
maobaolong commented on HDDS-3994:
--
[~ljain] Thanks for your clarification, after a quick
avijayanhwx commented on a change in pull request #1243:
URL: https://github.com/apache/hadoop-ozone/pull/1243#discussion_r459591303
##
File path:
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx
##
@@ -180,7 +180,7 @@ export
[
https://issues.apache.org/jira/browse/HDDS-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal resolved HDDS-4006.
-
Fix Version/s: 0.6.0
Resolution: Fixed
> Disallow MPU on encrypted buckets.
> -
arp7 merged pull request #1241:
URL: https://github.com/apache/hadoop-ozone/pull/1241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Vivek Ratnavel Subramanian created HDDS-4020:
Summary: ACL commands like getacl and setacl should return a
response only when Native Authorizer is enabled
Key: HDDS-4020
URL: https://issues.apache.org/
avijayanhwx commented on a change in pull request #1096:
URL: https://github.com/apache/hadoop-ozone/pull/1096#discussion_r459577998
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/PipelineChoosePolicy.java
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the
[
https://issues.apache.org/jira/browse/HDDS-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4017:
---
Status: Patch Available (was: Open)
> Acceptance check may run against wrong commit
> ---
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4018:
-
Labels: pull-request-available (was: )
> Datanode log spammed by NPE
> --
adoroszlai opened a new pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250
## What changes were proposed in this pull request?
Avoid calling `task.await()` without first calling `task.execute()`. The
former uses variable initialized in the latter.
https
[
https://issues.apache.org/jira/browse/HDDS-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4017:
-
Labels: pull-request-available (was: )
> Acceptance check may run against wrong commit
>
adoroszlai opened a new pull request #1249:
URL: https://github.com/apache/hadoop-ozone/pull/1249
## What changes were proposed in this pull request?
Use commit SHA to checkout a specific commit on `push` and `schedule`
events. Keep using name for `pull_request` events (eg.
`refs/p
[
https://issues.apache.org/jira/browse/HDDS-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4019:
-
Labels: pull-request-available (was: )
> Show the storageDir while need init om or scm
>
maobaolong opened a new pull request #1248:
URL: https://github.com/apache/hadoop-ozone/pull/1248
## What changes were proposed in this pull request?
When you accident to use a wrong ozone-site.xml or wrong configure key
ozone.metadata.dirs to a new dir, the scm or om cannot start an
captainzmc commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459468457
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##
@@ -1706,21 +1706,24 @@ public boolean set
captainzmc commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459468457
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##
@@ -1706,21 +1706,24 @@ public boolean set
captainzmc commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459468457
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##
@@ -1706,21 +1706,24 @@ public boolean set
captainzmc commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459468457
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##
@@ -1706,21 +1706,24 @@ public boolean set
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai reassigned HDDS-4018:
--
Assignee: Attila Doroszlai
> Datanode log spammed by NPE
> ---
maobaolong created HDDS-4019:
Summary: Show the storageDir while need init om or scm
Key: HDDS-4019
URL: https://issues.apache.org/jira/browse/HDDS-4019
Project: Hadoop Distributed Data Store
Iss
[
https://issues.apache.org/jira/browse/HDDS-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-3511:
-
Labels: newbie pull-request-available (was: newbie)
> Fix definition of DelegationTokenTable in O
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4018:
---
Description:
{code}
datanode_1 | 2020-07-22 13:11:47,845 [Datanode State Machine Thread - 0]
aeioulisa opened a new pull request #1247:
URL: https://github.com/apache/hadoop-ozone/pull/1247
## What changes were proposed in this pull request?
Fix the definition of dTokenTable.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3511
#
[
https://issues.apache.org/jira/browse/HDDS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4018:
---
Description:
{code}
datanode_1 | 2020-07-22 13:11:47,845 [Datanode State Machine Thread - 0]
Attila Doroszlai created HDDS-4018:
--
Summary: Datanode log spammed by NPE
Key: HDDS-4018
URL: https://issues.apache.org/jira/browse/HDDS-4018
Project: Hadoop Distributed Data Store
Issue Typ
Attila Doroszlai created HDDS-4017:
--
Summary: Acceptance check may run against wrong commit
Key: HDDS-4017
URL: https://issues.apache.org/jira/browse/HDDS-4017
Project: Hadoop Distributed Data Store
[
https://issues.apache.org/jira/browse/HDDS-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163506#comment-17163506
]
Lokesh Jain commented on HDDS-3994:
---
[~maobaolong] the new retry policy was added to pro
ChenSammi removed a comment on pull request #1012:
URL: https://github.com/apache/hadoop-ozone/pull/1012#issuecomment-662971135
/retest
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] commented on pull request #1012:
URL: https://github.com/apache/hadoop-ozone/pull/1012#issuecomment-662971612
To re-run CI checks, please follow these steps with the source branch
checked out:
```
git commit --allow-empty -m 'trigger new CI check'
git push
``
ChenSammi commented on pull request #1012:
URL: https://github.com/apache/hadoop-ozone/pull/1012#issuecomment-662971135
/retest
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/HDDS-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163471#comment-17163471
]
Attila Doroszlai commented on HDDS-4014:
[~maobaolong], can you please link to the
captainzmc commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-662955406
> Thanks @captainzmc for the work.
> Overall the functionality-part is good and some suggestions is added
inline, test-related-part would be reviewed soon.
>
>
[
https://issues.apache.org/jira/browse/HDDS-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Istvan Fajth resolved HDDS-671.
---
Resolution: Not A Bug
This one does not seem to be a bug, but a permission issue only, which probably
[
https://issues.apache.org/jira/browse/HDDS-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-4004.
Fix Version/s: 0.7.0
Resolution: Fixed
> Remove unused jersey-json from transitive Ha
[
https://issues.apache.org/jira/browse/HDDS-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4004:
---
Labels: (was: pull-request-available)
> Remove unused jersey-json from transitive Hadoop dep
cxorm commented on pull request #1075:
URL: https://github.com/apache/hadoop-ozone/pull/1075#issuecomment-662881106
Sorry for I didn't have computer for last two weeks :cry:
Looking on this PR again.
This is an automated
ChenSammi commented on pull request #1241:
URL: https://github.com/apache/hadoop-ozone/pull/1241#issuecomment-662879210
The patch LGTM +1.
This is an automated message from the Apache Git Service.
To respond to the message,
cxorm commented on a change in pull request #1236:
URL: https://github.com/apache/hadoop-ozone/pull/1236#discussion_r459284202
##
File path: hadoop-ozone/dist/src/main/compose/ozonesecure-om-ha/test.sh
##
@@ -15,6 +15,7 @@
# See the License for the specific language governing
cxorm commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-66287
Sorry for my careless huge "Add single comment" yesterday.
There are Test-related-part and API-backward-compatibility-part to be
reviewed. (If anyone continue reviewing
adoroszlai commented on a change in pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#discussion_r459269878
##
File path: hadoop-hdds/docs/content/start/StartFromDockerHub.md
##
@@ -72,7 +72,7 @@ connecting to the SCM's UI at
[http://localhost:9876](htt
cxorm removed a comment on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-662824611
Thanks @captainzmc for the work.
Overall the functionalily-part is good and some suggestions is added inline,
test-related-part would be reviewd soon.
Here I
cxorm commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459266753
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##
@@ -204,6 +204,16 @@ public static Versioning getVersioning
cxorm commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459200596
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/VolumeArgs.java
##
@@ -122,8 +136,13 @@ public String getQuota() {
cxorm commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459196128
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/CreateVolumeHandler.java
##
@@ -58,9 +62,12 @@ protected void exec
cxorm commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459200918
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/CreateVolumeHandler.java
##
@@ -58,9 +62,12 @@ protected void exec
cxorm commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459194918
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/VolumeManagerImpl.java
##
@@ -273,12 +272,14 @@ private void setOwne
cxorm commented on a change in pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#discussion_r459192304
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##
@@ -1706,21 +1706,24 @@ public boolean setOwner
1 - 100 of 113 matches
Mail list logo
