[GitHub] [hadoop-ozone] amaliujia commented on pull request #1444: HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage

2020-10-02 Thread GitBox
amaliujia commented on pull request #1444: URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-702992752 @elek friendly ping~ WDYT on the idea in my previous reply? This is an automated message from the

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

2020-10-02 Thread GitBox
bharatviswa504 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r498972861 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0

[jira] [Resolved] (HDDS-4305) TestSchemaOneBackwardsCompatability has flaky block deletion tests

2020-10-02 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose resolved HDDS-4305. -- Resolution: Not A Bug Issue was caused by a divergence between my git repo and Apache master. >

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

2020-10-02 Thread GitBox
bharatviswa504 commented on pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#issuecomment-702871382 I will take a look at it today. Thanks, @avijayanhwx for tagging. This is an automated message

[jira] [Created] (HDDS-4305) TestSchemaOneBackwardsCompatability has flaky block deletion tests

2020-10-02 Thread Ethan Rose (Jira)
Ethan Rose created HDDS-4305: Summary: TestSchemaOneBackwardsCompatability has flaky block deletion tests Key: HDDS-4305 URL: https://issues.apache.org/jira/browse/HDDS-4305 Project: Hadoop Distributed

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #1471: Add try catch block to handle pipeline which does not exist

2020-10-02 Thread GitBox
sodonnel opened a new pull request #1471: URL: https://github.com/apache/hadoop-ozone/pull/1471 ## What changes were proposed in this pull request? If you call `pipelineManager.finalizeAndDestroyPipeline()` with onTimeout=false, then the finalizePipeline call will result in a

[jira] [Created] (HDDS-4304) Close Container event can fail if pipeline is removed

2020-10-02 Thread Stephen O'Donnell (Jira)
Stephen O'Donnell created HDDS-4304: --- Summary: Close Container event can fail if pipeline is removed Key: HDDS-4304 URL: https://issues.apache.org/jira/browse/HDDS-4304 Project: Hadoop Distributed

[jira] [Updated] (HDDS-4220) BlockManagerImpl#getBlockByID does unnecessary serialization

2020-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4220: - Labels: pull-request-available (was: ) > BlockManagerImpl#getBlockByID does unnecessary

[GitHub] [hadoop-ozone] errose28 opened a new pull request #1470: HDDS-4220. BlockManagerImpl#getBlockByID does unnecessary serialization

2020-10-02 Thread GitBox
errose28 opened a new pull request #1470: URL: https://github.com/apache/hadoop-ozone/pull/1470 ## What changes were proposed in this pull request? BlockManager#getBlockImpl now returns a BlockData object instead of a byte stream. After HDDS-3869, this object can be retrieved

[GitHub] [hadoop-ozone] fapifta commented on pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#issuecomment-702771988 Guys thank you for the reviews, hopefully I was able to address all the concerns mentioned so far, let me know if you see anything more, and please share your opinion

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498861508 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[jira] [Updated] (HDDS-4290) Enable insight point for SCM heartbeat protocol

2020-10-02 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-4290: --- Labels: (was: pull-request-available) > Enable insight point for SCM heartbeat protocol >

[jira] [Resolved] (HDDS-4290) Enable insight point for SCM heartbeat protocol

2020-10-02 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-4290. Fix Version/s: 1.1.0 Resolution: Fixed > Enable insight point for SCM heartbeat

[GitHub] [hadoop-ozone] adoroszlai edited a comment on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

2020-10-02 Thread GitBox
adoroszlai edited a comment on pull request #1453: URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-702728136 Thanks @elek for noticing and fixing this. It seems this was lost while resolving merge conflicts of another Insight improvement

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

2020-10-02 Thread GitBox
adoroszlai merged pull request #1453: URL: https://github.com/apache/hadoop-ozone/pull/1453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

2020-10-02 Thread GitBox
adoroszlai commented on pull request #1453: URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-702728136 Thanks @elek for noticing and fixing this. It seems this was lost while resolving merge conflicts

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498802254 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[jira] [Created] (HDDS-4303) Ensure LayoutVersion is unique and monotonicaly increasing in LayoutFeature enums

2020-10-02 Thread Jira
István Fajth created HDDS-4303: -- Summary: Ensure LayoutVersion is unique and monotonicaly increasing in LayoutFeature enums Key: HDDS-4303 URL: https://issues.apache.org/jira/browse/HDDS-4303 Project:

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498774350 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498766375 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498761138 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/StorageInfo.java ## @@ -150,6 +179,16 @@ private void

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498760977 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

2020-10-02 Thread GitBox
fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498760785 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1404: HDDS-2949: mkdir : store directory entries in a separate table

2020-10-02 Thread GitBox
rakeshadr commented on pull request #1404: URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-702608629 Thank you @bharatviswa504 and @linyiqun for help in reviews and provided really useful comments.

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

2020-10-02 Thread GitBox
adoroszlai commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r498684631 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientFactory.java ## @@ -0,0 +1,44 @@ +/* + * Licensed to the

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1467: HDDS-4268. Prepare for Upgrade step should purge the log after waiting for the last txn to be applied.

2020-10-02 Thread GitBox
linyiqun commented on a change in pull request #1467: URL: https://github.com/apache/hadoop-ozone/pull/1467#discussion_r498649951 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java ## @@ -432,7 +443,14 @@

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

2020-10-02 Thread GitBox
adoroszlai commented on pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#issuecomment-702565283 > ``` > Exception in thread "main" java.net.SocketException: Socket closed >at java.net.PlainSocketImpl.socketAccept(Native Method) >at

[GitHub] [hadoop-ozone] linyiqun commented on pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

2020-10-02 Thread GitBox
linyiqun commented on pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#issuecomment-702553239 @prashantpogde , the CI failure still happened, due to below socket closed error. Seems not related. ``` Exception in thread "main" java.net.SocketException: Socket

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

2020-10-02 Thread GitBox
linyiqun commented on a change in pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r498636258 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java ## @@ -240,8 +247,19 @@ public

[GitHub] [hadoop-ozone] linyiqun commented on pull request #1448: HDDS-4280. Document notable configurations for Recon.

2020-10-02 Thread GitBox
linyiqun commented on pull request #1448: URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-702548266 >Can we add a follow up JIRA to fix this inconsistent config key (recon.om.snapshot.task.interval.delay) ? Hi @avijayanhwx , I also find there is more other ozone